From: NamJae Jeon <linkinjeon@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: cjb@laptop.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, awarkentin@vmware.com,
adrian.hunter@intel.com, james_p_freyensee@linux.intel.com,
sebras@gmail.com, Ulf Hansson <Ulf.Hansson@stericsson.com>,
Stefan Nilsson XK <stefan.xk.nilsson@stericsson.com>,
Per Forlin <per.forlin@stericsson.com>,
johan.rudholm@stericsson.com
Subject: Re: [PATCH v2] mmc : general purpose partition support.
Date: Thu, 29 Sep 2011 17:35:04 +0900 [thread overview]
Message-ID: <CAKYAXd9GqnmV5vz1BUa0oaHE6TBt85gJKCxRmxuR=Qno5kXAkA@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdaCVj1J10BeCbOgwvRAqfN=gmV-1_FYmd9W1cwFqWMiag@mail.gmail.com>
2011/9/29 Linus Walleij <linus.walleij@linaro.org>:
> On Wed, Sep 28, 2011 at 3:50 PM, NamJae Jeon <linkinjeon@gmail.com> wrote:
>> 2011/9/28 Linus Walleij <linus.walleij@linaro.org>:
>>> On Sat, Sep 24, 2011 at 7:07 AM, Namjae Jeon <linkinjeon@gmail.com> wrote:
>>>>
>>>> 179 64 1024 mmcblk0boot1
>>>> 179 32 1024 mmcblk0boot0
>>>
>>> Does this mean that each GP-partition can contain an MBR and thus several
>>> subpartitions so we get things like:
>>>
>>> mmcblk0gp1p1, mmcblk0gp1p2...
>>>
>> Yes, We can divide dos partitions(included MBR) using fdisk like your
>> words(mmcblk0gp1p1, mmcblk0gp1p2...)
>
> OK that seems logical.
>
> If this goes in, make a mental note to patch udev default rules
> too, because currently they look like this:
>
> rules.d/60-persistent-storage.rules:KERNEL=="mmcblk[0-9]",
> SUBSYSTEMS=="mmc", ATTRS{name}=="?*", ATTRS{serial}=="?*",
> ENV{ID_NAME}="$attr{name}", ENV{ID_SERIAL}="$attr{serial}",
> SYMLINK+="disk/by-id/mmc-$env{ID_NAME}_$env{ID_SERIAL}"
> rules.d/60-persistent-storage.rules:KERNEL=="mmcblk[0-9]p[0-9]",
> ENV{ID_NAME}=="?*", ENV{ID_SERIAL}=="?*",
> SYMLINK+="disk/by-id/mmc-$env{ID_NAME}_$env{ID_SERIAL}-part%n"
>
> (I guess Android also has this kind of rule baked into its "big init"
> process that handles also what udev normally takes care of.)
>
> Anyway:
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Thanks Linus~
I will modify a little code to improve the readability.
When I post patch v3 again, plz ack one more.
>
> Yours,
> Linus Walleij
>
next prev parent reply other threads:[~2011-09-29 8:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-24 5:07 [PATCH v2] mmc : general purpose partition support Namjae Jeon
[not found] ` <4E80BE05.40401@linux.intel.com>
2011-09-28 1:13 ` NamJae Jeon
2011-09-28 1:13 ` NamJae Jeon
2011-09-28 11:21 ` Linus Walleij
2011-09-28 13:50 ` NamJae Jeon
2011-09-29 6:47 ` Linus Walleij
2011-09-29 8:35 ` NamJae Jeon [this message]
2011-09-28 16:08 ` Andrei Warkentin
2011-09-29 1:03 ` NamJae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKYAXd9GqnmV5vz1BUa0oaHE6TBt85gJKCxRmxuR=Qno5kXAkA@mail.gmail.com' \
--to=linkinjeon@gmail.com \
--cc=Ulf.Hansson@stericsson.com \
--cc=adrian.hunter@intel.com \
--cc=awarkentin@vmware.com \
--cc=cjb@laptop.org \
--cc=james_p_freyensee@linux.intel.com \
--cc=johan.rudholm@stericsson.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=per.forlin@stericsson.com \
--cc=sebras@gmail.com \
--cc=stefan.xk.nilsson@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.