From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758582Ab2CAHrV (ORCPT ); Thu, 1 Mar 2012 02:47:21 -0500 Received: from mail-bk0-f46.google.com ([209.85.214.46]:40756 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756583Ab2CAHrT convert rfc822-to-8bit (ORCPT ); Thu, 1 Mar 2012 02:47:19 -0500 Authentication-Results: mr.google.com; spf=pass (google.com: domain of linkinjeon@gmail.com designates 10.205.133.208 as permitted sender) smtp.mail=linkinjeon@gmail.com; dkim=pass header.i=linkinjeon@gmail.com MIME-Version: 1.0 In-Reply-To: <4934441a17d25c3249556f7bf281b1be.squirrel@www.codeaurora.org> References: <4934441a17d25c3249556f7bf281b1be.squirrel@www.codeaurora.org> Date: Thu, 1 Mar 2012 16:47:18 +0900 Message-ID: Subject: Re: [PATCH v5 2/2] mmc: core: Support packed command for eMMC4.5 device From: Namjae Jeon To: merez@codeaurora.org Cc: Seungwon Jeon , linux-mmc@vger.kernel.org, Chris Ball , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi. merez. Would you share random read speed with us ? And Write speed also.. Thanks. 2012/3/1 : >> This patch supports packed command of eMMC4.5 device. >> Several reads(or writes) can be grouped in packed command >> and all data of the individual commands can be sent in a >> single transfer on the bus. >> >> Signed-off-by: Seungwon Jeon >> --- >>  drivers/mmc/card/block.c   |  496 >> +++++++++++++++++++++++++++++++++++++++++-- >>  drivers/mmc/card/queue.c   |   48 ++++- >>  drivers/mmc/card/queue.h   |   13 ++ >>  drivers/mmc/core/mmc_ops.c |    1 + >>  include/linux/mmc/core.h   |    4 + >>  5 files changed, 535 insertions(+), 27 deletions(-) >> > Hi, > > We ran performance tests on the packed commands patch. We found out that > enabling the read packing didn't improve the performance in any of the > scenarios we ran (see the detailed results below). > Therefore, we suggest to move the read packing code to a different patch > and approve only the write packing code for now. The read packing adds > complexity to the code and we don't see a point in adding it while the > intention is to disable it. > > Test results: > > Long read operation: > ---------------------- > no-packing: 39.5 MB/s > packed commands patch (both READ and WRITE packing are enabled): 39.5 MB/s > packed commands patch + enabling only READ packing: 39.5 MB/s > > Several parallel read operations (sum of all the read throughputs): > --------------------------- > no-packing: 42.6 MB/s > packed commands patch(both READ and WRITE packing are enabled): 38 MB/s > packed commands patch + enabling only READ packing: 38.2 MB/s > > Parallel long read and long write operations (read throughput): > ----------------------------------------------------------------- > no-packing: 23.8 MB/s > packed commands patch (both READ and WRITE packing are enabled): 12.6 MB/s > packed commands patch + enabling only READ packing: 12.5 MB/s > > Parallel short read and long write operations (read throughput): > ----------------------------------------------------------------- > no-packing: 22.9 MB/s > packed commands patch (both READ and WRITE packing are enabled): 8.4 MB/s > packed commands patch + enabling only READ packing: 8.6 MB/s > > Several Parallel short read and short write operations (sum of all the > read throughputs): > -------------------------------------------------------------------------- > no-packing: 41.6 MB/s > packed commands patch (both READ and WRITE packing are enabled): 35 MB/s > packed commands patch + enabling only READ packing: 36 MB/s > > Thanks, > Maya Erez > Consultant for Qualcomm Innovation Center, Inc. > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum > > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html