From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA6FCC433F5 for ; Wed, 23 Mar 2022 13:51:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232910AbiCWNxZ (ORCPT ); Wed, 23 Mar 2022 09:53:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244514AbiCWNxS (ORCPT ); Wed, 23 Mar 2022 09:53:18 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9941D1BE97; Wed, 23 Mar 2022 06:51:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3FBF7B81EDC; Wed, 23 Mar 2022 13:51:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0841C340F4; Wed, 23 Mar 2022 13:51:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648043506; bh=y/8aIxPXC+g394fcpgBDvsF8AxrQH/gs1zJEIlzIc9g=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=MfjNFMEXIq1LrB14zwHXHCwqdSMMCMZ9E8jg8eprTKO/2iAnt4ATAFBc31PZKQfAb EM5/kRM3Pp1xXYRJzr+dKtZ6W6B3eUP69dIoy0m37nrQTUwa58mwi/dgPv1S6XLoK3 boD0fPX1I9O5VLeGMj34Zl8FSzHc6eqQ4N/8qJs6Jvjn50oKYzbIB3T2R7iH1WSKl5 7j6Bu4ETeTmbp/ncOcR5Sd82HLPndoHmCFyLIVezhEw940pGwHfviTahGKs3aAjtJd wUcuPfhEeg2rxng34BuDGfYDBLHlqq3e2SjnyIdoaUv5qAx4Cgmqb00HjyuJ1GG9uN kZODxA/Jni5DQ== Received: by mail-wm1-f42.google.com with SMTP id h16so1002893wmd.0; Wed, 23 Mar 2022 06:51:46 -0700 (PDT) X-Gm-Message-State: AOAM530qcM6BOi1iMal4uJSLIJjgLGmNWwg2a83hhQ1mARrautcNPLsM 7s+tSsjwH5uW0ln65m2UZjJWnKpQ78KsgXjnhf0= X-Google-Smtp-Source: ABdhPJzFk8Jniw3PIZb0IdWDB6+0zuAeveTEbvoR3GFK7Mu/1wULKttztobpAEmS/X/SmYLAL2n4C+xZcNEje8UmHWQ= X-Received: by 2002:a05:600c:214a:b0:38c:aa5d:1872 with SMTP id v10-20020a05600c214a00b0038caa5d1872mr9816712wml.9.1648043505123; Wed, 23 Mar 2022 06:51:45 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a05:6000:2c1:0:0:0:0 with HTTP; Wed, 23 Mar 2022 06:51:44 -0700 (PDT) In-Reply-To: <577b4601aa5d62d222fa9387c5036f2504f40318.1648017112.git.christophe.jaillet@wanadoo.fr> References: <577b4601aa5d62d222fa9387c5036f2504f40318.1648017112.git.christophe.jaillet@wanadoo.fr> From: Namjae Jeon Date: Wed, 23 Mar 2022 22:51:44 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] ksmbd: Remove a redundant zeroing of memory To: Christophe JAILLET Cc: Sergey Senozhatsky , Steve French , Hyunchul Lee , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-cifs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org 2022-03-23 15:32 GMT+09:00, Christophe JAILLET : > fill_transform_hdr() has only one caller that already clears tr_buf (it is > kzalloc'ed). > > So there is no need to clear it another time here. > > Remove the superfluous memset() and add a comment to remind that the caller > must clear the buffer. > > Signed-off-by: Christophe JAILLET Acked-by: Namjae Jeon Thanks!