All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namjae Jeon <linkinjeon@kernel.org>
To: Hyunchul Lee <hyc.lee@gmail.com>
Cc: linux-cifs@vger.kernel.org, smfrench@gmail.com, senozhatsky@chromium.org
Subject: Re: [PATCH] ksmbd: don't remove dos attribute xattr on O_TRUNC open
Date: Sun, 14 Aug 2022 11:50:27 +0900	[thread overview]
Message-ID: <CAKYAXd_tzk8YTpOrX-MvJWVwK2zJz4=sYf1M-+y+Z2R2t4YdCA@mail.gmail.com> (raw)
In-Reply-To: <CANFS6bYChCrTQHT6NKvpBX1PEuWPX1CYH_Z5TpGGgdMswV-dFw@mail.gmail.com>

2022-08-14 11:19 GMT+09:00, Hyunchul Lee <hyc.lee@gmail.com>:
> 2022년 8월 12일 (금) 오전 11:56, Namjae Jeon <linkinjeon@kernel.org>님이 작성:
>>
>> When smb client open file in ksmbd share with O_TRUNC, dos attribute
>> xattr is removed as well as data in file. This cause the FSCTL_SET_SPARSE
>> request from the client fails because ksmbd can't update the dos
>> attribute
>> after setting ATTR_SPARSE_FILE. And this patch fix xfstests generic/469
>> test also.
>>
>> Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
>> ---
>>  fs/ksmbd/smb2pdu.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/fs/ksmbd/smb2pdu.c b/fs/ksmbd/smb2pdu.c
>> index b5c36657ecfd..0c2e57397dd2 100644
>> --- a/fs/ksmbd/smb2pdu.c
>> +++ b/fs/ksmbd/smb2pdu.c
>> @@ -2330,9 +2330,7 @@ static int smb2_remove_smb_xattrs(struct path
>> *path)
>>                         name += strlen(name) + 1) {
>>                 ksmbd_debug(SMB, "%s, len %zd\n", name, strlen(name));
>>
>> -               if (strncmp(name, XATTR_USER_PREFIX,
>> XATTR_USER_PREFIX_LEN) &&
>> -                   strncmp(&name[XATTR_USER_PREFIX_LEN],
>> DOS_ATTRIBUTE_PREFIX,
>> -                           DOS_ATTRIBUTE_PREFIX_LEN) &&
>> +               if (!strncmp(name, XATTR_USER_PREFIX,
>> XATTR_USER_PREFIX_LEN) &&
>>                     strncmp(&name[XATTR_USER_PREFIX_LEN], STREAM_PREFIX,
>> STREAM_PREFIX_LEN))
>>                         continue;
>>
>
> We don't need to exclude security.*, trusted.*, system.* from deletion?
Right, will fix it on v2.
Thanks.
>
>> --
>> 2.25.1
>>
>
>
> --
> Thanks,
> Hyunchul
>

      reply	other threads:[~2022-08-14  2:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-12  2:56 [PATCH] ksmbd: don't remove dos attribute xattr on O_TRUNC open Namjae Jeon
2022-08-14  2:19 ` Hyunchul Lee
2022-08-14  2:50   ` Namjae Jeon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKYAXd_tzk8YTpOrX-MvJWVwK2zJz4=sYf1M-+y+Z2R2t4YdCA@mail.gmail.com' \
    --to=linkinjeon@kernel.org \
    --cc=hyc.lee@gmail.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=senozhatsky@chromium.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.