From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ilkka Sovanto Subject: Re: [PATCH] libiscsi: add lock around task lists to fix list corruption regression Date: Fri, 24 Feb 2017 21:48:47 +0200 Message-ID: References: <20170221173536.32024-1-cleech@redhat.com> <250619225.63072551.1487888748696.JavaMail.zimbra@redhat.com> <4304a9c0-6427-c0a2-e18a-51292d62022b@linux.vnet.ibm.com> Reply-To: open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c03d91aa8523a05494c0480 Return-path: Sender: open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <4304a9c0-6427-c0a2-e18a-51292d62022b-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: "Guilherme G. Piccoli" Cc: Chris Leech , linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, lduncan-IBi9RG/b67k@public.gmane.org, martin petersen , jejb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, Brian King List-Id: linux-scsi@vger.kernel.org --94eb2c03d91aa8523a05494c0480 Content-Type: text/plain; charset=UTF-8 On Fri, Feb 24, 2017 at 5:09 PM, Guilherme G. Piccoli < gpiccoli-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> wrote: > On 02/23/2017 07:25 PM, Chris Leech wrote: > > Yikes, my git-send-email settings suppressed the important CCs. Sorry! > > > > Guilherme and Ilkka, can you comment about your testing results or > review please? > > Hi Chris, thanks for looping me. Patch seems nice, I do have some points > below, most nitpicks heheh > Feel free to accept or not the suggestions! > > Hi! Also testing currently in testing, will try it out in production next if it looks good. (so far it does). In testing it did hit the warning pretty quickly. - Ilkka -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org Visit this group at https://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout. --94eb2c03d91aa8523a05494c0480 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Fri, Feb 24, 2017 at 5:09 PM, Guilherme G. Piccoli <gpicc= oli-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> wrote:
On 02/23/2017 07:25 PM, Chris Leech wrote:
> Yikes, my git-send-email settings suppressed the important CCs.=C2=A0 = Sorry!
>
> Guilherme and Ilkka, can you comment about your testing results or rev= iew please?

Hi Chris, thanks for looping me. Patch seems nice, I do have some po= ints
below, most nitpicks heheh
Feel free to accept or not the suggestions!

Hi!

= Also testing currently in testing, will try it out in production next if it= looks good. (so far it does). In testing it did hit the warning pretty qui= ckly.

=C2=A0- Ilkka=C2=A0

--
You received this message because you are subscribed to the Google Groups &= quot;open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an e= mail to open-isc= si+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
Visit this group at = https://groups.google.com/group/open-iscsi.
For more options, visit http= s://groups.google.com/d/optout.
--94eb2c03d91aa8523a05494c0480--