From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC123C47080 for ; Wed, 2 Jun 2021 02:45:17 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C2A6613CC for ; Wed, 2 Jun 2021 02:45:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C2A6613CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 66CD482B51; Wed, 2 Jun 2021 04:45:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="BR1b0CRl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CFBE282E8D; Wed, 2 Jun 2021 04:45:10 +0200 (CEST) Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 42E1E81D48 for ; Wed, 2 Jun 2021 04:45:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=email2tema@gmail.com Received: by mail-io1-xd34.google.com with SMTP id a8so899065ioa.12 for ; Tue, 01 Jun 2021 19:45:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=i6yCINWuUeKBZNCrifY5v5AWvliyrhK01nM4MeDAcgA=; b=BR1b0CRljW8rrjfoDXkz4AUlpDbWkPF+VWGxzTH1oGT48JYlKU0FVCKpwA0plgabAk /kL58x6QHwrXQKtrSfGjZhqsSvpJggalmIn+1Fi3/Ff2wOn49tSUX3UoU/DXzgxmzA9+ pUi9Qi+yoUECb2zds4q6b7s0Q4LHMjPqeMCwvVeXm+SV//8jL+pl7/v0XCc+wHjjQe6r kCjXn0IFliJfD6C2TxpueaKTpIIOaOzs9uai4gCQz4eusxzIhH5YNEy9pNZR4FKyQsn1 oXz2NZiY6H2AV2WE8Sil6GEvpIPPW9sZ/1yw6iTznUZHt8G4MxCjODSQ34d0ziXdpEV/ YOWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=i6yCINWuUeKBZNCrifY5v5AWvliyrhK01nM4MeDAcgA=; b=ZKRNQqaeEztsiK5UWVFv2zGIrbj5OzVjLIB54XdZjTCe2AD6AHAOjpyXe//s1FYo5X 5LOW+WCl9e18a1H3QJT4PySgbhWRZUgWZuFAEgO+VhDjB3JatoGNF3i2uwxyMgcB8eNC SJsAimEZEvzPxPk5kHh11BImqJPI1jK4zsr606wKfMBa0BcIjrio+VnejskTC+aFfdIZ m6CJZI9P+zLRD/7Njrd0ehkcokvwCKALKpzQ1KzMnemBHwniEj41lLBn5G47z0Sm0y87 LwO4e8EmOJIjKj3KlVtKmaNPAHg7R+UQNIHeIJyb7R8qsDYR/WysygOwRpuCA556lRIT EQ7w== X-Gm-Message-State: AOAM5330VrDPvVzr5xwP8HRxbG7fDlktuVOpUJ3i21wN5kUDMKCvh6Dc eFl5cU3XWl3BbVBa/k6ErNA4N9kYCSmgRJk/bDl7CCobb8rH9w== X-Google-Smtp-Source: ABdhPJzBJqgOo2CM78S2cdVBrXbxmA6W78b4BXOq1lckys5CL8Kglejl793GZzCXaB5cfPa7PVgy2FAzJTR1/MLaYas= X-Received: by 2002:a6b:b214:: with SMTP id b20mr7443266iof.199.1622601906184; Tue, 01 Jun 2021 19:45:06 -0700 (PDT) MIME-Version: 1.0 References: <20210526093319.274254-1-art@khadas.com> <9401f82b-efe7-7acf-da10-4934db5d3b8b@rock-chips.com> In-Reply-To: From: Art Nikpal Date: Wed, 2 Jun 2021 10:44:54 +0800 Message-ID: Subject: Re: [PATCH] evb_rk3399: add usb ohci definations To: Kever Yang Cc: sjg@chromium.org, Jagan Teki , sunil@amarulasolutions.com, u-boot@lists.denx.de, Artem Lapkin , nick@khadas.com, Gouwa Wang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean workable example for CONFIG_USB_OHCI_HCD and CONFIG_USB_OHCI_GENERIC (usb kbd on usb2.0 port) kedge# usb tree USB device tree: 1 Hub (480 Mb/s, 0mA) u-boot EHCI Host Controller 1 Hub (12 Mb/s, 0mA) | U-Boot Root Hub | +-2 Human Interface (1.5 Mb/s, 100mA) Dell KB216 Wired Keyboard 1 Hub (480 Mb/s, 0mA) u-boot EHCI Host Controller 1 Hub (12 Mb/s, 0mA) U-Boot Root Hub 1 Hub (5 Gb/s, 0mA) U-Boot XHCI Host Controller and for usbkbd connected to usb3 port kedge# usb tree USB device tree: 1 Hub (480 Mb/s, 0mA) u-boot EHCI Host Controller 1 Hub (12 Mb/s, 0mA) U-Boot Root Hub 1 Hub (480 Mb/s, 0mA) u-boot EHCI Host Controller 1 Hub (12 Mb/s, 0mA) U-Boot Root Hub 1 Hub (5 Gb/s, 0mA) | U-Boot XHCI Host Controller | +-2 Human Interface (1.5 Mb/s, 100mA) Dell KB216 Wired Keyboard PS: usb2.0 port cant recognize any usb1.1 devices without OHCI On Wed, Jun 2, 2021 at 10:33 AM Art Nikpal wrote: > > > But , evb_rk3399 board does not enable CONFIG_USB_OHCI_HCD and CONFIG_U= SB_OHCI_GENERIC. > > yes i know it ! > > for example some other rk3399 boards have it because (usb 1.1 didnt > work without ohci on usb2.0 port and not possible to use usb kbd for > this port ) > > grep CONFIG_USB_OHCI_GENERIC configs/*3399* > configs/pinebook-pro-rk3399_defconfig:CONFIG_USB_OHCI_GENERIC=3Dy > configs/rock960-rk3399_defconfig:CONFIG_USB_OHCI_GENERIC=3Dy > configs/rockpro64-rk3399_defconfig:CONFIG_USB_OHCI_GENERIC=3Dy > > many other boards which used TARGET_EVB_RK3399=3Dy must have same > problem (with usb1.1) > > and i think other boards must have possibilities to use > CONFIG_USB_OHCI_HCD and CONFIG_USB_OHCI_GENERIC. > > grep EVB configs/*3399* > > configs/evb-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=3Dy > configs/firefly-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=3Dy > configs/khadas-edge-captain-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=3Dy > configs/khadas-edge-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=3Dy > configs/khadas-edge-v-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=3Dy > configs/leez-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=3Dy > configs/nanopc-t4-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=3Dy > configs/nanopi-m4-2gb-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=3Dy > configs/nanopi-m4b-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=3Dy > configs/nanopi-m4-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=3Dy > configs/nanopi-neo4-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=3Dy > configs/nanopi-r4s-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=3Dy > configs/orangepi-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=3Dy > configs/rock-pi-4c-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=3Dy > configs/rock-pi-4-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=3Dy > configs/rock-pi-n10-rk3399pro_defconfig:CONFIG_TARGET_EVB_RK3399=3Dy > > On Tue, Jun 1, 2021 at 8:15 PM Kever Yang wro= te: > > > > Hi Artem, > > > > On 2021/5/26 =E4=B8=8B=E5=8D=885:33, Artem Lapkin wrote: > > > Problem: not possible to use CONFIG_USB_OHCI_HCD=3Dy and > > > CONFIG_USB_OHCI_GENERIC=3Dy options without CONFIG_USB_OHCI_NEW and > > > CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS definations > > > > > > Add missed definations. > > > > But , evb_rk3399 board does not enable CONFIG_USB_OHCI_HCD and > > CONFIG_USB_OHCI_GENERIC. > > > > > > Thanks, > > > > - Kever > > > > > > > > Signed-off-by: Artem Lapkin > > > --- > > > include/configs/evb_rk3399.h | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/include/configs/evb_rk3399.h b/include/configs/evb_rk339= 9.h > > > index b7e85037..492b7b4d 100644 > > > --- a/include/configs/evb_rk3399.h > > > +++ b/include/configs/evb_rk3399.h > > > @@ -15,4 +15,7 @@ > > > > > > #define SDRAM_BANK_SIZE (2UL << 30) > > > > > > +#define CONFIG_USB_OHCI_NEW > > > +#define CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS 2 > > > + > > > #endif > > > >