From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AE1EC433EF for ; Fri, 15 Oct 2021 10:27:43 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 10FC960FDA for ; Fri, 15 Oct 2021 10:27:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 10FC960FDA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DE78F834E0; Fri, 15 Oct 2021 12:27:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="lZV6rZN0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 85A958352E; Fri, 15 Oct 2021 12:27:37 +0200 (CEST) Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EBFBB834D6 for ; Fri, 15 Oct 2021 12:27:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=email2tema@gmail.com Received: by mail-io1-xd33.google.com with SMTP id r134so7104936iod.11 for ; Fri, 15 Oct 2021 03:27:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=itHQERUUh7sq8vliE2wb9NCTeJ5eC1gD22yjwenTsec=; b=lZV6rZN0RnjVGxiTtU1kkiCCNTp0WuDC/jnaifPSINxtAjMndPVgpgq6/r1exy4A1H fW88FSHWJ+FixcoR1eUcgMHOemlkdP4VSpphJ9e4bP3tMv8VU47anZNyhk8YCp9t5zi6 U9w5DQwQmKtxT9UP/2H7i2Urpez88YEQLNnzXhH4zN5WqXvwOJib5t8sGhQXJyJghp2c bkl+Ea1Md7olFliez80VSNiYWkYUzmTJJaROqJOsNnchK8FWVskMh50+HRyjmfEXDglI PgcdL4GuLtQ03ZrvqV+hSW7mF/BhfWml8YBSsFuc2oFBsV46OrfS9/xmdxAhJ0SsDN2A pt/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=itHQERUUh7sq8vliE2wb9NCTeJ5eC1gD22yjwenTsec=; b=j+euDO9XyXoAKI9bMLwomDd6T8vMk5aFuDIST3AUC9n0OaGJgvxNEty3qQI+Tv9QBS AhW+KnjaPRjQ7WSEl6xG0Cu7M1l8l0QrM0g7C4GggSz4PHRc8Jr1maZLt4EDUDqgDsBC U8rARWMKM2ZKS6CYY8xHoVs2a3XV1ahWW64Rg454GUzHgFHg+0aE9jbQBRDuR2Ban7Cn Mfyjlq6IOxZU4eDFyhD/8+VTJ+2JcOsZJERIECsEX8E8AjvwNVLrFmkfw7o6r4HRMOOx uRF/zi1tNa7tr+jxnlUp3XFqndb44Sdz/OAkqBbQ1NhO2mRu/QO6333Sg0sieAFvBC6b 0YHg== X-Gm-Message-State: AOAM5315EI0Wevc3GEE77RwOBEWrcZBb8FUZrSUKwZnzy0M/BFEHHLma 5FbGfoUvjSJmAIibPCtQz8eYSiCfzNdtxs9sPC4= X-Google-Smtp-Source: ABdhPJwzDBhmOlkWNt1WjlK70gmR5JkOPdrN/7nZsrqDmsQeaAYXcMyyN7vVH1jKn3b2iLaGxjg4/o1n0VgfGsCNVpA= X-Received: by 2002:a5e:9b1a:: with SMTP id j26mr3037128iok.216.1634293651691; Fri, 15 Oct 2021 03:27:31 -0700 (PDT) MIME-Version: 1.0 References: <20211014184811.482560-1-sjg@chromium.org> In-Reply-To: <20211014184811.482560-1-sjg@chromium.org> From: Art Nikpal Date: Fri, 15 Oct 2021 18:27:20 +0800 Message-ID: Subject: Re: [PATCH v3 00/18] pxe: Refactoring to tidy up and prepare for bootflow To: Simon Glass Cc: U-Boot Mailing List , Patrice Chotard , Tom Rini , Joe Hershberger , Heinrich Schuchardt , Peter Hoyes Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean hi Simon I am still testing this patchset for master branch! need more time (but looks like works) BTW: i have get some problems from prev your commits for example unbootable raw initrd images https://patchwork.ozlabs.org/project/uboot/patch/20211015101501.4091141-1-art@khadas.com/ i have send this patch maybe your can identificate problem more properly (to much changes from v2021.07 - v2021.10 boot process for v2021.07 works well ) Tnx for your work On Fri, Oct 15, 2021 at 2:48 AM Simon Glass wrote: > > This collects together the patches previously sent relating to PXE. > > Firstly, it moves the boot code out of common/ and into a new boot/ > directory. This helps to collect these related files in one place, as > common/ is quite large. > > Secondly, it provides patache so clean up the PXE code and refactor it > into something closer to a module that can be called, teasing apart its > reliance on the command-line interpreter to access filesystems and the > like. Also it now uses function arguments and its own context struct > internally rather than environment variables, which is very hard to > follow. No core functional change is intended. > > Changes in v3: > - Rebase to -master > > Changes in v2: > - Rebase to -next > - Split out from the bootmethod patches > > Simon Glass (18): > Create a new boot/ directory > pxe: Move API comments to the header files > pxe: Use a context pointer > pxe: Move do_getfile() into the context > pxe: Add a userdata field to the context > pxe: Tidy up the is_pxe global > pxe: Move pxe_utils files > pxe: Tidy up some comments in pxe_utils > pxe: Tidy up code style a little in pxe_utils > pxe: Move common parsing coding into pxe_util > pxe: Clean up the use of bootfile > pxe: Drop get_bootfile_path() > lib: Add tests for simple_itoa() > lib: Add a function to convert a string to a hex value > pxe: Return the file size from the getfile() function > pxe: Refactor sysboot to have one helper > doc: Move distro boot doc to rST > pxe: Allow calling the pxe_get logic directly > > Kconfig | 2 + > Makefile | 3 +- > README | 1 + > common/Kconfig.boot => boot/Kconfig | 0 > boot/Makefile | 37 ++ > {common => boot}/android_ab.c | 0 > {common => boot}/boot_fit.c | 0 > {common => boot}/bootm.c | 0 > {common => boot}/bootm_os.c | 0 > {common => boot}/bootretry.c | 0 > {common => boot}/common_fit.c | 0 > {common => boot}/fdt_region.c | 0 > {common => boot}/image-android-dt.c | 0 > {common => boot}/image-android.c | 0 > {common => boot}/image-board.c | 0 > {common => boot}/image-cipher.c | 0 > {common => boot}/image-fdt.c | 0 > {common => boot}/image-fit-sig.c | 0 > {common => boot}/image-fit.c | 0 > {common => boot}/image-host.c | 0 > {common => boot}/image-sig.c | 0 > {common => boot}/image.c | 0 > {cmd => boot}/pxe_utils.c | 512 +++++++++++----------- > cmd/Makefile | 4 +- > cmd/pxe.c | 136 +++--- > cmd/pxe_utils.h | 91 ---- > cmd/sysboot.c | 114 +++-- > common/Kconfig | 2 - > common/Makefile | 22 - > doc/android/boot-image.rst | 2 +- > doc/{README.distro => develop/distro.rst} | 177 ++++---- > doc/develop/index.rst | 1 + > include/pxe_utils.h | 253 +++++++++++ > include/vsprintf.h | 25 +- > lib/vsprintf.c | 20 +- > scripts/Makefile.spl | 4 +- > test/print_ut.c | 41 ++ > tools/Makefile | 18 +- > 38 files changed, 874 insertions(+), 591 deletions(-) > rename common/Kconfig.boot => boot/Kconfig (100%) > create mode 100644 boot/Makefile > rename {common => boot}/android_ab.c (100%) > rename {common => boot}/boot_fit.c (100%) > rename {common => boot}/bootm.c (100%) > rename {common => boot}/bootm_os.c (100%) > rename {common => boot}/bootretry.c (100%) > rename {common => boot}/common_fit.c (100%) > rename {common => boot}/fdt_region.c (100%) > rename {common => boot}/image-android-dt.c (100%) > rename {common => boot}/image-android.c (100%) > rename {common => boot}/image-board.c (100%) > rename {common => boot}/image-cipher.c (100%) > rename {common => boot}/image-fdt.c (100%) > rename {common => boot}/image-fit-sig.c (100%) > rename {common => boot}/image-fit.c (100%) > rename {common => boot}/image-host.c (100%) > rename {common => boot}/image-sig.c (100%) > rename {common => boot}/image.c (100%) > rename {cmd => boot}/pxe_utils.c (74%) > delete mode 100644 cmd/pxe_utils.h > rename doc/{README.distro => develop/distro.rst} (76%) > create mode 100644 include/pxe_utils.h > > -- > 2.33.0.1079.g6e70778dc9-goog >