From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: MIME-Version: 1.0 Sender: ibmirkin@gmail.com In-Reply-To: References: <20160715131218.2416-1-peter@lekensteyn.nl> From: Ilia Mirkin Date: Fri, 15 Jul 2016 12:42:38 -0400 Message-ID: Subject: Re: [Nouveau] [PATCH v3 0/4] nouveau RPM fixes for Optimus (final) To: Alex Deucher Cc: Peter Wu , Linux PCI , "dri-devel@lists.freedesktop.org" , Bjorn Helgaas , "nouveau@lists.freedesktop.org" , Dave Airlie , Mika Westerberg Content-Type: text/plain; charset=UTF-8 List-ID: On Fri, Jul 15, 2016 at 12:40 PM, Alex Deucher wrote: > On Fri, Jul 15, 2016 at 12:31 PM, Ilia Mirkin wrote: >> On Fri, Jul 15, 2016 at 12:27 PM, Alex Deucher wrote: >>> On Fri, Jul 15, 2016 at 12:10 PM, Ilia Mirkin wrote: >>>> On Fri, Jul 15, 2016 at 9:12 AM, Peter Wu wrote: >>>>> Hi, >>>>> >>>>> Here are two patches to fix an issue reported on kernel bugzilla (infinite loop >>>>> due to unchecked function) and a more important fix to fix hanging Optimus >>>>> machines when runtime PM is enabled (with pm/pci patches). >>>>> >>>>> These are the final patches targeting v4.8. Changes compared to v2[1]: >>>>> collected R-b from Hans and Mika and fixed a minor comment style issue. >>>>> >>>>> I recommend it to be merged before the pci/pm patches[2], otherwise there is a >>>>> window where newer Nvidia Optimus laptops might fail to runtime resume and/or >>>>> lock up. Once the pci/pm branch is merged I will propose another patch to >>>>> improve reliability[3]. >>>>> >>>>> Known issue with patch 4: when a Nvidia HDMI audio function is present, the >>>>> bridge will not suspend and hence the Nvidia card will still be powered. Fixing >>>> >>>> That's basically all optimus gpu's, right? Anything GT21x+ has a HDMI >>>> audio subfunction, and prior to that, the nvidia gpu tended to be the >>>> only gpu, or hard-muxed. >>> >>> I'd imagine there is a strap on the asic so the audio function is only >>> enabled if there is a connector actually wired to the dGPU. It >>> doesn't make much sense to expose audio if there is no way to use it. >> >> A lot of the time, there actually is a connector wired up. A lot of >> the other time, there is no connector, but the display unit is still >> there. Very recently, NVIDIA gpu's have started coming out marked as >> "3d accelerator", which sometimes but not always means that there's no >> display unit, and for those, I would assume there is no audio >> subfunction. >> > > Just because there is a display block, doesn't mean the audio function > is always enabled. I suspect it is disabled by hardware straps on > systems with no display connectors or other specific OEM configs. That's what I'm saying - it is not. There are straps, and they can be used to disable the display block. But they're often not set that way. -ilia From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ilia Mirkin Subject: Re: [PATCH v3 0/4] nouveau RPM fixes for Optimus (final) Date: Fri, 15 Jul 2016 12:42:38 -0400 Message-ID: References: <20160715131218.2416-1-peter@lekensteyn.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Alex Deucher Cc: Linux PCI , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , Bjorn Helgaas , "nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , Dave Airlie , Mika Westerberg List-Id: nouveau.vger.kernel.org T24gRnJpLCBKdWwgMTUsIDIwMTYgYXQgMTI6NDAgUE0sIEFsZXggRGV1Y2hlciA8YWxleGRldWNo ZXJAZ21haWwuY29tPiB3cm90ZToKPiBPbiBGcmksIEp1bCAxNSwgMjAxNiBhdCAxMjozMSBQTSwg SWxpYSBNaXJraW4gPGltaXJraW5AYWx1bS5taXQuZWR1PiB3cm90ZToKPj4gT24gRnJpLCBKdWwg MTUsIDIwMTYgYXQgMTI6MjcgUE0sIEFsZXggRGV1Y2hlciA8YWxleGRldWNoZXJAZ21haWwuY29t PiB3cm90ZToKPj4+IE9uIEZyaSwgSnVsIDE1LCAyMDE2IGF0IDEyOjEwIFBNLCBJbGlhIE1pcmtp biA8aW1pcmtpbkBhbHVtLm1pdC5lZHU+IHdyb3RlOgo+Pj4+IE9uIEZyaSwgSnVsIDE1LCAyMDE2 IGF0IDk6MTIgQU0sIFBldGVyIFd1IDxwZXRlckBsZWtlbnN0ZXluLm5sPiB3cm90ZToKPj4+Pj4g SGksCj4+Pj4+Cj4+Pj4+IEhlcmUgYXJlIHR3byBwYXRjaGVzIHRvIGZpeCBhbiBpc3N1ZSByZXBv cnRlZCBvbiBrZXJuZWwgYnVnemlsbGEgKGluZmluaXRlIGxvb3AKPj4+Pj4gZHVlIHRvIHVuY2hl Y2tlZCBmdW5jdGlvbikgYW5kIGEgbW9yZSBpbXBvcnRhbnQgZml4IHRvIGZpeCBoYW5naW5nIE9w dGltdXMKPj4+Pj4gbWFjaGluZXMgd2hlbiBydW50aW1lIFBNIGlzIGVuYWJsZWQgKHdpdGggcG0v cGNpIHBhdGNoZXMpLgo+Pj4+Pgo+Pj4+PiBUaGVzZSBhcmUgdGhlIGZpbmFsIHBhdGNoZXMgdGFy Z2V0aW5nIHY0LjguIENoYW5nZXMgY29tcGFyZWQgdG8gdjJbMV06Cj4+Pj4+IGNvbGxlY3RlZCBS LWIgZnJvbSBIYW5zIGFuZCBNaWthIGFuZCBmaXhlZCBhIG1pbm9yIGNvbW1lbnQgc3R5bGUgaXNz dWUuCj4+Pj4+Cj4+Pj4+IEkgcmVjb21tZW5kIGl0IHRvIGJlIG1lcmdlZCBiZWZvcmUgdGhlIHBj aS9wbSBwYXRjaGVzWzJdLCBvdGhlcndpc2UgdGhlcmUgaXMgYQo+Pj4+PiB3aW5kb3cgd2hlcmUg bmV3ZXIgTnZpZGlhIE9wdGltdXMgbGFwdG9wcyBtaWdodCBmYWlsIHRvIHJ1bnRpbWUgcmVzdW1l IGFuZC9vcgo+Pj4+PiBsb2NrIHVwLiAgT25jZSB0aGUgcGNpL3BtIGJyYW5jaCBpcyBtZXJnZWQg SSB3aWxsIHByb3Bvc2UgYW5vdGhlciBwYXRjaCB0bwo+Pj4+PiBpbXByb3ZlIHJlbGlhYmlsaXR5 WzNdLgo+Pj4+Pgo+Pj4+PiBLbm93biBpc3N1ZSB3aXRoIHBhdGNoIDQ6IHdoZW4gYSBOdmlkaWEg SERNSSBhdWRpbyBmdW5jdGlvbiBpcyBwcmVzZW50LCB0aGUKPj4+Pj4gYnJpZGdlIHdpbGwgbm90 IHN1c3BlbmQgYW5kIGhlbmNlIHRoZSBOdmlkaWEgY2FyZCB3aWxsIHN0aWxsIGJlIHBvd2VyZWQu IEZpeGluZwo+Pj4+Cj4+Pj4gVGhhdCdzIGJhc2ljYWxseSBhbGwgb3B0aW11cyBncHUncywgcmln aHQ/IEFueXRoaW5nIEdUMjF4KyBoYXMgYSBIRE1JCj4+Pj4gYXVkaW8gc3ViZnVuY3Rpb24sIGFu ZCBwcmlvciB0byB0aGF0LCB0aGUgbnZpZGlhIGdwdSB0ZW5kZWQgdG8gYmUgdGhlCj4+Pj4gb25s eSBncHUsIG9yIGhhcmQtbXV4ZWQuCj4+Pgo+Pj4gSSdkIGltYWdpbmUgdGhlcmUgaXMgYSBzdHJh cCBvbiB0aGUgYXNpYyBzbyB0aGUgYXVkaW8gZnVuY3Rpb24gaXMgb25seQo+Pj4gZW5hYmxlZCBp ZiB0aGVyZSBpcyBhIGNvbm5lY3RvciBhY3R1YWxseSB3aXJlZCB0byB0aGUgZEdQVS4gIEl0Cj4+ PiBkb2Vzbid0IG1ha2UgbXVjaCBzZW5zZSB0byBleHBvc2UgYXVkaW8gaWYgdGhlcmUgaXMgbm8g d2F5IHRvIHVzZSBpdC4KPj4KPj4gQSBsb3Qgb2YgdGhlIHRpbWUsIHRoZXJlIGFjdHVhbGx5IGlz IGEgY29ubmVjdG9yIHdpcmVkIHVwLiBBIGxvdCBvZgo+PiB0aGUgb3RoZXIgdGltZSwgdGhlcmUg aXMgbm8gY29ubmVjdG9yLCBidXQgdGhlIGRpc3BsYXkgdW5pdCBpcyBzdGlsbAo+PiB0aGVyZS4g VmVyeSByZWNlbnRseSwgTlZJRElBIGdwdSdzIGhhdmUgc3RhcnRlZCBjb21pbmcgb3V0IG1hcmtl ZCBhcwo+PiAiM2QgYWNjZWxlcmF0b3IiLCB3aGljaCBzb21ldGltZXMgYnV0IG5vdCBhbHdheXMg bWVhbnMgdGhhdCB0aGVyZSdzIG5vCj4+IGRpc3BsYXkgdW5pdCwgYW5kIGZvciB0aG9zZSwgSSB3 b3VsZCBhc3N1bWUgdGhlcmUgaXMgbm8gYXVkaW8KPj4gc3ViZnVuY3Rpb24uCj4+Cj4KPiBKdXN0 IGJlY2F1c2UgdGhlcmUgaXMgYSBkaXNwbGF5IGJsb2NrLCBkb2Vzbid0IG1lYW4gdGhlIGF1ZGlv IGZ1bmN0aW9uCj4gaXMgYWx3YXlzIGVuYWJsZWQuICBJIHN1c3BlY3QgaXQgaXMgZGlzYWJsZWQg YnkgaGFyZHdhcmUgc3RyYXBzIG9uCj4gc3lzdGVtcyB3aXRoIG5vIGRpc3BsYXkgY29ubmVjdG9y cyBvciBvdGhlciBzcGVjaWZpYyBPRU0gY29uZmlncy4KClRoYXQncyB3aGF0IEknbSBzYXlpbmcg LSBpdCBpcyBub3QuIFRoZXJlIGFyZSBzdHJhcHMsIGFuZCB0aGV5IGNhbiBiZQp1c2VkIHRvIGRp c2FibGUgdGhlIGRpc3BsYXkgYmxvY2suIEJ1dCB0aGV5J3JlIG9mdGVuIG5vdCBzZXQgdGhhdCB3 YXkuCgogIC1pbGlhCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCk5vdXZlYXUgbWFpbGluZyBsaXN0Ck5vdXZlYXVAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vbm91dmVhdQo=