From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_RED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD571C4332E for ; Mon, 28 Dec 2020 14:11:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A44D7208B3 for ; Mon, 28 Dec 2020 14:11:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439172AbgL1OK5 (ORCPT ); Mon, 28 Dec 2020 09:10:57 -0500 Received: from mail-vs1-f53.google.com ([209.85.217.53]:40502 "EHLO mail-vs1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2439140AbgL1OKw (ORCPT ); Mon, 28 Dec 2020 09:10:52 -0500 Received: by mail-vs1-f53.google.com with SMTP id x4so5565613vsp.7; Mon, 28 Dec 2020 06:10:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kVDVcWWL6BrKWAViQNJ51zoi/mT+OBUb6BuJEL+vMoo=; b=pE4CTaRrZYjFplGHrWnQdEsl68KB7lK0M4s8XWTiGRuYAT6sW+RzYZQdLZJAcO4zu+ pqn/oaceomlj59wTB7ZB4PPOgVVknq3jp4LBSfUbTaZO3rXHcxVw7Ab2pc1MpkjsgBmZ bxGlyauAfTRm2gk6n7p/2ohOJmweAjZm3aDRUv5IA4zbS4gnYiWKcwcrS7UeASihKPsn 8PUVKsu+HTd9Ac58qS0Q0y5X+EeEVqR3ZWMkXzkaJxCeE5RFqHyVttQAYU+bKS2uIjnW h8Uk44fSw4EfkC/aJifP3aVn3vLevRw5ghdGJOEjwK4fznZrhm+/uBXb0idDBeM80Lb0 6KYA== X-Gm-Message-State: AOAM5330QSiltI+gY6MW3N+embluiTwUXfYi8Tr1C8bMfEEGts/VodDT sdEVeQV4ztt3hGPNkfP8oz2ZR2Xj+wwTGRt8kiOWlCjItTg= X-Google-Smtp-Source: ABdhPJyMFLLyG19RShLswn1DSR8JZ58ywdALLa9LeyQVLy11CNG6bQXE6EcX/vDssohktYYfTRnABoFmZNKkk1D0UR4= X-Received: by 2002:a67:f601:: with SMTP id k1mr28677791vso.46.1609164610688; Mon, 28 Dec 2020 06:10:10 -0800 (PST) MIME-Version: 1.0 References: <20201228125020.963311703@linuxfoundation.org> <20201228125024.061845231@linuxfoundation.org> In-Reply-To: <20201228125024.061845231@linuxfoundation.org> From: Ilia Mirkin Date: Mon, 28 Dec 2020 09:09:59 -0500 Message-ID: Subject: Re: [PATCH 5.10 064/717] drm/edid: Fix uninitialized variable in drm_cvt_modes() To: Greg Kroah-Hartman Cc: LKML , "# 3.9+" , Lyude Paul , Sasha Levin Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, Linus had to apply a fixup for this patch. Please ensure that it's in your patch list: commit d652d5f1eeeb06046009f4fcb9b4542249526916 Author: Linus Torvalds Date: Thu Dec 17 09:27:57 2020 -0800 drm/edid: fix objtool warning in drm_cvt_modes() It does not appear to have a Fixes tag, so may not have been picked up by your automated tooling. Cheers, -ilia On Mon, Dec 28, 2020 at 9:01 AM Greg Kroah-Hartman wrote: > > From: Lyude Paul > > [ Upstream commit 991fcb77f490390bcad89fa67d95763c58cdc04c ] > > Noticed this when trying to compile with -Wall on a kernel fork. We > potentially don't set width here, which causes the compiler to complain > about width potentially being uninitialized in drm_cvt_modes(). So, let's > fix that. > > Changes since v1: > * Don't emit an error as this code isn't reachable, just mark it as such > Changes since v2: > * Remove now unused variable > > Fixes: 3f649ab728cd ("treewide: Remove uninitialized_var() usage") > Signed-off-by: Lyude Paul > Reviewed-by: Ilia Mirkin > Link: https://patchwork.freedesktop.org/patch/msgid/20201105235703.1328115-1-lyude@redhat.com > Signed-off-by: Sasha Levin > --- > drivers/gpu/drm/drm_edid.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 631125b46e04c..b84efd538a702 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -3114,6 +3114,8 @@ static int drm_cvt_modes(struct drm_connector *connector, > case 0x0c: > width = height * 15 / 9; > break; > + default: > + unreachable(); > } > > for (j = 1; j < 5; j++) { > -- > 2.27.0 > > >