From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6381EC433DB for ; Wed, 30 Dec 2020 15:55:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5EA320795 for ; Wed, 30 Dec 2020 15:55:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5EA320795 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alum.mit.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 454D289807; Wed, 30 Dec 2020 15:55:53 +0000 (UTC) Received: from mail-vs1-f45.google.com (mail-vs1-f45.google.com [209.85.217.45]) by gabe.freedesktop.org (Postfix) with ESMTPS id 70F2089807 for ; Wed, 30 Dec 2020 15:55:52 +0000 (UTC) Received: by mail-vs1-f45.google.com with SMTP id e20so8728230vsr.12 for ; Wed, 30 Dec 2020 07:55:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7slKsDIdzR3Cjv1U1zSaDNq2UnX9ACN/O5uP+fwyS8g=; b=fDy9TS/NzqeyDF6mJH+EOgn02vlIYtXQYBYzdAkQAYR4NMPG6BdUH13BgK1J/IrcJs GeilsCzgGs03Znnv5oUcIrqORvrcsSGhbF9emVedWxynbZEshQUcqzzPx7Qo+4okfI0P Zi6QiBxP0LInI5FQninsiWxtmVTfOJYbaYGkqBGIA3Ww2iXT1ZdU0AuMEfDhsLcpWt6C GtVXp/mdBHQprBnXRl0+C8l4/2w86O/wvYqE8+m3nrHQ7/yd7NMFAxUXSTqGj0QGyNgO Ll2ch3JnjIm5IZo4RcNQcwfLJLElFOJ1aN/SYXZiPJh4IE0YkpeRpVw4RQrluLC+mdH2 VCNA== X-Gm-Message-State: AOAM531S1DEdMar77Y003RJwOHb4UVC4slyvK1n7hbf1qtn0G5JFH593 FerHLzGPYWltWpAqP+5BA9aTn84SOVABBScoBIo= X-Google-Smtp-Source: ABdhPJxQ667QoadK4vclI1VRhQKKRhBcCBhLhFrtOb5+/iMQATJjcyWcT9iXCGyner7hsTPYRV+d8VgX0OxvfhLG7Co= X-Received: by 2002:a67:f601:: with SMTP id k1mr34657600vso.46.1609343751601; Wed, 30 Dec 2020 07:55:51 -0800 (PST) MIME-Version: 1.0 References: <20201230080841.488345-1-lichenyang@loongson.cn> In-Reply-To: <20201230080841.488345-1-lichenyang@loongson.cn> From: Ilia Mirkin Date: Wed, 30 Dec 2020 10:55:40 -0500 Message-ID: Subject: Re: [PATCH] drm/loongson: Add DRM Driver for Loongson 7A1000 bridge chip To: Chenyang Li X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Dec 30, 2020 at 6:08 AM Chenyang Li wrote: > + switch (format->format) { > + case DRM_FORMAT_RGB565: > + lcrtc->cfg_reg |= 0x3; > + break; > + case DRM_FORMAT_RGB888: > + default: > + lcrtc->cfg_reg |= 0x4; > + break; > + } How does the scanout engine distinguish between RGB888 (24-bit) and XRGB8888 (32-bit)? You've listed both as supported below. Cheers, -ilia _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel