All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ilia Mirkin <imirkin@alum.mit.edu>
To: Eric Anholt <eric@anholt.net>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/6] drm/vc4: Fix some failure to track __iomem decorations on pointers.
Date: Fri, 23 Oct 2015 10:04:55 -0400	[thread overview]
Message-ID: <CAKb7UvjKGQdowensiQr30mQe2Hz7=ALwxCQeF68kYi6jL8i8gQ@mail.gmail.com> (raw)
In-Reply-To: <1445596356-28202-5-git-send-email-eric@anholt.net>


[-- Attachment #1.1: Type: text/plain, Size: 2237 bytes --]

On Oct 23, 2015 6:32 AM, "Eric Anholt" <eric@anholt.net> wrote:
>
> Caught by the kbuild test robot.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
>  drivers/gpu/drm/vc4/vc4_crtc.c | 3 ++-
>  drivers/gpu/drm/vc4/vc4_hvs.c  | 8 ++++----
>  2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c
b/drivers/gpu/drm/vc4/vc4_crtc.c
> index a3a77dd..32c0348 100644
> --- a/drivers/gpu/drm/vc4/vc4_crtc.c
> +++ b/drivers/gpu/drm/vc4/vc4_crtc.c
> @@ -401,7 +401,8 @@ static void vc4_crtc_atomic_flush(struct drm_crtc
*crtc,
>                 dlist_next++;
>
>                 HVS_WRITE(SCALER_DISPLISTX(vc4_crtc->channel),
> -                         (u32 *)vc4_crtc->dlist - (u32
*)vc4->hvs->dlist);
> +                         (u32 __iomem *)vc4_crtc->dlist -
> +                         (u32 __iomem *)vc4->hvs->dlist);
>
>                 /* Make the next display list start after ours. */
>                 vc4_crtc->dlist_size -= (dlist_next - vc4_crtc->dlist);
> diff --git a/drivers/gpu/drm/vc4/vc4_hvs.c b/drivers/gpu/drm/vc4/vc4_hvs.c
> index ab1673f..4d81d43 100644
> --- a/drivers/gpu/drm/vc4/vc4_hvs.c
> +++ b/drivers/gpu/drm/vc4/vc4_hvs.c
> @@ -75,10 +75,10 @@ void vc4_hvs_dump_state(struct drm_device *dev)
>         for (i = 0; i < 64; i += 4) {
>                 DRM_INFO("0x%08x (%s): 0x%08x 0x%08x 0x%08x 0x%08x\n",
>                          i * 4, i < HVS_BOOTLOADER_DLIST_END ? "B" : "D",
> -                        ((uint32_t *)vc4->hvs->dlist)[i + 0],
> -                        ((uint32_t *)vc4->hvs->dlist)[i + 1],
> -                        ((uint32_t *)vc4->hvs->dlist)[i + 2],
> -                        ((uint32_t *)vc4->hvs->dlist)[i + 3]);
> +                        readl((u32 __iomem *)vc4->hvs->dlist + 0),
> +                        readl((u32 __iomem *)vc4->hvs->dlist + 1),
> +                        readl((u32 __iomem *)vc4->hvs->dlist + 2),
> +                        readl((u32 __iomem *)vc4->hvs->dlist + 3));

Looks like you lost the +i here, no?

>         }
>  }
>
> --
> 2.6.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

[-- Attachment #1.2: Type: text/html, Size: 3219 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-10-23 14:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-23 10:32 VC4 fixes for -next Eric Anholt
2015-10-23 10:32 ` Eric Anholt
2015-10-23 10:32 ` [PATCH 1/6] drm/vc4: vc4_plane_duplicate_state() can be static Eric Anholt
2015-10-23 10:32   ` Eric Anholt
2015-10-23 10:32 ` [PATCH 2/6] drm/vc4: fix platform_no_drv_owner.cocci warnings Eric Anholt
2015-10-23 10:32   ` Eric Anholt
2015-10-23 10:32 ` [PATCH 3/6] drm/vc4: fix itnull.cocci warnings Eric Anholt
2015-10-23 10:32 ` [PATCH 4/6] drm/vc4: Fix some failure to track __iomem decorations on pointers Eric Anholt
2015-10-23 10:32   ` Eric Anholt
2015-10-23 14:04   ` Ilia Mirkin [this message]
2015-10-23 16:34     ` Eric Anholt
2015-10-23 10:32 ` [PATCH 5/6] drm/vc4: Make sure that planes aren't scaled Eric Anholt
2015-10-23 10:32   ` Eric Anholt
2015-10-23 11:24   ` Daniel Vetter
2015-10-23 11:24     ` Daniel Vetter
2015-10-23 10:32 ` [PATCH 6/6] drm/vc4: Add support for more a few more RGB display plane formats Eric Anholt
2015-10-23 10:32   ` Eric Anholt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKb7UvjKGQdowensiQr30mQe2Hz7=ALwxCQeF68kYi6jL8i8gQ@mail.gmail.com' \
    --to=imirkin@alum.mit.edu \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.