From: Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
To: Oscar Salvador
<osalvador.vilardaga-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
"dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH v2 2/5] nouveau_hwmon: Add nouveau_hwmon_ops structure with .is_visible/.read_string
Date: Wed, 19 Apr 2017 14:19:37 -0400 [thread overview]
Message-ID: <CAKb7UvjOrkCZLLZ+1P4uR_+Cwm701a=cWys51sPKcwgSuOYAtw@mail.gmail.com> (raw)
In-Reply-To: <1492415272-20378-3-git-send-email-osalvador.vilardaga-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Mon, Apr 17, 2017 at 3:47 AM, Oscar Salvador
<osalvador.vilardaga@gmail.com> wrote:
> +static char *input_label = "GPU core";
This needs to be static const char input_label[] = "GPU core";
or at least static const char *const input_label = "GPU core";
-ilia
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
next prev parent reply other threads:[~2017-04-19 18:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-17 7:47 [PATCH v2 0/5] replace hwmon_device_register for hwmon_device_register_with_info Oscar Salvador
[not found] ` <1492415272-20378-1-git-send-email-osalvador.vilardaga-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-04-17 7:47 ` [PATCH v2 1/5] nouveau_hwmon: Add config for all sensors and their settings Oscar Salvador
[not found] ` <1492415272-20378-2-git-send-email-osalvador.vilardaga-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-04-19 18:11 ` Ilia Mirkin
2017-04-19 18:18 ` [Nouveau] " Oscar Salvador
2017-04-17 7:47 ` [PATCH v2 2/5] nouveau_hwmon: Add nouveau_hwmon_ops structure with .is_visible/.read_string Oscar Salvador
[not found] ` <1492415272-20378-3-git-send-email-osalvador.vilardaga-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-04-18 7:56 ` Karol Herbst
2017-04-20 6:47 ` [Nouveau] " Oscar Salvador
2017-04-20 7:32 ` Oscar Salvador
2017-04-19 18:19 ` Ilia Mirkin [this message]
2017-04-17 7:47 ` [PATCH v2 3/5] nouveau_hwmon: Remove old code, add .write/.read operations Oscar Salvador
2017-04-17 7:47 ` [PATCH v2 4/5] nouveau_hwmon: Add support for auto_point attributes Oscar Salvador
[not found] ` <1492415272-20378-5-git-send-email-osalvador.vilardaga-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-04-19 18:25 ` Ilia Mirkin
2017-04-17 7:47 ` [PATCH v2 5/5] nouveau_hwmon: Change permissions to numeric Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKb7UvjOrkCZLLZ+1P4uR_+Cwm701a=cWys51sPKcwgSuOYAtw@mail.gmail.com' \
--to=imirkin-frubxkncsvf2fbvcvol8/a@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=osalvador.vilardaga-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.