From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45D07C47255 for ; Mon, 11 May 2020 23:06:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 17DFE20714 for ; Mon, 11 May 2020 23:06:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727867AbgEKXGK (ORCPT ); Mon, 11 May 2020 19:06:10 -0400 Received: from mail-vs1-f66.google.com ([209.85.217.66]:43857 "EHLO mail-vs1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725836AbgEKXGK (ORCPT ); Mon, 11 May 2020 19:06:10 -0400 Received: by mail-vs1-f66.google.com with SMTP id m24so6703268vsq.10 for ; Mon, 11 May 2020 16:06:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XsOk0fjltEAaptnvoAyKNwWldPrO+GBFD6zagPKDmGg=; b=J2BC/FSbSimtlkuHaqnrZLT4ZN5Slp5ZNEFStJye2qP9h8yD2J9YMOUX4v5cYPGsxu ZUqB9myLafPox+D4n6Gkvmxp5IaWUHuHbxOZZJWJWQMqp+Q7ARy0SUQnlH0KHwQr+w9l v9YVLOJXDoxPiD27kno8lmyZHFCuk0ibTZEQGqxsHJCV+mF+Wq+Qcch9YkU2xUvxruGL diMnw0x4Dghq/V+m8r95u0A4aCfuM1A5SuotC46KM49duTZEg3RPSXg0MdWWi16bclde CRmL3mN3DxDcLUl0050yBZqw/lVFRHpCDh+VwvgfvijrjVtPasoBoIgFVNkXH/QMApUL DPXw== X-Gm-Message-State: AGi0Pub+Hl6If14zrlqB17BeUvimIcRZ521uPCg+VX4ApDlIlVwNkcqv JtLRAQx7NeeGtnYjKhAkvGthc07M9hwbs9jWG9ofQi/G X-Google-Smtp-Source: APiQypKo/KHLOg1rAy+czGJX+lzNM8SR5AyvpY845dOvPV0Ql06/64FQLVBC5d2MCJrmRRgt9Y9fFCvGby21/auV9/g= X-Received: by 2002:a05:6102:502:: with SMTP id l2mr13181954vsa.210.1589238369237; Mon, 11 May 2020 16:06:09 -0700 (PDT) MIME-Version: 1.0 References: <20200511224148.598468-1-lyude@redhat.com> <20200511224148.598468-4-lyude@redhat.com> In-Reply-To: <20200511224148.598468-4-lyude@redhat.com> From: Ilia Mirkin Date: Mon, 11 May 2020 19:05:58 -0400 Message-ID: Subject: Re: [PATCH v3 3/5] drm/nouveau/kms/gv100-: Add support for interlaced modes To: Lyude Paul Cc: nouveau , Ben Skeggs , David Airlie , Daniel Vetter , dri-devel , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 11, 2020 at 6:42 PM Lyude Paul wrote: > diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c > index 43bcbb6d73c4..6dae00da5d7e 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_connector.c > +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c > @@ -1065,7 +1065,7 @@ nouveau_connector_mode_valid(struct drm_connector *connector, > return get_slave_funcs(encoder)->mode_valid(encoder, mode); > case DCB_OUTPUT_DP: > if (mode->flags & DRM_MODE_FLAG_INTERLACE && > - !nv_encoder->dp.caps.interlace) > + !nv_encoder->caps.dp_interlace) > return MODE_NO_INTERLACE; > > max_clock = nv_encoder->dp.link_nr; You probably meant for this hunk to go into an earlier patch. -ilia From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFA24C54E8D for ; Mon, 11 May 2020 23:06:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE01720714 for ; Mon, 11 May 2020 23:06:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE01720714 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alum.mit.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 28AB76E7F1; Mon, 11 May 2020 23:06:11 +0000 (UTC) Received: from mail-vs1-f67.google.com (mail-vs1-f67.google.com [209.85.217.67]) by gabe.freedesktop.org (Postfix) with ESMTPS id 298F66E7EC; Mon, 11 May 2020 23:06:10 +0000 (UTC) Received: by mail-vs1-f67.google.com with SMTP id z1so6709205vsn.11; Mon, 11 May 2020 16:06:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XsOk0fjltEAaptnvoAyKNwWldPrO+GBFD6zagPKDmGg=; b=i1YJRV4S86DWpwPvYVT/VVoYL8E5P/S3bt/ZjgntKPbC1w/FBPQH1YdWGKxNW17VBb 1lFrgb2+vR6y2PiI3i1cKambZ2TJkN18MM5tE6wcPhJ4eRY0hff/pVB2V4LNwQntbdU3 CWW8VJq4Da7W8u2wb2UP+e1DFz+MERk4yES4VSSvA1u2YbuwTL1dDKsQqxZsConnTheG Lc4KV0By8lFs7PW9C/6cRVAvuiR5n76CBk204p1Npm7V5dvg0D8wDqILTDFeYxoQcn9H HMoZtd2pJkGnBCbJ55vzZpcrgShd/3Y8VCoHytfm6X9Kz0kXx5WfhZHqw08JX4ZazmCB FsfA== X-Gm-Message-State: AGi0PuYQRZm0OlH3NzLcSs9evEB8p1xkxnKmKzaYiD5O153xyQRaInP9 HyTAnjXFOFy+v5npuHSWrvbIbGZq1fzNU9Bs17w= X-Google-Smtp-Source: APiQypKo/KHLOg1rAy+czGJX+lzNM8SR5AyvpY845dOvPV0Ql06/64FQLVBC5d2MCJrmRRgt9Y9fFCvGby21/auV9/g= X-Received: by 2002:a05:6102:502:: with SMTP id l2mr13181954vsa.210.1589238369237; Mon, 11 May 2020 16:06:09 -0700 (PDT) MIME-Version: 1.0 References: <20200511224148.598468-1-lyude@redhat.com> <20200511224148.598468-4-lyude@redhat.com> In-Reply-To: <20200511224148.598468-4-lyude@redhat.com> From: Ilia Mirkin Date: Mon, 11 May 2020 19:05:58 -0400 Message-ID: Subject: Re: [PATCH v3 3/5] drm/nouveau/kms/gv100-: Add support for interlaced modes To: Lyude Paul X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , nouveau , LKML , dri-devel , Ben Skeggs Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, May 11, 2020 at 6:42 PM Lyude Paul wrote: > diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c > index 43bcbb6d73c4..6dae00da5d7e 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_connector.c > +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c > @@ -1065,7 +1065,7 @@ nouveau_connector_mode_valid(struct drm_connector *connector, > return get_slave_funcs(encoder)->mode_valid(encoder, mode); > case DCB_OUTPUT_DP: > if (mode->flags & DRM_MODE_FLAG_INTERLACE && > - !nv_encoder->dp.caps.interlace) > + !nv_encoder->caps.dp_interlace) > return MODE_NO_INTERLACE; > > max_clock = nv_encoder->dp.link_nr; You probably meant for this hunk to go into an earlier patch. -ilia _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel