From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C634C433DB for ; Tue, 23 Feb 2021 15:49:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F124F64E20 for ; Tue, 23 Feb 2021 15:49:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233466AbhBWPtV (ORCPT ); Tue, 23 Feb 2021 10:49:21 -0500 Received: from mail-io1-f52.google.com ([209.85.166.52]:46209 "EHLO mail-io1-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233423AbhBWPro (ORCPT ); Tue, 23 Feb 2021 10:47:44 -0500 Received: by mail-io1-f52.google.com with SMTP id u8so17523876ior.13 for ; Tue, 23 Feb 2021 07:47:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q+CvRb8uJsnMhLBA4z+SJwvevSaxCnZTQPudMnhz+y8=; b=M0kc+GcDAXfDoLDuTMtzaQcnA08poU/GD7IASOJi0xLMdvITERr3Bb6eOPv5kZWxg7 NmHz+BbsTIj9jHbBginGoDEhS16emMbCEHTfmpaTgoQtinGW5bODHgIusaIUkAIiaSFU hhRo0yMLYbBs1dxbN3Sfequ89hslWJvUaewyjDBVrQCTeU9/FBJlAb4cF/WZ3IPMYN7L RZOdf9IYZaiL1s3htU84Cedytif6SVh+DUk6zhU3KpGzW/TZCLw5iipQ2xt04ymObliN I+eequEJ6yr6YLVi+RLrAkU0zAynNhoLS7FUjQJFoLlTIzfSjFIFSZWAedXXlATBqlRP 2gbQ== X-Gm-Message-State: AOAM532qGNRmXC63jqDMDmijqj0n4vivC3+F8F1tth/BkSWAIfaJLKPy Ca2ujUv4fpFdUiev2ESod0r1W9GkcqscKwaLLZQ= X-Google-Smtp-Source: ABdhPJz1kFrzRXcSKPQzV0L9KIq7evTjzIK/fhnl6+WUHdZTdl5LT2+m6x7mNbscJ1uoZ/eP3Tr0b55SGQjjzmQLtUI= X-Received: by 2002:a6b:f206:: with SMTP id q6mr20237814ioh.143.1614095223592; Tue, 23 Feb 2021 07:47:03 -0800 (PST) MIME-Version: 1.0 References: <20210119015415.2511028-1-lyude@redhat.com> <20210119015415.2511028-2-lyude@redhat.com> In-Reply-To: From: Ilia Mirkin Date: Tue, 23 Feb 2021 10:46:52 -0500 Message-ID: Subject: Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace To: Alex Riesen Cc: Lyude Paul , Pankaj Bharadiya , David Airlie , nouveau , James Jones , LKML , dri-devel , Jeremy Cline , Ben Skeggs , Dave Airlie Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 23, 2021 at 10:36 AM Alex Riesen wrote: > > Ilia Mirkin, Tue, Feb 23, 2021 15:56:21 +0100: > > On Tue, Feb 23, 2021 at 9:26 AM Alex Riesen wrote: > > > Lyude Paul, Tue, Jan 19, 2021 02:54:13 +0100: > > > > diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c > > > > index c6367035970e..5f4f09a601d4 100644 > > > > --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c > > > > +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c > > > > @@ -2663,6 +2663,14 @@ nv50_display_create(struct drm_device *dev) > > > > else > > > > nouveau_display(dev)->format_modifiers = disp50xx_modifiers; > > > > > > > > + if (disp->disp->object.oclass >= GK104_DISP) { > > > > + dev->mode_config.cursor_width = 256; > > > > + dev->mode_config.cursor_height = 256; > > > > + } else { > > > > + dev->mode_config.cursor_width = 64; > > > > + dev->mode_config.cursor_height = 64; > > > > + } > > > > + > > > > /* create crtc objects to represent the hw heads */ > > > > if (disp->disp->object.oclass >= GV100_DISP) > > > > crtcs = nvif_rd32(&device->object, 0x610060) & 0xff; > > > > > > This change broke X cursor in my setup, and reverting the commit restores it. > > > > > > Dell Precision M4800, issue ~2014 with GK106GLM [Quadro K2100M] (rev a1). > > > libdrm 2.4.91-1 (Debian 10.8 stable). > > > There are no errors or warnings in Xorg logs nor in the kernel log. > > > > Could you confirm which ddx is driving the nvidia hw? You can find > > this out by running "xrandr --listproviders", or also in the xorg log. > > xrandr(1) does not seem to list much: > > $ xrandr --listproviders > Providers: number : 1 > Provider 0: id: 0x48 cap: 0xf, Source Output, Sink Output, Source Offload, Sink Offload crtcs: 4 outputs: 5 associated providers: 0 name:modesetting Thanks - this is what I was looking for. name:modesetting, i.e. the modesetting ddx driver. I checked nouveau source, and it seems like it uses a 64x64 cursor no matter what. Not sure what the modesetting ddx does. I'd recommend using xf86-video-nouveau in any case, but some distros have decided to explicitly force modesetting in preference of nouveau. Oh well. (And regardless, the regression should be addressed somehow, but it's also good to understand what the problem is.) Can you confirm what the problem with the cursor is? -ilia From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F30BC433E0 for ; Tue, 23 Feb 2021 15:47:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E07A364DE8 for ; Tue, 23 Feb 2021 15:47:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E07A364DE8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alum.mit.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=nouveau-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F04296E9E7; Tue, 23 Feb 2021 15:47:04 +0000 (UTC) Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id 58C6D6E9D2; Tue, 23 Feb 2021 15:47:04 +0000 (UTC) Received: by mail-io1-f49.google.com with SMTP id i8so17541660iog.7; Tue, 23 Feb 2021 07:47:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q+CvRb8uJsnMhLBA4z+SJwvevSaxCnZTQPudMnhz+y8=; b=AeWapl4co9ZkJosmvA0IgSFwSNbO7+4rttRnp6JNidX+AWkrFF0mrFiBXHjl5eqtoh oC9kUTt4q2uh/U58gT5RgoeJtF/vBqpSGB0jgz2NYfPWAD0M23YLu1Rf1oSRUKXTw6zz S0W+W8UtftOLc+qHg+pkPsrj3aGj3cQnCUEx0/MvbdHXQqquPEfGf9CgoyFnGwc0xVRs 6WhG/GRzt5Jw12WNntutbE8ecN0OcJNv3GVSeMZWwtmCLSKxYY3S9lRVJ9ELDCPnekq8 SRfR2g9nwhFmyz2Cs3HPsPBP6Ba5HBmSSV3iouhaSYBtaZ8QMHpkB67kd4T8AOxd87ps Gjdg== X-Gm-Message-State: AOAM530NiDcUG9NOAO0BMkBGA+d5rFUPf5q42NXKQHGQbQ6v/CySda/z 1AtwLpN5SnuwiWfe//dXfDazOVm5gl0iftNaMQE= X-Google-Smtp-Source: ABdhPJz1kFrzRXcSKPQzV0L9KIq7evTjzIK/fhnl6+WUHdZTdl5LT2+m6x7mNbscJ1uoZ/eP3Tr0b55SGQjjzmQLtUI= X-Received: by 2002:a6b:f206:: with SMTP id q6mr20237814ioh.143.1614095223592; Tue, 23 Feb 2021 07:47:03 -0800 (PST) MIME-Version: 1.0 References: <20210119015415.2511028-1-lyude@redhat.com> <20210119015415.2511028-2-lyude@redhat.com> In-Reply-To: From: Ilia Mirkin Date: Tue, 23 Feb 2021 10:46:52 -0500 Message-ID: To: Alex Riesen Subject: Re: [Nouveau] [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Pankaj Bharadiya , LKML , dri-devel , Ben Skeggs , nouveau , Dave Airlie Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Tue, Feb 23, 2021 at 10:36 AM Alex Riesen wrote: > > Ilia Mirkin, Tue, Feb 23, 2021 15:56:21 +0100: > > On Tue, Feb 23, 2021 at 9:26 AM Alex Riesen wrote: > > > Lyude Paul, Tue, Jan 19, 2021 02:54:13 +0100: > > > > diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c > > > > index c6367035970e..5f4f09a601d4 100644 > > > > --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c > > > > +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c > > > > @@ -2663,6 +2663,14 @@ nv50_display_create(struct drm_device *dev) > > > > else > > > > nouveau_display(dev)->format_modifiers = disp50xx_modifiers; > > > > > > > > + if (disp->disp->object.oclass >= GK104_DISP) { > > > > + dev->mode_config.cursor_width = 256; > > > > + dev->mode_config.cursor_height = 256; > > > > + } else { > > > > + dev->mode_config.cursor_width = 64; > > > > + dev->mode_config.cursor_height = 64; > > > > + } > > > > + > > > > /* create crtc objects to represent the hw heads */ > > > > if (disp->disp->object.oclass >= GV100_DISP) > > > > crtcs = nvif_rd32(&device->object, 0x610060) & 0xff; > > > > > > This change broke X cursor in my setup, and reverting the commit restores it. > > > > > > Dell Precision M4800, issue ~2014 with GK106GLM [Quadro K2100M] (rev a1). > > > libdrm 2.4.91-1 (Debian 10.8 stable). > > > There are no errors or warnings in Xorg logs nor in the kernel log. > > > > Could you confirm which ddx is driving the nvidia hw? You can find > > this out by running "xrandr --listproviders", or also in the xorg log. > > xrandr(1) does not seem to list much: > > $ xrandr --listproviders > Providers: number : 1 > Provider 0: id: 0x48 cap: 0xf, Source Output, Sink Output, Source Offload, Sink Offload crtcs: 4 outputs: 5 associated providers: 0 name:modesetting Thanks - this is what I was looking for. name:modesetting, i.e. the modesetting ddx driver. I checked nouveau source, and it seems like it uses a 64x64 cursor no matter what. Not sure what the modesetting ddx does. I'd recommend using xf86-video-nouveau in any case, but some distros have decided to explicitly force modesetting in preference of nouveau. Oh well. (And regardless, the regression should be addressed somehow, but it's also good to understand what the problem is.) Can you confirm what the problem with the cursor is? -ilia _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C199C433DB for ; Tue, 23 Feb 2021 15:47:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3E6B64E20 for ; Tue, 23 Feb 2021 15:47:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3E6B64E20 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alum.mit.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 08D6488130; Tue, 23 Feb 2021 15:47:05 +0000 (UTC) Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id 58C6D6E9D2; Tue, 23 Feb 2021 15:47:04 +0000 (UTC) Received: by mail-io1-f49.google.com with SMTP id i8so17541660iog.7; Tue, 23 Feb 2021 07:47:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q+CvRb8uJsnMhLBA4z+SJwvevSaxCnZTQPudMnhz+y8=; b=AeWapl4co9ZkJosmvA0IgSFwSNbO7+4rttRnp6JNidX+AWkrFF0mrFiBXHjl5eqtoh oC9kUTt4q2uh/U58gT5RgoeJtF/vBqpSGB0jgz2NYfPWAD0M23YLu1Rf1oSRUKXTw6zz S0W+W8UtftOLc+qHg+pkPsrj3aGj3cQnCUEx0/MvbdHXQqquPEfGf9CgoyFnGwc0xVRs 6WhG/GRzt5Jw12WNntutbE8ecN0OcJNv3GVSeMZWwtmCLSKxYY3S9lRVJ9ELDCPnekq8 SRfR2g9nwhFmyz2Cs3HPsPBP6Ba5HBmSSV3iouhaSYBtaZ8QMHpkB67kd4T8AOxd87ps Gjdg== X-Gm-Message-State: AOAM530NiDcUG9NOAO0BMkBGA+d5rFUPf5q42NXKQHGQbQ6v/CySda/z 1AtwLpN5SnuwiWfe//dXfDazOVm5gl0iftNaMQE= X-Google-Smtp-Source: ABdhPJz1kFrzRXcSKPQzV0L9KIq7evTjzIK/fhnl6+WUHdZTdl5LT2+m6x7mNbscJ1uoZ/eP3Tr0b55SGQjjzmQLtUI= X-Received: by 2002:a6b:f206:: with SMTP id q6mr20237814ioh.143.1614095223592; Tue, 23 Feb 2021 07:47:03 -0800 (PST) MIME-Version: 1.0 References: <20210119015415.2511028-1-lyude@redhat.com> <20210119015415.2511028-2-lyude@redhat.com> In-Reply-To: From: Ilia Mirkin Date: Tue, 23 Feb 2021 10:46:52 -0500 Message-ID: Subject: Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace To: Alex Riesen X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Pankaj Bharadiya , James Jones , LKML , dri-devel , Jeremy Cline , Ben Skeggs , nouveau , Dave Airlie Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Feb 23, 2021 at 10:36 AM Alex Riesen wrote: > > Ilia Mirkin, Tue, Feb 23, 2021 15:56:21 +0100: > > On Tue, Feb 23, 2021 at 9:26 AM Alex Riesen wrote: > > > Lyude Paul, Tue, Jan 19, 2021 02:54:13 +0100: > > > > diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c > > > > index c6367035970e..5f4f09a601d4 100644 > > > > --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c > > > > +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c > > > > @@ -2663,6 +2663,14 @@ nv50_display_create(struct drm_device *dev) > > > > else > > > > nouveau_display(dev)->format_modifiers = disp50xx_modifiers; > > > > > > > > + if (disp->disp->object.oclass >= GK104_DISP) { > > > > + dev->mode_config.cursor_width = 256; > > > > + dev->mode_config.cursor_height = 256; > > > > + } else { > > > > + dev->mode_config.cursor_width = 64; > > > > + dev->mode_config.cursor_height = 64; > > > > + } > > > > + > > > > /* create crtc objects to represent the hw heads */ > > > > if (disp->disp->object.oclass >= GV100_DISP) > > > > crtcs = nvif_rd32(&device->object, 0x610060) & 0xff; > > > > > > This change broke X cursor in my setup, and reverting the commit restores it. > > > > > > Dell Precision M4800, issue ~2014 with GK106GLM [Quadro K2100M] (rev a1). > > > libdrm 2.4.91-1 (Debian 10.8 stable). > > > There are no errors or warnings in Xorg logs nor in the kernel log. > > > > Could you confirm which ddx is driving the nvidia hw? You can find > > this out by running "xrandr --listproviders", or also in the xorg log. > > xrandr(1) does not seem to list much: > > $ xrandr --listproviders > Providers: number : 1 > Provider 0: id: 0x48 cap: 0xf, Source Output, Sink Output, Source Offload, Sink Offload crtcs: 4 outputs: 5 associated providers: 0 name:modesetting Thanks - this is what I was looking for. name:modesetting, i.e. the modesetting ddx driver. I checked nouveau source, and it seems like it uses a 64x64 cursor no matter what. Not sure what the modesetting ddx does. I'd recommend using xf86-video-nouveau in any case, but some distros have decided to explicitly force modesetting in preference of nouveau. Oh well. (And regardless, the regression should be addressed somehow, but it's also good to understand what the problem is.) Can you confirm what the problem with the cursor is? -ilia _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel