Re: [PATCH] intel-hid: new hid event driver for hotkeys

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alex Hung <alex.hung@canonical.com>
Cc: Darren Hart <dvhart@infradead.org>,
	platform-driver-x86@vger.kernel.org,
	Andy Lutomirski <luto@amacapital.net>
Subject: Re: [PATCH] intel-hid: new hid event driver for hotkeys
Date: Thu, 29 Sep 2016 09:02:48 -0700	[thread overview]
Message-ID: <CAKdAkRQTw1KDJE_EmYeYAaVy0od-mnShmDax46Kh8Xcq6Ec4kw@mail.gmail.com> (raw)
In-Reply-To: <1450337402-4178-1-git-send-email-alex.hung@canonical.com>

Quite a bit late, but still:

On Wed, Dec 16, 2015 at 11:30 PM, Alex Hung <alex.hung@canonical.com> wrote:
> +
> +static int __init intel_hid_init(void)
> +{
> +       acpi_walk_namespace(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT,
> +                           ACPI_UINT32_MAX, check_acpi_dev, NULL,
> +                           (void *)intel_hid_ids, NULL);
> +
> +       return platform_driver_register(&intel_hid_pl_driver);
> +}

Why do we need to walk instantiate the device ourselves instead of
having ACPI core do it for us? I also see this pattern in intel-vbtn.c
now.

Thanks.

-- 
Dmitry