From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756227AbdLOSxP (ORCPT ); Fri, 15 Dec 2017 13:53:15 -0500 Received: from mail-ua0-f196.google.com ([209.85.217.196]:45165 "EHLO mail-ua0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755834AbdLOSxL (ORCPT ); Fri, 15 Dec 2017 13:53:11 -0500 X-Google-Smtp-Source: ACJfBosax8Bo5vq65N7HaYhPCuJ3Y31wqz7QqcDpF9IsrnEY35c5iCB9maVK3wElvxp7zwqlPaZqTuqasUgMtACXZ9U= MIME-Version: 1.0 In-Reply-To: References: <20171213232122.5ztmwume5kylh4mz@dtor-ws> From: Dmitry Torokhov Date: Fri, 15 Dec 2017 10:53:10 -0800 Message-ID: Subject: Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink To: Casey Leedom Cc: Greg Kroah-Hartman , Eric Dumazet , Eric Dumazet , Tariq Toukan , "David S . Miller" , Komali Katari , "Luis R. Rodriguez" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 15, 2017 at 10:17 AM, Casey Leedom wrote: > Hi Dmitry, > > Komali reports that she still sees the originally reported issue with your > latest patch. This issue started with kernel.org commit > 1455cf8dbfd06aa7651dcfccbadb7a093944ca65 (Wed Jul 19 17:24:30 2017 -0700). > > cxgb4vf is getting loaded in the Hypervisor when a cxgb4 Virtual Function > is assigned to a Virtual Machine, and the VM is brought up. We may need to > do some debuging ... How would you like to proceed? Hmm, can she collect output of 'udevadm monitor -p' at the time you assign the adapter to the VM? Also, do you have any udev rules that is specific to cxgb? Or any other custom udev rules? Also, we only suppress the modalias string on driver unbind, could it be that for you module loading is happening when driver is bound to the device? Actually, as far as I can see, you share PCI IDs between cxgb4 and cxgb4vf drivers, so they have similar modalias entries. How do you normally decide what driver is to be loaded for a given device? Thanks. -- Dmitry