From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42246C433E0 for ; Thu, 30 Jul 2020 17:46:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F16C20838 for ; Thu, 30 Jul 2020 17:46:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DR65LCOU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730307AbgG3Rqo (ORCPT ); Thu, 30 Jul 2020 13:46:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728035AbgG3Rqn (ORCPT ); Thu, 30 Jul 2020 13:46:43 -0400 Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 471ABC061574 for ; Thu, 30 Jul 2020 10:46:43 -0700 (PDT) Received: by mail-io1-xd41.google.com with SMTP id t15so20162757iob.3 for ; Thu, 30 Jul 2020 10:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KAQxMtrcNtT/qn4VP9i1rWA9WddbB6VGPbgpkMkGrA0=; b=DR65LCOUMQR20BJpxQ9xrmHCoWWhUQ8CIys3obDf+4dsubLWlGYWkVgHK80ueyn9Ht tisBUvDtBMEqouGdnSOotr7ZVXkUYZ5ELYgzRS37so41EvGVV3W5AVVEzbJGu1pqK3xC PALm8nzf7olRFrjBT2UgQleA2wTWMeB/k8HjG9FdODa6BiJTz5MhY6xw1uaqaM+L5XAw sq03qRHMP13q76GoVjPiktV7yUZQ6jBmQVrboaQHDeV5Ie7RAlWXxHYc1fSWC6ZSCmAc v0h8HIGh2upttDFZyv5JL6pMFZuLdl4OkPzftWSje+AOrhg17VWaYN+Ouz6gJDFLG8pl h0qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KAQxMtrcNtT/qn4VP9i1rWA9WddbB6VGPbgpkMkGrA0=; b=TKORmu3YTOOZrVTOYgaU4D2JDZImq27CarU0MotwybUwIL2LgzQYZBYPvP/lcXStZL GmkdoOKq7Kc7HAns956dEuxZZos2WJJW2qkf2aqhEOEsY738lQgPMvQkSlDky/TXQ6bS 1Li/ZC2/OaJLJz3z2UvSvSNujtEXYXLO/xiuBgx5pJR2PchKFC4igagKSQTO/19HHwHZ weeyccVVZOCSNkXnqV5M2XuW1TSFytdxiHoo092ohkxsWe9TocU/FAgFP++R86Ryf4wk G40R1AoEYPdhn4EMDCYXYoKIM6EzUzntWxdmSdA4T9Tfh4REk8YHyOwEbonK42IPq6EI JUCA== X-Gm-Message-State: AOAM531VAUSsj95sVbCU72OeRET2qMmZwh+p0156WE0Ie0Ik3IEsnF5f hvRo7tFRrK0SWgxYxLetdQCklkAtG6vGbeiZOZE= X-Google-Smtp-Source: ABdhPJyhYSIPo/giDMeelwhangK4RmO8N4BnVkCP2Rskejgr5cQANOAipXRcjsyTeYIcHCvQYRbde9p2WR4m/oKgVd8= X-Received: by 2002:a6b:dd12:: with SMTP id f18mr22464031ioc.109.1596131202475; Thu, 30 Jul 2020 10:46:42 -0700 (PDT) MIME-Version: 1.0 References: <20200713144324.23654-1-a.hajda@samsung.com> <20200730070832.GA4045592@kroah.com> <20200730164845.GE5055@sirena.org.uk> In-Reply-To: <20200730164845.GE5055@sirena.org.uk> From: Dmitry Torokhov Date: Thu, 30 Jul 2020 10:46:31 -0700 Message-ID: Subject: Re: [PATCH v9 0/4] driver core: add probe error check helper To: Mark Brown Cc: Greg Kroah-Hartman , Andrzej Hajda , Jernej Skrabec , Bartlomiej Zolnierkiewicz , Jonas Karlman , lkml , "open list:DRM DRIVERS" , Russell King - ARM Linux , Neil Armstrong , Andy Shevchenko , Laurent Pinchart , "Rafael J. Wysocki" , linux-arm-kernel , Marek Szyprowski Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 30, 2020 at 9:49 AM Mark Brown wrote: > > On Thu, Jul 30, 2020 at 09:18:30AM -0700, Dmitry Torokhov wrote: > > > I believe it still has not been answered why this can't be pushed into > > resource providers (clock, regulators, gpio, interrupts, etc), > > especially for devm APIs where we know exactly what device we are > > requesting a resource for, so that individual drivers do not need to > > change anything. > > The error messages are frequently in the caller rather than the > frameworks, it's often helpful for the comprehensibility of the error > messages especially in cases where things may be legitimately absent. Not for deferral. All you need to know in this case is: "device A is attempting to request resource B which is not ready yet" There is nothing to handle on the caller part except to float the error up. > > > We can mark the device as being probed so that probe > > deferral is only handled when we actually execute probe() (and for the > > bonus points scream loudly if someone tries to return -EPROBE_DEFER > > outside of probe path). > > Is this a big issue? We do not know ;) Probably not. It will just get reported as an ordinary failure and the driver will handle it somehow. Still it would be nice to know if we attempt to raise deferrals in code paths where they do not make sense. Thanks. -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBEDEC433DF for ; Thu, 30 Jul 2020 17:48:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8F3820838 for ; Thu, 30 Jul 2020 17:48:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JcWLZ8M8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DR65LCOU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8F3820838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=a2yBsIftTbxRDC2Awl94XH59pFg5S2FbQTKmzahbdN8=; b=JcWLZ8M894OTQ+VaXrfVoDCqD JNShUmaiJVNUhkpGJnKv/v3zksMHCjkPp2YluSmxgmtZGp6U2+ZDLHkNbd4CEn7Loi0GD+J/35EDb itCoL2E0SFfDEwk/q87t/enqAOVgGsXlegNsaMpmv8FFT8C/LHYFHf+61pKr3+HKzxO23C8yOgBXj SCVXyDQQ/LK0hl9XvPLN44eTs61KlG7lf5NkejHi4bm+bgHxpNKEiKC45gqnFmNG+odoB29rDcKmE G6Jx00H06WauS6weYPljkp9NQWjXufN/+bOdL4dkOb0FxO9s1hI3HDfFJ9MlFuE9PyEYCMJSJz0FJ V//kvMukg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1Cdk-0005Db-D1; Thu, 30 Jul 2020 17:46:48 +0000 Received: from mail-io1-xd44.google.com ([2607:f8b0:4864:20::d44]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1Cdh-0005Ca-Dv for linux-arm-kernel@lists.infradead.org; Thu, 30 Jul 2020 17:46:46 +0000 Received: by mail-io1-xd44.google.com with SMTP id j8so16739010ioe.9 for ; Thu, 30 Jul 2020 10:46:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KAQxMtrcNtT/qn4VP9i1rWA9WddbB6VGPbgpkMkGrA0=; b=DR65LCOUMQR20BJpxQ9xrmHCoWWhUQ8CIys3obDf+4dsubLWlGYWkVgHK80ueyn9Ht tisBUvDtBMEqouGdnSOotr7ZVXkUYZ5ELYgzRS37so41EvGVV3W5AVVEzbJGu1pqK3xC PALm8nzf7olRFrjBT2UgQleA2wTWMeB/k8HjG9FdODa6BiJTz5MhY6xw1uaqaM+L5XAw sq03qRHMP13q76GoVjPiktV7yUZQ6jBmQVrboaQHDeV5Ie7RAlWXxHYc1fSWC6ZSCmAc v0h8HIGh2upttDFZyv5JL6pMFZuLdl4OkPzftWSje+AOrhg17VWaYN+Ouz6gJDFLG8pl h0qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KAQxMtrcNtT/qn4VP9i1rWA9WddbB6VGPbgpkMkGrA0=; b=ESwg6COVi7JPXJotgbVImfNvb5k+fhk8PThly3sn+wA7oWulBqsvgudLqZ+VUH/z0b jUJI1OULs67sVXfKNYWV/Q5nqMK9PfW63lMIqE9czWV/tOpbifxLmA+PhhcumtXQpnjM 37BoYktxGRAQw+aqaFR0ZCE289B+zrZcJU++pZR2mxGxXnY3wMt9nDL7wh+PYut1WW7j x/isBSgQGvRm6H3myb7cTLYD1u4CSNWIUc/oUAdUB2W4IhqGCZJ5v2hK0IiyZCp/YoFn GRLePycqQ79026a4sI0M5iciIii+YnkRgpELSQk6e6CPz0FvSQjL/njEmeeB3eYw3Wto kt6w== X-Gm-Message-State: AOAM531aKA/yMzjO/4jml9ZDUkybaQqGqDLE+aukxR3xiyE4rWCWj/IM rBpBmVelTojMGDnUJNYXKYoPGxO82VJFItRdnDc= X-Google-Smtp-Source: ABdhPJyhYSIPo/giDMeelwhangK4RmO8N4BnVkCP2Rskejgr5cQANOAipXRcjsyTeYIcHCvQYRbde9p2WR4m/oKgVd8= X-Received: by 2002:a6b:dd12:: with SMTP id f18mr22464031ioc.109.1596131202475; Thu, 30 Jul 2020 10:46:42 -0700 (PDT) MIME-Version: 1.0 References: <20200713144324.23654-1-a.hajda@samsung.com> <20200730070832.GA4045592@kroah.com> <20200730164845.GE5055@sirena.org.uk> In-Reply-To: <20200730164845.GE5055@sirena.org.uk> From: Dmitry Torokhov Date: Thu, 30 Jul 2020 10:46:31 -0700 Message-ID: Subject: Re: [PATCH v9 0/4] driver core: add probe error check helper To: Mark Brown X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200730_134645_528312_9B10C271 X-CRM114-Status: GOOD ( 21.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Bartlomiej Zolnierkiewicz , Greg Kroah-Hartman , Jonas Karlman , lkml , "open list:DRM DRIVERS" , Russell King - ARM Linux , Neil Armstrong , Andrzej Hajda , Andy Shevchenko , Laurent Pinchart , "Rafael J. Wysocki" , linux-arm-kernel , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 30, 2020 at 9:49 AM Mark Brown wrote: > > On Thu, Jul 30, 2020 at 09:18:30AM -0700, Dmitry Torokhov wrote: > > > I believe it still has not been answered why this can't be pushed into > > resource providers (clock, regulators, gpio, interrupts, etc), > > especially for devm APIs where we know exactly what device we are > > requesting a resource for, so that individual drivers do not need to > > change anything. > > The error messages are frequently in the caller rather than the > frameworks, it's often helpful for the comprehensibility of the error > messages especially in cases where things may be legitimately absent. Not for deferral. All you need to know in this case is: "device A is attempting to request resource B which is not ready yet" There is nothing to handle on the caller part except to float the error up. > > > We can mark the device as being probed so that probe > > deferral is only handled when we actually execute probe() (and for the > > bonus points scream loudly if someone tries to return -EPROBE_DEFER > > outside of probe path). > > Is this a big issue? We do not know ;) Probably not. It will just get reported as an ordinary failure and the driver will handle it somehow. Still it would be nice to know if we attempt to raise deferrals in code paths where they do not make sense. Thanks. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4019C433DF for ; Fri, 31 Jul 2020 07:36:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76EB52067D for ; Fri, 31 Jul 2020 07:36:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DR65LCOU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76EB52067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 537EC6E9EB; Fri, 31 Jul 2020 07:36:09 +0000 (UTC) Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5D75A6E93C for ; Thu, 30 Jul 2020 17:46:43 +0000 (UTC) Received: by mail-io1-xd44.google.com with SMTP id d18so29104482ion.0 for ; Thu, 30 Jul 2020 10:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KAQxMtrcNtT/qn4VP9i1rWA9WddbB6VGPbgpkMkGrA0=; b=DR65LCOUMQR20BJpxQ9xrmHCoWWhUQ8CIys3obDf+4dsubLWlGYWkVgHK80ueyn9Ht tisBUvDtBMEqouGdnSOotr7ZVXkUYZ5ELYgzRS37so41EvGVV3W5AVVEzbJGu1pqK3xC PALm8nzf7olRFrjBT2UgQleA2wTWMeB/k8HjG9FdODa6BiJTz5MhY6xw1uaqaM+L5XAw sq03qRHMP13q76GoVjPiktV7yUZQ6jBmQVrboaQHDeV5Ie7RAlWXxHYc1fSWC6ZSCmAc v0h8HIGh2upttDFZyv5JL6pMFZuLdl4OkPzftWSje+AOrhg17VWaYN+Ouz6gJDFLG8pl h0qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KAQxMtrcNtT/qn4VP9i1rWA9WddbB6VGPbgpkMkGrA0=; b=syWX7a33JC3je68/GsckH6xuMNv7F0l38MNLtnIQXXJS7UwR0gMG66ivW2j6+Wyg1v NjyDYpx/KOhnOpCjcNBN6gDtNGCgqfFVTCN8LmEOEujnnz3Vhbm+tN0+tAKmq6Eas37V xJhqPMnY9kTrWP+n64l3iLnF2H2HswRnTiz0ltxo5TQXlsx3fW/pnLLKzvy8dkH4UN4E vwEMEBbUxs/T3x/n9p0lVromKn8XwKoLgHu5NFAppN3tj5LdsXdAY/RgD0qNtl1imhNy Ximfe1bu8z5GqPSg4YgOpWxy5YtrPCssNeJr1nn85JCmbWynR+ftbg2Iqj5zH/P2BJFX u5Fg== X-Gm-Message-State: AOAM533z+p34MnGAGO10FFZi/JOd2aMKEIk+pzb6p4XUcv8NZkecjste hgAgFqqxmzZdyZvMpLFNdkU4s28sgoEQqam/X2I= X-Google-Smtp-Source: ABdhPJyhYSIPo/giDMeelwhangK4RmO8N4BnVkCP2Rskejgr5cQANOAipXRcjsyTeYIcHCvQYRbde9p2WR4m/oKgVd8= X-Received: by 2002:a6b:dd12:: with SMTP id f18mr22464031ioc.109.1596131202475; Thu, 30 Jul 2020 10:46:42 -0700 (PDT) MIME-Version: 1.0 References: <20200713144324.23654-1-a.hajda@samsung.com> <20200730070832.GA4045592@kroah.com> <20200730164845.GE5055@sirena.org.uk> In-Reply-To: <20200730164845.GE5055@sirena.org.uk> From: Dmitry Torokhov Date: Thu, 30 Jul 2020 10:46:31 -0700 Message-ID: Subject: Re: [PATCH v9 0/4] driver core: add probe error check helper To: Mark Brown X-Mailman-Approved-At: Fri, 31 Jul 2020 07:36:08 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Bartlomiej Zolnierkiewicz , Greg Kroah-Hartman , Jonas Karlman , lkml , "open list:DRM DRIVERS" , Russell King - ARM Linux , Neil Armstrong , Andrzej Hajda , Andy Shevchenko , Laurent Pinchart , "Rafael J. Wysocki" , linux-arm-kernel , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jul 30, 2020 at 9:49 AM Mark Brown wrote: > > On Thu, Jul 30, 2020 at 09:18:30AM -0700, Dmitry Torokhov wrote: > > > I believe it still has not been answered why this can't be pushed into > > resource providers (clock, regulators, gpio, interrupts, etc), > > especially for devm APIs where we know exactly what device we are > > requesting a resource for, so that individual drivers do not need to > > change anything. > > The error messages are frequently in the caller rather than the > frameworks, it's often helpful for the comprehensibility of the error > messages especially in cases where things may be legitimately absent. Not for deferral. All you need to know in this case is: "device A is attempting to request resource B which is not ready yet" There is nothing to handle on the caller part except to float the error up. > > > We can mark the device as being probed so that probe > > deferral is only handled when we actually execute probe() (and for the > > bonus points scream loudly if someone tries to return -EPROBE_DEFER > > outside of probe path). > > Is this a big issue? We do not know ;) Probably not. It will just get reported as an ordinary failure and the driver will handle it somehow. Still it would be nice to know if we attempt to raise deferrals in code paths where they do not make sense. Thanks. -- Dmitry _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel