From: Dmitry Torokhov <email@example.com> To: Benjamin Tissoires <firstname.lastname@example.org> Cc: "Jiri Kosina" <email@example.com>, "Simon Wood" <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, lkml <email@example.com>, Edwin <Edwin@velds.nl>, "Michal Malý" <firstname.lastname@example.org>, "elias vanderstuyft" <email@example.com> Subject: Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel Date: Thu, 10 Dec 2015 10:40:58 -0800 [thread overview] Message-ID: <CAKdAkRSBTBTW8ma79hh+0sr4izJ70SnvUb1gmPFy3MoVWYaUbA@mail.gmail.com> (raw) In-Reply-To: <20151210170853.GC16026@mail.corp.redhat.com> On Thu, Dec 10, 2015 at 9:08 AM, Benjamin Tissoires <firstname.lastname@example.org> wrote: > On Dec 09 2015 or thereabouts, Dmitry Torokhov wrote: >> On Wed, Dec 9, 2015 at 5:23 PM, Dmitry Torokhov >> <email@example.com> wrote: >> > On Thu, Nov 19, 2015 at 10:31 AM, Dmitry Torokhov >> > <firstname.lastname@example.org> wrote: >> >> On Thu, Nov 19, 2015 at 02:50:51PM +0100, Jiri Kosina wrote: >> >>> On Thu, 12 Nov 2015, Simon Wood wrote: >> >>> >> >>> > When plugged in the Logitech G920 wheel starts with USBID 046d:c261 >> >>> > and behaviors as a vendor specific class. If a 'magic' byte sequence >> >>> > is sent the wheel will detach and reconnect as a HID device with the >> >>> > USBID 046d:c262. >> >>> > >> >>> > Signed-off-by: Simon Wood <email@example.com> >> >>> >> >>> Adding Dmitry to CC. >> >>> >> >>> Dmitry, I am planning to take this through my tree together with the rest >> >>> of the actual HID support for that device if you Ack this. >> >> >> >> Hmm, I have an incoming series for xbox that night clash with this... If >> >> you'll put it in a clean branch off 4.3 I'd pull it and then get more >> >> changes on top. >> >> >> >> Can we also change the subject as it is not about adding a minimal >> >> support. Something like "Input: xpad - switch Logitech G920 Wheel into >> >> HID mode" >> >> >> >> Otherwise: >> >> >> >> Acked-by: Dmitry Torokhov <firstname.lastname@example.org> >> > >> > Hmm, looking sat this some more why are we waiting to switch device >> > mode until after userspace opens input device instead of when we are >> > executing driver probe()? >> > >> >> Actually, thinking about it even more, why do we want to have this in >> xpad.c? Have HID module handle both IDs and switch to HID mode if we >> want HID to handle this device. I think we should revert/drop this >> patch. >> > > Hi Dmitry, Hi Benjamin, > > IIRC, last time I saw an XBox-like controller, it doesn't register as a > HID device at all. SO I think It will be hard to switch it into the HID > mode from HID directly. > Simon, can you confirm that the device does not contains any references > to HID while in the XBox mode (lsusb -v should give enough information). > > Switching the device during probe in xpad.c makes a lot of sense > however. It makes as much sense doing it in xpad as doing it from a random USB network driver. I mean the only reason we are doing it from xpad is because of name and the fat that it has usb_driver structure. Nobody stops you from creating a tiny USB stub driver in hid portion that would probe the "non-hid" device and switch it over to hid. Thanks. -- Dmitry
next prev parent reply other threads:[~2015-12-10 18:41 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-12 16:25 [Patch-V2 0/6] HID: Support for the " Simon Wood 2015-11-12 16:25 ` [Patch-V2 1/6] INPUT: xpad: Add minimal support for " Simon Wood 2015-11-19 13:50 ` Jiri Kosina 2015-11-19 18:31 ` Dmitry Torokhov 2015-11-19 18:35 ` Simon Wood 2015-11-19 23:19 ` Edwin 2015-12-10 1:23 ` Dmitry Torokhov 2015-12-10 1:39 ` Dmitry Torokhov 2015-12-10 17:08 ` Benjamin Tissoires 2015-12-10 18:40 ` Dmitry Torokhov [this message] 2016-01-04 9:55 ` Benjamin Tissoires 2016-01-04 12:43 ` madcatxster 2016-01-04 12:43 ` madcatxster [not found] ` <568ad0ae.ea3d320a.6acab.2b84SMTPIN_ADDED_MISSING@mx.google.com> 2016-01-05 1:01 ` Dmitry Torokhov 2016-01-06 14:36 ` Jiri Kosina 2016-01-07 1:47 ` Dmitry Torokhov 2016-01-07 4:25 ` Simon Wood 2016-01-07 22:50 ` Michal Malý 2016-01-07 22:53 ` Dmitry Torokhov 2016-01-07 22:53 ` Dmitry Torokhov 2016-01-07 23:05 ` Michal Malý 2016-01-07 23:05 ` Michal Malý 2016-01-08 9:11 ` Jiri Kosina 2015-12-13 12:50 ` Elias Vanderstuyft 2015-11-12 16:25 ` [Patch-V2 2/6] HID: hid-logitech-hidpp: Add support for very long packets Simon Wood 2015-11-12 16:25 ` [Patch-V2 3/6] HID: hid-logitech-hidpp: Add basic support for Logitech G920 Simon Wood 2015-11-19 11:18 ` Benjamin Tissoires 2015-11-12 16:25 ` [Patch-V2 4/6] HID: hid-logitech-hidpp: Add range sysfs " Simon Wood 2015-11-12 16:25 ` [Patch-V2 5/6] HID: Add vendor specific usage pages " Simon Wood 2015-11-12 16:25 ` [Patch-V2 6/6] HID: hid-logitech-hidpp: G920 remove deadzones Simon Wood 2015-11-12 16:32 ` [Patch-V2 0/6] HID: Support for the Logitech G920 Wheel Simon Wood 2015-11-19 10:04 ` Jiri Kosina 2015-11-19 11:23 ` Benjamin Tissoires
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAKdAkRSBTBTW8ma79hh+0sr4izJ70SnvUb1gmPFy3MoVWYaUbA@mail.gmail.com \ --email@example.com \ --cc=Edwin@velds.nl \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.