From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753982AbcAGWxM (ORCPT ); Thu, 7 Jan 2016 17:53:12 -0500 Received: from mail-ob0-f170.google.com ([209.85.214.170]:35182 "EHLO mail-ob0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753620AbcAGWxK convert rfc822-to-8bit (ORCPT ); Thu, 7 Jan 2016 17:53:10 -0500 MIME-Version: 1.0 In-Reply-To: <1452207016.7572.7.camel@devoid-pointer.net> References: <1447345535-2912-1-git-send-email-simon@mungewell.org> <1447345535-2912-2-git-send-email-simon@mungewell.org> <20151119183106.GC24773@dtor-ws> <20151210170853.GC16026@mail.corp.redhat.com> <20160104095524.GB20222@mail.corp.redhat.com> <20160107014721.GA35823@dtor-ws> <1452207016.7572.7.camel@devoid-pointer.net> Date: Thu, 7 Jan 2016 14:53:09 -0800 Message-ID: Subject: Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel From: Dmitry Torokhov To: =?UTF-8?B?TWljaGFsIE1hbMO9?= Cc: Jiri Kosina , Benjamin Tissoires , Simon Wood , "linux-input@vger.kernel.org" , lkml , Edwin , elias vanderstuyft Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 7, 2016 at 2:50 PM, Michal Malý wrote: > On Wed, 2016-01-06 at 17:47 -0800, Dmitry Torokhov wrote: >> On Wed, Jan 06, 2016 at 03:36:57PM +0100, Jiri Kosina wrote: >> > On Mon, 4 Jan 2016, Benjamin Tissoires wrote: >> > >> > > Jiri, I *think* this commit still is in your next pull request >> > > for >> > > Linus. We might want to drop it before it hits Linus' tree. >> > >> > What exactly would be the reasoning for dropping it? >> >> It is wrong. Aside form the fact that IMO xpad.c is the wrong place >> for >> this code to be in, why are we waiting for the input device to be >> opened by userspace before we do the switch instead of doing it >> immediately? >> > > Hi all, > > I have to disagree with the xpad driver being the wrong place to handle > this. The xpad driver matches devices it should handle by interface > class, subclass and protocol. When G920 first appears on the USB bus, > it for all intents and purposes looks like a Xbox One controller so the > xpad driver picks it up even if there is no G920-specific code in the > driver. Unless there is a way how to blacklist certain idProduct > values, the switch from XBone mode to HID mode will have to be done in > the xpad driver. > > I'm pretty much done with the simple switching module but it will be of > no use if we cannot make the xpad module ignore G920 first. I see that Simon's patch added: XPAD_XBOXONE_VENDOR(0x046d), to the xpad driver. Are you saying that we latch onto the controller even without this addition? Thanks. -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel Date: Thu, 7 Jan 2016 14:53:09 -0800 Message-ID: References: <1447345535-2912-1-git-send-email-simon@mungewell.org> <1447345535-2912-2-git-send-email-simon@mungewell.org> <20151119183106.GC24773@dtor-ws> <20151210170853.GC16026@mail.corp.redhat.com> <20160104095524.GB20222@mail.corp.redhat.com> <20160107014721.GA35823@dtor-ws> <1452207016.7572.7.camel@devoid-pointer.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ob0-f170.google.com ([209.85.214.170]:35182 "EHLO mail-ob0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753620AbcAGWxK convert rfc822-to-8bit (ORCPT ); Thu, 7 Jan 2016 17:53:10 -0500 In-Reply-To: <1452207016.7572.7.camel@devoid-pointer.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: =?UTF-8?B?TWljaGFsIE1hbMO9?= Cc: Jiri Kosina , Benjamin Tissoires , Simon Wood , "linux-input@vger.kernel.org" , lkml , Edwin , elias vanderstuyft On Thu, Jan 7, 2016 at 2:50 PM, Michal Mal=C3=BD wrote: > On Wed, 2016-01-06 at 17:47 -0800, Dmitry Torokhov wrote: >> On Wed, Jan 06, 2016 at 03:36:57PM +0100, Jiri Kosina wrote: >> > On Mon, 4 Jan 2016, Benjamin Tissoires wrote: >> > >> > > Jiri, I *think* this commit still is in your next pull request >> > > for >> > > Linus. We might want to drop it before it hits Linus' tree. >> > >> > What exactly would be the reasoning for dropping it? >> >> It is wrong. Aside form the fact that IMO xpad.c is the wrong place >> for >> this code to be in, why are we waiting for the input device to be >> opened by userspace before we do the switch instead of doing it >> immediately? >> > > Hi all, > > I have to disagree with the xpad driver being the wrong place to hand= le > this. The xpad driver matches devices it should handle by interface > class, subclass and protocol. When G920 first appears on the USB bus, > it for all intents and purposes looks like a Xbox One controller so t= he > xpad driver picks it up even if there is no G920-specific code in the > driver. Unless there is a way how to blacklist certain idProduct > values, the switch from XBone mode to HID mode will have to be done i= n > the xpad driver. > > I'm pretty much done with the simple switching module but it will be = of > no use if we cannot make the xpad module ignore G920 first. I see that Simon's patch added: XPAD_XBOXONE_VENDOR(0x046d), to the xpad driver. Are you saying that we latch onto the controller even without this addition? Thanks. --=20 Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html