From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8329DC4332F for ; Thu, 3 Nov 2022 04:08:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229704AbiKCEIF (ORCPT ); Thu, 3 Nov 2022 00:08:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229600AbiKCEIA (ORCPT ); Thu, 3 Nov 2022 00:08:00 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD1A013D2F; Wed, 2 Nov 2022 21:07:59 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id ud5so2149910ejc.4; Wed, 02 Nov 2022 21:07:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UIsWfbCkFTerxLO9Jkep5pwZTiDKcyfBXjgU1iksCT0=; b=ElwEESMhEGa2sw4P2gh53qMCeCRPfmgPXbU9M69JbGY880u+E3ik20+IB/sUqw/sYK W5IkrCG02DljO77dN4iUv5ziQ4IT22z3CRKxvb3+1KKrwA1Gsd3hL5XkCY4HIcCWPD32 dN7u350I5+xpoZmJOfrMMhI53eMTetNwJwYajTdKIpw1UGMlIttnDYwg8szgZ2lJtQwf nXQ8tKq1mFjCo88jSZoBG2ZoeJ8HS8hkTYQwOydtAStSTGdOTrUrzgYppp8NPtcZUXHc uWSOi5PRc38/gmILf1Vdhz8tgmv8+ivSQU7bLoTwBKkHO6CDH4G9JZ0Bo6UM2AyW57zh 3www== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UIsWfbCkFTerxLO9Jkep5pwZTiDKcyfBXjgU1iksCT0=; b=h3Qp1bvxK0btjzRo4qSVCwCKs7Q4rXjUJveK/U+RiRpY5KjfRDDb0aKAMmmvYMe4xw Ci86QSlxeVqMJryDUkUgTqfkQ/xfClgehrNo9IwrTirCJanXstpWhV8iQRaF8/YVT4nE +sDbWFnWHFzXDJbmjo5aFOz3dzpF6MZovRNlI0gsFa6r4RRtbWKj2I1YSUSnuNp6y6KI mtwvxGHJpL9nlqT8nuzUaiLEZCarFq1WQ5lJJlAXs6CO+SCnJ3BjZfurwGepuNqjs45E SOBU3+Y0x+qElzzO7EHsqb5xcck80RREapmLmcWVdAkHGOmlKLqYXl9OVVOb3JGlB+Ai KkNg== X-Gm-Message-State: ACrzQf1L/8KwaxyVZkYqEGDoY1E00BiAIp80mfU1EyAYdz2LEJL5cK6W etpc8tH9vShB/hu6v5kQxX9P0a8Q7hjJpT9WJwA= X-Google-Smtp-Source: AMsMyM7EowHw/EYtUWBQy6Ou2EamJtzjAwCj+H/BxB5HHl8BGO95RvQ24cnciHOsrjoktw7pTSU2r97iFOyBXW8cDFk= X-Received: by 2002:a17:907:c08:b0:7ad:f758:2899 with SMTP id ga8-20020a1709070c0800b007adf7582899mr9247589ejc.671.1667448478023; Wed, 02 Nov 2022 21:07:58 -0700 (PDT) MIME-Version: 1.0 References: <20221101215804.16262-1-afd@ti.com> <20221101215804.16262-8-afd@ti.com> In-Reply-To: <20221101215804.16262-8-afd@ti.com> From: Dmitry Torokhov Date: Wed, 2 Nov 2022 21:07:45 -0700 Message-ID: Subject: Re: [PATCH v4 7/9] ARM: dts: nspire: Use MATRIX_KEY macro for linux,keymap To: Andrew Davis Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Linus Walleij , Geert Uytterhoeven , Daniel Tang , Fabian Vogt , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, On Tue, Nov 1, 2022 at 2:59 PM Andrew Davis wrote: > > This looks better and allows us to see the row and column numbers > more easily. Switch to this macro here. > > Signed-off-by: Andrew Davis > --- > arch/arm/boot/dts/nspire-clp.dts | 90 ++++++++++++++++++++++++-------- > arch/arm/boot/dts/nspire-cx.dts | 90 ++++++++++++++++++++++++-------- > arch/arm/boot/dts/nspire-tp.dts | 90 ++++++++++++++++++++++++-------- > 3 files changed, 204 insertions(+), 66 deletions(-) > > diff --git a/arch/arm/boot/dts/nspire-clp.dts b/arch/arm/boot/dts/nspire-clp.dts > index f52f38c615886..916ede0c2499c 100644 > --- a/arch/arm/boot/dts/nspire-clp.dts > +++ b/arch/arm/boot/dts/nspire-clp.dts > @@ -6,32 +6,78 @@ > */ > /dts-v1/; > > +#include > + > /include/ "nspire-classic.dtsi" > > &keypad { > linux,keymap = < > - 0x0000001c 0x0001001c 0x00020039 > - 0x0004002c 0x00050034 0x00060015 > - 0x0007000b 0x0008002d 0x01000033 > - 0x0101004e 0x01020011 0x01030004 > - 0x0104002f 0x01050003 0x01060016 > - 0x01070002 0x01080014 0x02000062 > - 0x0201000c 0x0202001f 0x02030007 > - 0x02040013 0x02050006 0x02060010 > - 0x02070005 0x02080019 0x03000027 > - 0x03010037 0x03020018 0x0303000a > - 0x03040031 0x03050009 0x03060032 > - 0x03070008 0x03080026 0x04000028 > - 0x04010035 0x04020025 0x04040024 > - 0x04060017 0x04080023 0x05000028 > - 0x05020022 0x0503001b 0x05040021 > - 0x0505001a 0x05060012 0x0507006f > - 0x05080020 0x0509002a 0x0601001c > - 0x0602002e 0x06030068 0x06040030 > - 0x0605006d 0x0606001e 0x06070001 > - 0x0608002b 0x0609000f 0x07000067 > - 0x0702006a 0x0704006c 0x07060069 > - 0x0707000e 0x0708001d 0x070a000d > + MATRIX_KEY(0, 0, 0x1c) > + MATRIX_KEY(0, 1, 0x1c) > + MATRIX_KEY(0, 2, 0x39) Can this also be switched over to using KEY_* macros to describe the keycodes emitted? Thanks. -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E791BC433FE for ; Thu, 3 Nov 2022 04:09:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H4EWBREq9qDUwDy+jYPiS9iaRGEJJLoFLgAn+XsX6nw=; b=DUL7NVXxh9PI4G oCwXT7voyPDFox3SEl/AawV9WUi2mgxDFT3xbvHcH8/HrDF9oksEOxU5iE3XCOfoIcYo2+XYi6jbw cEIxqE4uewGn3D8aq1ltMR4tvtu9bdHhJJuTx8I9tBrYJ9tU52e2MBm7j3GlQQAZowTrGmLEO+KIa 3z95jh4bBiJGs8pwlT1Mhi+jPTjiPQJnj/FKsWTwSkwZTYyLu9hDvw5LicdPbU8OReIUuk0P2OfHG K4FerFJuE6z34BqrS2z2y/QUXBORpzD4kelRYxwkN5ebP4aUwksOB9E1i8zMlH2PkV9FTU3q68dzR SoZ5Cu5eIKznxJPO/PdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqRWN-00Fxz8-Ta; Thu, 03 Nov 2022 04:08:04 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqRWK-00Fxyi-Ds for linux-arm-kernel@lists.infradead.org; Thu, 03 Nov 2022 04:08:01 +0000 Received: by mail-ej1-x634.google.com with SMTP id 13so2164948ejn.3 for ; Wed, 02 Nov 2022 21:07:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UIsWfbCkFTerxLO9Jkep5pwZTiDKcyfBXjgU1iksCT0=; b=ElwEESMhEGa2sw4P2gh53qMCeCRPfmgPXbU9M69JbGY880u+E3ik20+IB/sUqw/sYK W5IkrCG02DljO77dN4iUv5ziQ4IT22z3CRKxvb3+1KKrwA1Gsd3hL5XkCY4HIcCWPD32 dN7u350I5+xpoZmJOfrMMhI53eMTetNwJwYajTdKIpw1UGMlIttnDYwg8szgZ2lJtQwf nXQ8tKq1mFjCo88jSZoBG2ZoeJ8HS8hkTYQwOydtAStSTGdOTrUrzgYppp8NPtcZUXHc uWSOi5PRc38/gmILf1Vdhz8tgmv8+ivSQU7bLoTwBKkHO6CDH4G9JZ0Bo6UM2AyW57zh 3www== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UIsWfbCkFTerxLO9Jkep5pwZTiDKcyfBXjgU1iksCT0=; b=O+M1XWTT1bhQXaCgpYnitc2vnFYpiIkfAbDC0NO76XKpS3c+gOMosHwNWZhAUtB94d uvDKJeomtlVpsNQAWnwseD4REqQPpIuwqmpnsLyQGpHYCwSC7qgMn5SkXF/MgR45W6Zg 5uZVQxFQODoI1bIlMGMZldrHV9XcSQI0xwc34cJmaSTkEHoR7SccEJbqEJenLhgCEQsO S3i5J4lqWmnjpG8oW/vFh3OMGh1iFOaufzHsaFiipRMEtM3tX/WmJsDkkeAiHe9LreX0 t/lb9zXMOM7oFwfgXMmpKvF8HtmiYyXbUez6vHTM5Bg33Yz9wuOOGPFChKiVGw4AxiX8 m4FA== X-Gm-Message-State: ACrzQf26JgTu9GlRIwdIZEYEYTbJoUV08WQm5BdL22t4pPpgjQmFUHPA 4ge5+R2bQ27YngEzUiZCiBad+JlYp+jhPMrxZa0= X-Google-Smtp-Source: AMsMyM7EowHw/EYtUWBQy6Ou2EamJtzjAwCj+H/BxB5HHl8BGO95RvQ24cnciHOsrjoktw7pTSU2r97iFOyBXW8cDFk= X-Received: by 2002:a17:907:c08:b0:7ad:f758:2899 with SMTP id ga8-20020a1709070c0800b007adf7582899mr9247589ejc.671.1667448478023; Wed, 02 Nov 2022 21:07:58 -0700 (PDT) MIME-Version: 1.0 References: <20221101215804.16262-1-afd@ti.com> <20221101215804.16262-8-afd@ti.com> In-Reply-To: <20221101215804.16262-8-afd@ti.com> From: Dmitry Torokhov Date: Wed, 2 Nov 2022 21:07:45 -0700 Message-ID: Subject: Re: [PATCH v4 7/9] ARM: dts: nspire: Use MATRIX_KEY macro for linux,keymap To: Andrew Davis Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Linus Walleij , Geert Uytterhoeven , Daniel Tang , Fabian Vogt , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221102_210800_506200_18078D06 X-CRM114-Status: GOOD ( 16.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrew, On Tue, Nov 1, 2022 at 2:59 PM Andrew Davis wrote: > > This looks better and allows us to see the row and column numbers > more easily. Switch to this macro here. > > Signed-off-by: Andrew Davis > --- > arch/arm/boot/dts/nspire-clp.dts | 90 ++++++++++++++++++++++++-------- > arch/arm/boot/dts/nspire-cx.dts | 90 ++++++++++++++++++++++++-------- > arch/arm/boot/dts/nspire-tp.dts | 90 ++++++++++++++++++++++++-------- > 3 files changed, 204 insertions(+), 66 deletions(-) > > diff --git a/arch/arm/boot/dts/nspire-clp.dts b/arch/arm/boot/dts/nspire-clp.dts > index f52f38c615886..916ede0c2499c 100644 > --- a/arch/arm/boot/dts/nspire-clp.dts > +++ b/arch/arm/boot/dts/nspire-clp.dts > @@ -6,32 +6,78 @@ > */ > /dts-v1/; > > +#include > + > /include/ "nspire-classic.dtsi" > > &keypad { > linux,keymap = < > - 0x0000001c 0x0001001c 0x00020039 > - 0x0004002c 0x00050034 0x00060015 > - 0x0007000b 0x0008002d 0x01000033 > - 0x0101004e 0x01020011 0x01030004 > - 0x0104002f 0x01050003 0x01060016 > - 0x01070002 0x01080014 0x02000062 > - 0x0201000c 0x0202001f 0x02030007 > - 0x02040013 0x02050006 0x02060010 > - 0x02070005 0x02080019 0x03000027 > - 0x03010037 0x03020018 0x0303000a > - 0x03040031 0x03050009 0x03060032 > - 0x03070008 0x03080026 0x04000028 > - 0x04010035 0x04020025 0x04040024 > - 0x04060017 0x04080023 0x05000028 > - 0x05020022 0x0503001b 0x05040021 > - 0x0505001a 0x05060012 0x0507006f > - 0x05080020 0x0509002a 0x0601001c > - 0x0602002e 0x06030068 0x06040030 > - 0x0605006d 0x0606001e 0x06070001 > - 0x0608002b 0x0609000f 0x07000067 > - 0x0702006a 0x0704006c 0x07060069 > - 0x0707000e 0x0708001d 0x070a000d > + MATRIX_KEY(0, 0, 0x1c) > + MATRIX_KEY(0, 1, 0x1c) > + MATRIX_KEY(0, 2, 0x39) Can this also be switched over to using KEY_* macros to describe the keycodes emitted? Thanks. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel