From: Jason Andryuk <jandryuk@gmail.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>,
QEMU <qemu-devel@nongnu.org>
Subject: Re: [PATCH 1/4] usb-serial: Move USB_TOKEN_IN into a helper function
Date: Mon, 16 Mar 2020 08:05:30 -0400 [thread overview]
Message-ID: <CAKf6xps+Eadf+7U_XhzK9Hw-Xc87sENYcDuM_M199ftuHDFFag@mail.gmail.com> (raw)
In-Reply-To: <20200316114007.a4aie3vszsplkttq@sirius.home.kraxel.org>
On Mon, Mar 16, 2020 at 7:40 AM Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> Hi,
>
> > + if (len > s->recv_used)
> > + len = s->recv_used;
>
> scripts/checkpatch.pl flags a codestyle error here.
>
> > - if (len > s->recv_used)
> > - len = s->recv_used;
>
> Which is strictly speaking not your fault as you are just moving around
> existing code. It's common practice though that codestyle is fixed up
> too when touching code. Any chance you can make sure the patches pass
> checkpatch & resend?
Sure. Will do.
Regards,
Jason
next prev parent reply other threads:[~2020-03-16 14:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 12:55 [PATCH 0/4] usb-serial: xHCI and timeout fixes Jason Andryuk
2020-03-12 12:55 ` [PATCH 1/4] usb-serial: Move USB_TOKEN_IN into a helper function Jason Andryuk
2020-03-13 23:56 ` Samuel Thibault
2020-03-16 11:40 ` Gerd Hoffmann
2020-03-16 12:05 ` Jason Andryuk [this message]
2020-03-12 12:55 ` [PATCH 2/4] usb-serial: chunk data to wMaxPacketSize Jason Andryuk
2020-03-14 0:07 ` Samuel Thibault
2020-03-12 12:55 ` [PATCH 3/4] usb-serial: Increase receive buffer to 496 Jason Andryuk
2020-03-14 21:40 ` Samuel Thibault
2020-03-12 12:55 ` [PATCH 4/4] usb-serial: Fix timeout closing the device Jason Andryuk
2020-03-14 21:41 ` Samuel Thibault
2020-03-12 13:14 ` [PATCH 0/4] usb-serial: xHCI and timeout fixes no-reply
2020-03-12 13:31 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKf6xps+Eadf+7U_XhzK9Hw-Xc87sENYcDuM_M199ftuHDFFag@mail.gmail.com \
--to=jandryuk@gmail.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.