From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08105C433B4 for ; Sat, 10 Apr 2021 15:56:07 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B46E4610A3 for ; Sat, 10 Apr 2021 15:56:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B46E4610A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.108219.206599 (Exim 4.92) (envelope-from ) id 1lVFxW-00079c-Sd; Sat, 10 Apr 2021 15:55:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 108219.206599; Sat, 10 Apr 2021 15:55:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lVFxW-00079V-Oo; Sat, 10 Apr 2021 15:55:42 +0000 Received: by outflank-mailman (input) for mailman id 108219; Sat, 10 Apr 2021 15:55:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lVFxW-00079Q-75 for xen-devel@lists.xenproject.org; Sat, 10 Apr 2021 15:55:42 +0000 Received: from mail-lf1-x131.google.com (unknown [2a00:1450:4864:20::131]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 52d7f38b-acc4-44ef-882b-972ba4c8544e; Sat, 10 Apr 2021 15:55:41 +0000 (UTC) Received: by mail-lf1-x131.google.com with SMTP id b4so14436323lfi.6 for ; Sat, 10 Apr 2021 08:55:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52d7f38b-acc4-44ef-882b-972ba4c8544e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kaurunJOW3GvxHGKNAXvkHbr+QbCN1WTyDCD7fyvilg=; b=l4/uIYoUScHQb+RSKMo1uElfv5F5k2e25cLeUmkBDFbzY9RGOo/hgKJIEwBRzs4QXv BKCk2xHng0rD2GC2qysrImaKsEeSFeSA7YYgdkzLnBNgjFBZ88yPLKvM8Xc59XCJaRkA l9fbWWT7Dluu7YMI7OBXPJsa9ASQH1pi0F/EEzE2+XkmYKHsiUkvK9xCYLErg3Q8ZxHS hLwk1fcCMYhM/COW/cBw8mxbFkRoxWyX7n+HvWAfaMSjiCyjrMj0lGEFsxLhSiVqV0xy fnCMb109Ntx757LbqUFUzK5KzCnINY3GevuJLxbjk5H6LQHsAvPt87q3TRwwSnQfcGCH 2J2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kaurunJOW3GvxHGKNAXvkHbr+QbCN1WTyDCD7fyvilg=; b=WctJWlaZkJqH2GAPEpIKV38GnJQNk7EULm79uNt+1CH4mGt5SHJvdFPl4WlGsSbKyu IgtP4SzxbmOC2HaX1SpGjD5hTvVqLtNxjd7nSE1anr/yh/uQ+VeiBT/3q5sTvcRYrE7m dItEVumBiABQ0YJOvx+lvi34qKkAq5vfi+5mGRrl7mVz/Q4g7aBYPLlYVkcB4+hyjoF8 MxDwGyJyBD2BRYNMQ3tJexdb2PFaAAKxaJBALKW0IaLAdY4nXSwG0RPg268/Nqo9bxCc YRaQNr8wTzCtsIiBbGdWQwghZJzWSJoUJo43Uae27y4qCSXo1lH8CFKJlCW/wJJTFPRK 6Jyg== X-Gm-Message-State: AOAM533qeiyef0lP5njLqfAjjQH3i4siHsrAgQojZAV96M++ssIndJA1 9FtvXfyNjqP10Yecmo5ggwaIbEMlTX+LaqgIxhU= X-Google-Smtp-Source: ABdhPJzE++6vehK1NID/LT8ON6swiSM3wG4HzT2xJH2zRXzDPjGwpR5h4ag77zwxmNnWz6+svA7Hu9dVVYXQHnKRk4A= X-Received: by 2002:a19:c302:: with SMTP id t2mr13508061lff.150.1618070139798; Sat, 10 Apr 2021 08:55:39 -0700 (PDT) MIME-Version: 1.0 References: <602469f5-1028-8f36-7195-f102b6d2af0c@tabit.pro> <427bfd62-48c0-5859-7300-c618331b4e5a@citrix.com> <20200922133047.4646b2ab62cszn46@liuwe-devbox-debian-v2> In-Reply-To: <20200922133047.4646b2ab62cszn46@liuwe-devbox-debian-v2> From: Jason Andryuk Date: Sat, 10 Apr 2021 11:55:28 -0400 Message-ID: Subject: Re: [PATCH] libxl: User defined max_maptrack_frames in a stub domain To: Wei Liu Cc: Andrew Cooper , Dmitry Fedorov , xen-devel , Ian Jackson , Anthony PERARD Content-Type: text/plain; charset="UTF-8" On Tue, Sep 22, 2020 at 9:31 AM Wei Liu wrote: > > On Mon, Sep 14, 2020 at 04:27:45PM +0100, Andrew Cooper wrote: > > On 14/09/2020 15:50, Dmitry Fedorov wrote: > > > Hi, > > > > > > Implementing qrexec+usbip+qemu in Linux-based stub domain leads me to > > > an issue where a device model stub domain doesn't have maptrack entries. > > > > > > Would it be possible to apply a user defined max_maptrack_frames value > > > to dm_config in the same way as for max_grant_frames? > > > > > > Signed-off-by: Dmitry Fedorov > > > > This looks entirely reasonable. > > > > CC'ing the maintainers for their opinion. > > > > Looks fine to me. > > Acked-by: Wei Liu Hi, Wei, looks like you Acked but did not apply this patch. And after the libs rename, the file paths no longer match. Do you want to fix this up, or should Dmitry re-submit? Regards, Jason > > ~Andrew > > > > > --- > > > tools/libxl/libxl_dm.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c > > > index f2dc5696b9..f044f2566c 100644 > > > --- a/tools/libxl/libxl_dm.c > > > +++ b/tools/libxl/libxl_dm.c > > > @@ -2292,7 +2292,7 @@ void libxl__spawn_stub_dm(libxl__egc *egc, > > > libxl__stub_dm_spawn_state *sdss) > > > dm_config->b_info.target_memkb = dm_config->b_info.max_memkb; > > > > > > dm_config->b_info.max_grant_frames = > > > guest_config->b_info.max_grant_frames; > > > - dm_config->b_info.max_maptrack_frames = 0; > > > + dm_config->b_info.max_maptrack_frames = > > > guest_config->b_info.max_maptrack_frames; > > > > > > dm_config->b_info.u.pv.features = ""; > > > > > > -- > > > 2.26.2 > > > > > > > > >