From: Jason Andryuk <jandryuk@gmail.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: sstabellini@kernel.org, Wei Liu <wei.liu2@citrix.com>,
xen-devel@lists.xen.org, julien.grall@arm.com,
Jan Beulich <JBeulich@suse.com>,
roger.pau@citrix.com
Subject: Re: [PATCH v2] xen/vcpu: Rework sanity checks in vcpu_create()
Date: Wed, 12 Sep 2018 07:38:14 -0400 [thread overview]
Message-ID: <CAKf6xpsibcTU7_aXzQk+nRKonSFZf_YQ5npevGyes_j33_x1ZQ@mail.gmail.com> (raw)
In-Reply-To: <1536684371-1417-1-git-send-email-andrew.cooper3@citrix.com>
On Tue, Sep 11, 2018 at 12:48 PM Andrew Cooper
<andrew.cooper3@citrix.com> wrote:
>
> Poisoning idle_vcpu[0] with the sanity debug value isn't actually a clever
> idea, because it passes a NULL pointer check but isn't a usable vcpu. It is
> also the reason for the (!is_idle_domain(d) || vcpu_id) part of the existing
> sanity BUG_ON().
>
> Now that d->max_vcpus is appropriately set up before vcpu_create() is called,
> we can properly range check the requested vcpu_id. Drop the BUG_ON() and
> replace it with code which is runtime safe but non-fatal.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Julien Grall <julien.grall@arm.com>
> CC: Jason Andryuk <jandryuk@gmail.com>
>
> v2:
> * Fix the tboot check following the un-poisioning of idle_vcpu[0]
> * Exclude the idle domain from the next_in_list list, and vastly simplify the
> linking logic.
Reviewed-by: Jason Andryuk <jandryuk@gmail.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-09-12 11:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 19:25 [PATCH 0/3] xen: Improvements to the vcpu create/destroy paths Andrew Cooper
2018-09-06 19:25 ` [PATCH 1/3] xen/vcpu: Rename the common interfaces for consistency Andrew Cooper
2018-09-07 9:52 ` Jan Beulich
2018-09-13 10:29 ` Roger Pau Monné
2018-09-17 1:08 ` Julien Grall
2018-09-06 19:25 ` [PATCH 2/3] xen/vcpu: Introduce vcpu_destroy() Andrew Cooper
2018-09-07 9:53 ` Jan Beulich
2018-09-13 10:32 ` Roger Pau Monné
2018-09-06 19:25 ` [PATCH 3/3] xen/vcpu: Rework sanity checks in vcpu_create() Andrew Cooper
2018-09-06 20:07 ` Jason Andryuk
2018-09-06 23:01 ` Andrew Cooper
2018-09-07 10:15 ` Jan Beulich
2018-09-07 19:17 ` Andrew Cooper
2018-09-11 16:46 ` [PATCH v2] " Andrew Cooper
2018-09-12 11:38 ` Jason Andryuk [this message]
2018-09-12 15:00 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKf6xpsibcTU7_aXzQk+nRKonSFZf_YQ5npevGyes_j33_x1ZQ@mail.gmail.com \
--to=jandryuk@gmail.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.