From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8783CC433E0 for ; Sun, 17 May 2020 14:30:13 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55DAE2070A for ; Sun, 17 May 2020 14:30:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jRONCA69" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55DAE2070A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jaKIG-0003bi-2l; Sun, 17 May 2020 14:29:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jaKIE-0003bd-H4 for xen-devel@lists.xenproject.org; Sun, 17 May 2020 14:29:30 +0000 X-Inumbo-ID: d0fe3d2e-984a-11ea-b9cf-bc764e2007e4 Received: from mail-lf1-x142.google.com (unknown [2a00:1450:4864:20::142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d0fe3d2e-984a-11ea-b9cf-bc764e2007e4; Sun, 17 May 2020 14:29:29 +0000 (UTC) Received: by mail-lf1-x142.google.com with SMTP id a4so5710653lfh.12 for ; Sun, 17 May 2020 07:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sLe9QjRHmo2wHbxFgAhempcBpvA9GW7nyuL0G9e0F84=; b=jRONCA69hkrBtMCzGcdaUC4+SSR7YNf7YbVy8UdxEEpzrqwDQDS2LQopjKIXpl8RLX BCo05Ev/rZWIsWCbKuJcjyIZoRSXlR4FqKV3LFaX/FWAProreyMNNaRaNHJDPELiWVtC yegfdiD853phYRyK9n0Bx3blFT30OfDw829qKxZMowKGKppoU41NJpwEQlbfAkznXxnX jSb0REU1qreo5U8C5+Sjp4KHp++QgytwdQz8JZaNA9CL9Y7zecje3BT6AhetxDyEk0u/ D+3S5lNg/IX1k6648aUdrXJfRrqUDg/mhtw+B08AFzxxViPHJEbRR7QLhDUfKZt54E95 QYTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sLe9QjRHmo2wHbxFgAhempcBpvA9GW7nyuL0G9e0F84=; b=LHuUf8TOFhxKG4EISNiJZkz2WA9HqRH1Cz3V/B5gRwqC/h29OWWY9sSPLuoui/bUyH X8dfVxdiO4wt8jIWHTnijvmPeXJdocl3dDhicvFzwBDG7sfxGj16C6khWVkmCoBIro17 3krltJPTl05mrQFb36d6y8X8Kd1Ocx/zGtv1mSFo4DbObyoU1PFHmkbgT/5+87vX+P7D 2kdC+BEKsx1Mv1K/ijcI1UO+h6MxtaR2oMdRTyay0HPCbOaz+zKYwT7KMF6QZy/QVtSf XF7weW/qUhfAx6l0UGGsJsxbVe+lAst/ThT3nUm0uEQXiMfXRgaIlJxjRPcOK3uDfiAQ 0npg== X-Gm-Message-State: AOAM530NmJLb2eDa+2+1DVcsr2pza/f8NnCZIYVoHg0ZbxJ5I4X//jTg Jibx7TwdJXZ7WOIE3QCB/PF+L0WlEIfk2iZOeeo= X-Google-Smtp-Source: ABdhPJwwJFlHwqPZEA9SglFzpte6WGuUMUZ9KCxv61ADcl/NrjP3dE3ipCsvkBDHAwpFETYNX7RE2wZHgETNlyRrIwM= X-Received: by 2002:ac2:5a11:: with SMTP id q17mr8325254lfn.44.1589725768470; Sun, 17 May 2020 07:29:28 -0700 (PDT) MIME-Version: 1.0 References: <20200428040433.23504-1-jandryuk@gmail.com> <20200428040433.23504-7-jandryuk@gmail.com> <24253.28914.656817.996478@mariner.uk.xensource.com> In-Reply-To: <24253.28914.656817.996478@mariner.uk.xensource.com> From: Jason Andryuk Date: Sun, 17 May 2020 10:29:17 -0400 Message-ID: Subject: Re: [PATCH v5 06/21] libxl: write qemu arguments into separate xenstore keys To: Ian Jackson Content-Type: text/plain; charset="UTF-8" X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony Perard , "xen-devel@lists.xenproject.org" , =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Thu, May 14, 2020 at 12:25 PM Ian Jackson wrote: > > Jason Andryuk writes ("[PATCH v5 06/21] libxl: write qemu arguments into separate xenstore keys"): > > + xs_set_permissions(ctx->xsh, t, GCSPRINTF("%s/rtc/timeoffset", vm_path), roperm, ARRAY_SIZE(roperm)); > > This line seems out of place. At least, it is not mentioned in the > commit message. If it's needed, can you please split it out - and, of > course, then, provide an explanation :-). This was copied over from the mini-os version. It looks like it is unused by qemu-xen, so it can be dropped. Thanks, Jason