From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751844AbcGRPEU (ORCPT ); Mon, 18 Jul 2016 11:04:20 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:33595 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751265AbcGRPES (ORCPT ); Mon, 18 Jul 2016 11:04:18 -0400 MIME-Version: 1.0 In-Reply-To: <1468851242.2280.14.camel@suse.com> References: <1468844691-8222-1-git-send-email-kristian.evensen@gmail.com> <1468846886.2280.6.camel@suse.com> <1468849802.2280.11.camel@suse.com> <1468851242.2280.14.camel@suse.com> From: Kristian Evensen Date: Mon, 18 Jul 2016 17:04:14 +0200 Message-ID: Subject: Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling To: Oliver Neukum Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Network Development Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 18, 2016 at 4:14 PM, Oliver Neukum wrote: >> Ok, sounds good. So far, I have only seen the random MAC issue with >> the three previously mentioned devices, but who knows how many else is >> out there with the same error ... I don't think it should be in the >> core ethernet code, at least not yet, but I agree it would make sense >> to move it to for example usbnet_core(). If you agree, I can prepare a >> patch for it. > > I don't see how it would be specific for a subsystem. If the patch > is correct, it belongs into the networking core. I had a look at some other drivers, and I think we need to be very careful about making setting a random MAC too generic. For example, we might be unlucky and break the possibly_iphdr()-code/assumption in qmi_wwan.c. And there is probably more code/assumptions like that in the network stack. -Kristian From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kristian Evensen Subject: Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Date: Mon, 18 Jul 2016 17:04:14 +0200 Message-ID: References: <1468844691-8222-1-git-send-email-kristian.evensen@gmail.com> <1468846886.2280.6.camel@suse.com> <1468849802.2280.11.camel@suse.com> <1468851242.2280.14.camel@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Network Development To: Oliver Neukum Return-path: In-Reply-To: <1468851242.2280.14.camel-IBi9RG/b67k@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Mon, Jul 18, 2016 at 4:14 PM, Oliver Neukum wrote: >> Ok, sounds good. So far, I have only seen the random MAC issue with >> the three previously mentioned devices, but who knows how many else is >> out there with the same error ... I don't think it should be in the >> core ethernet code, at least not yet, but I agree it would make sense >> to move it to for example usbnet_core(). If you agree, I can prepare a >> patch for it. > > I don't see how it would be specific for a subsystem. If the patch > is correct, it belongs into the networking core. I had a look at some other drivers, and I think we need to be very careful about making setting a random MAC too generic. For example, we might be unlucky and break the possibly_iphdr()-code/assumption in qmi_wwan.c. And there is probably more code/assumptions like that in the network stack. -Kristian -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html