From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D46EC43219 for ; Thu, 2 May 2019 08:10:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 09C5920675 for ; Thu, 2 May 2019 08:10:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AnVCujeH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726425AbfEBIKM (ORCPT ); Thu, 2 May 2019 04:10:12 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:33411 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725951AbfEBIKM (ORCPT ); Thu, 2 May 2019 04:10:12 -0400 Received: by mail-io1-f65.google.com with SMTP id u12so1349486iop.0; Thu, 02 May 2019 01:10:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1acnK496SFJqTcJMu4CgJboDMAM5s/xPYYQtkQ45aN8=; b=AnVCujeHG0QwQ6IQWU4rQK93qOOulRI+GOQ092QYKEZFXmLjwQPSy2Wt/lYL7W4iO3 uxFQF6kNHqiYRfFliULe1vq445mV09l95jlj8zldOLt2XZLNyL1DxJEMLn5BdHJJ1McE JtSAqbuBYHuwf+tD0m3FMT1eI900/oGu8RNWDY/Y+quF2IhBMaYNtZniB+TOO4GsV3PE GP2MfVYjtI/SCWZAYucetffFSEk5OUVNlTyrLt/037OTRB6ryVM+7IVDc2e0HdL476MD 8NjegW6RrSbRqAlDz7PCvHyG+qf2iJaJRslC3IvSP14tvfTxT2Uq0a0B7/RUzpZxEvaO tWkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1acnK496SFJqTcJMu4CgJboDMAM5s/xPYYQtkQ45aN8=; b=AiLkYeO0ZJIykdL8oPRK5opiXcKtZ8AjRuRWRvdWQQM54ysVLIZdhMo5+3/Y+qZ4to Pp+9fBJuXXx3xV0BeAyTXB9rsNgKeHSZmkMLJ2dzhp6NF/QEF6QW1b23ffshOW3YlRWX wkqITY46ww25rSowKdBZJ2jDFkDAR1qaiWzFaIPdy21Ob93tWCtHQHXEQHaR4iw+KXl8 dW5U7kQNRuHPpCyovPq4FuUJgw+74oTBjh4yg5wawtDraazQK1WIlWHaeIGhd8mEaXg4 2XDAwHiFuxGjHJT1RAFXBgMFgQkmS0EEVizjYdTi+vGPZ0jdIexHzdFMVUnRHhoOLZHP WYjg== X-Gm-Message-State: APjAAAWmU3Ko8DzyVcII6z5OCKmZfPzOoDRr8O+8dSpSBl2Yd7IBhOG6 Ln5iyUoVU71t+YiRlVziQ67fD3pzCxEeyQYIRM8yNRJa X-Google-Smtp-Source: APXvYqyFWr7co3ZF6R+WngPwGiLaUWThwG12s2McXPeOJZYi49KU2GgsCJRWXCdxdJLnyHSHc9dzvyQiK3wIdLYafFQ= X-Received: by 2002:a6b:c842:: with SMTP id y63mr1623521iof.304.1556784611433; Thu, 02 May 2019 01:10:11 -0700 (PDT) MIME-Version: 1.0 References: <20181008230125.2330-1-pablo@netfilter.org> <20181008230125.2330-8-pablo@netfilter.org> <33d60747-7550-1fba-a068-9b78aaedbc26@6wind.com> <51b7d27b-a67e-e3c6-c574-01f50a860a5c@6wind.com> <20190502074642.ph64t7uax73xuxeo@breakpoint.cc> In-Reply-To: <20190502074642.ph64t7uax73xuxeo@breakpoint.cc> From: Kristian Evensen Date: Thu, 2 May 2019 10:09:56 +0200 Message-ID: Subject: Re: [PATCH 07/31] netfilter: ctnetlink: Support L3 protocol-filter on flush To: Florian Westphal Cc: Nicolas Dichtel , Pablo Neira Ayuso , Netfilter Development Mailing list , David Miller , Network Development Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, On Thu, May 2, 2019 at 9:46 AM Florian Westphal wrote: > > Nicolas Dichtel wrote: > > I understand your point, but this is a regression. Ignoring a field/attribute of > > a netlink message is part of the uAPI. This field exists for more than a decade > > (probably two), so you cannot just use it because nobody was using it. Just see > > all discussions about strict validation of netlink messages. > > Moreover, the conntrack tool exists also for ages and is an official tool. > > FWIW I agree with Nicolas, we should restore old behaviour and flush > everything when AF_INET is given. We can add new netlink attr to > restrict this. I agree with both of you. Unless anyone beats me to it, I will try to have a fix ready during the weekend. BR, Kristian