From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shubhrajyoti Datta Subject: Re: [PATCH] gpio: Added zynq specific check for special pins on bank zero Date: Wed, 21 Sep 2016 15:26:25 +0530 Message-ID: References: <1474360324-8168-1-git-send-email-navam@xilinx.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1474360324-8168-1-git-send-email-navam@xilinx.com> Sender: linux-kernel-owner@vger.kernel.org To: Nava kishore Manne Cc: linus.walleij@linaro.org, gnurou@gmail.com, Michal Simek , =?UTF-8?Q?S=C3=B6ren_Brinkmann?= , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Nava kishore Manne List-Id: linux-gpio@vger.kernel.org On Tue, Sep 20, 2016 at 2:02 PM, Nava kishore Manne wrote: > From: Nava kishore Manne > > This patch adds zynq specific check for bank 0 pins 7 and 8 > are special and cannot be used as inputs Is there any such pins for zynqmp? > > Signed-off-by: Nava kishore Manne > --- > drivers/gpio/gpio-zynq.c | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c > index e72794e..eae9d24 100644 > --- a/drivers/gpio/gpio-zynq.c > +++ b/drivers/gpio/gpio-zynq.c > @@ -96,6 +96,10 @@ > /* GPIO upper 16 bit mask */ > #define ZYNQ_GPIO_UPPER_MASK 0xFFFF0000 > > +/* For GPIO quirks */ > +#define ZYNQ_GPIO BIT(0) > +#define ZYNQMP_GPIO BIT(1) if not can we remove ZYNQMP_GPIO ? From mboxrd@z Thu Jan 1 00:00:00 1970 From: shubhrajyoti.datta@gmail.com (Shubhrajyoti Datta) Date: Wed, 21 Sep 2016 15:26:25 +0530 Subject: [PATCH] gpio: Added zynq specific check for special pins on bank zero In-Reply-To: <1474360324-8168-1-git-send-email-navam@xilinx.com> References: <1474360324-8168-1-git-send-email-navam@xilinx.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Sep 20, 2016 at 2:02 PM, Nava kishore Manne wrote: > From: Nava kishore Manne > > This patch adds zynq specific check for bank 0 pins 7 and 8 > are special and cannot be used as inputs Is there any such pins for zynqmp? > > Signed-off-by: Nava kishore Manne > --- > drivers/gpio/gpio-zynq.c | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c > index e72794e..eae9d24 100644 > --- a/drivers/gpio/gpio-zynq.c > +++ b/drivers/gpio/gpio-zynq.c > @@ -96,6 +96,10 @@ > /* GPIO upper 16 bit mask */ > #define ZYNQ_GPIO_UPPER_MASK 0xFFFF0000 > > +/* For GPIO quirks */ > +#define ZYNQ_GPIO BIT(0) > +#define ZYNQMP_GPIO BIT(1) if not can we remove ZYNQMP_GPIO ?