From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5B32C43387 for ; Thu, 10 Jan 2019 07:50:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8F08420685 for ; Thu, 10 Jan 2019 07:50:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="E7OrjCFE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727447AbfAJHu1 (ORCPT ); Thu, 10 Jan 2019 02:50:27 -0500 Received: from mail-it1-f174.google.com ([209.85.166.174]:53055 "EHLO mail-it1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727331AbfAJHu1 (ORCPT ); Thu, 10 Jan 2019 02:50:27 -0500 Received: by mail-it1-f174.google.com with SMTP id g76so15956197itg.2 for ; Wed, 09 Jan 2019 23:50:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=INsuntaXfrMFs/lZatoLWmlxRSavmXUczoK2TVglobY=; b=E7OrjCFEJq8T8axZB71vgTBwGx0iXgPBDIbVSDnOEicYpGCoHnRxB2GkQlHfgmAgTf Bf3SME3JPZiSPVMtnzCHUCFFuBYDep6oVLjBfFEnLcTQPKG0JUlqc66nyleBmkoeHfBF h9GztOacO/FKr35cLTQyEZwv0zbGafTDRnjJo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=INsuntaXfrMFs/lZatoLWmlxRSavmXUczoK2TVglobY=; b=GKqh9sS6Rf+tr8BJOrQP9rmKC5vYa/TFEDRghozyMw0E0WUfMOnkP6zsueUuU2MBiM LX0H2V1MpuCHlMCyGWEo2pSUIztTaMXhstc+BbDRZkrOw/M8/L5pI2/KX60LZ4+oITj3 wXZSoANNRwAts7lNt5EWFnMycMGztZTxHGZ2VOQeSV12NE2Vp6YSnvdlFLNIfSCYeQM6 +2RllXdreQgxMidN+PKtNoJDmMdZSNGe6EG/NVyfEg0j/+YmrrsVyfykSM8qxlhgt6uN f71pnZyLdLNo67U0MrYh5vJ8lqgETwKs/sSMHGbBD2SMH4Q8+aQX8je5AnA6+PUW8Beg 61bg== X-Gm-Message-State: AJcUukfeacCkdPXovDXgxKESofHevK3012HSgCvNW4VLlJMGQ2aYMdeW 2Xr+MpUwuIoQkWq+mTfLuytKGA/vdE8qwcv+9IuxOA== X-Google-Smtp-Source: ALg8bN4TcGwpGoI5T7NASo4ym68M5QmJe5bQFZZ+whlwbCspbnHFBlpTJ/9YnPxnoJyriFVS23hu4/KDApVQp0zfYC8= X-Received: by 2002:a24:a20e:: with SMTP id j14mr6582694itf.14.1547106625983; Wed, 09 Jan 2019 23:50:25 -0800 (PST) MIME-Version: 1.0 References: <20190109115824.GA1353@lenoch> <20190109133337.GA13579@lenoch> <20190109160736.GA7416@lenoch> <20190109172623.GB1711@lenoch> <20190110074558.GA26167@lenoch> In-Reply-To: <20190110074558.GA26167@lenoch> From: Vincent Guittot Date: Thu, 10 Jan 2019 08:50:14 +0100 Message-ID: Subject: Re: Regression in v5.0-rc1 with autosuspend hrtimers To: Ladislav Michl Cc: "Rafael J. Wysocki" , Tony Lindgren , "Rafael J. Wysocki" , Ulf Hansson , "open list:THERMAL" , linux-kernel , LAK , Linux OMAP Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Jan 2019 at 08:46, Ladislav Michl wrote: > > On Wed, Jan 09, 2019 at 11:06:34PM +0100, Rafael J. Wysocki wrote: > > On Wed, Jan 9, 2019 at 7:05 PM Vincent Guittot > > wrote: > > > > > > On Wed, 9 Jan 2019 at 18:26, Ladislav Michl wrote: > > > > > > > > On Wed, Jan 09, 2019 at 05:32:31PM +0100, Vincent Guittot wrote: > > > > > On Wed, 9 Jan 2019 at 17:07, Ladislav Michl wrote: > > > > > > > > > > > > On Wed, Jan 09, 2019 at 03:12:25PM +0100, Vincent Guittot wrote: > > > > > > > Please keep all thread list when replying :-) > > > > > > > > > > > > Ahh, sorry for that... > > > > > > [snip] > > > > > > > On Wed, 9 Jan 2019 at 14:33, Ladislav Michl wrote: > > > > > > > > I agree, but it doea all the magic correctly, so you won't need > > > > > > > > to touch that code is ktime_t changes (I know, unlikely..) > > > > > > > > > > > > > > But the current implementation doesn't care of any changes in ktime_t > > > > > > > as it uses raw ns > > > > > > > > > > > > Fair enough, so let's go back to: > > > > > > > > > > This one looks good for me > > > > > > > > Lets split is for 'comments fix' patch, which was just send and 'the rest'. > > > > Now, 'the rest' can either be v2 of your "PM/runtime: Fix autosuspend_delay on > > > > 32bits arch" or will wait for 5.1. You decide :) > > > > > > I don't really mind. > > > > > > Rafael, > > > Do you prefer to only take the fix for u64 casting problem or do you > > > prefer to also take the optimization below in one single patch ? > > > > The casting problem is a bug and the optimization is next release > > material in my view. Please send the optimization separately. > > Ok, will send that separately in a few moments... > Btw, u64 casting problem seems to be still present in rpm_suspend while > computing slack for autosuspend delay greater than 25% of 2^31 (2^33) ns. Good point. I will add it to the fix as well > Not sure if that triggers any real bug. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05430C43387 for ; Thu, 10 Jan 2019 07:50:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C45C620685 for ; Thu, 10 Jan 2019 07:50:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UVQ/F0l7"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="E7OrjCFE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C45C620685 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/+opZ/ueX9z2R8Ksjg3iKwYz8bzxjR2aBxFBoqBZeEQ=; b=UVQ/F0l77L6/xu 4NRgEKip1L1rbxFoeVR1GrOyGecCq9qyBhCSGpyBoIV8YcPNBcNbiaUVpxnmLMSZny8xUiK4oBRKJ I7M/g2TBDTPREWaiNh2YuiAXUvPMIIv4hfOI3K7USXieZFxQcDCY9TDEu5DKk48Ag+TTw0rrYMX4l 0NfVOjQn1VMWrYmeCry7WsAigHt1tnA/63LtBOGlxhM23IOXdNuR9IHIKwVKFtUUKsHOQSqpMqggb 19OBCKaJjDHfQkmn7z7T0QqJ4W2RuzFUBZERJi+P85ZHQ/fLcvinTyYk390eDnVoEA7lemDR/B1N3 bXMSq81Iv5P+tiCiIq8A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghV6k-0002sc-CL; Thu, 10 Jan 2019 07:50:30 +0000 Received: from mail-it1-x136.google.com ([2607:f8b0:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghV6h-0002rq-AG for linux-arm-kernel@lists.infradead.org; Thu, 10 Jan 2019 07:50:28 +0000 Received: by mail-it1-x136.google.com with SMTP id g85so15949132ita.3 for ; Wed, 09 Jan 2019 23:50:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=INsuntaXfrMFs/lZatoLWmlxRSavmXUczoK2TVglobY=; b=E7OrjCFEJq8T8axZB71vgTBwGx0iXgPBDIbVSDnOEicYpGCoHnRxB2GkQlHfgmAgTf Bf3SME3JPZiSPVMtnzCHUCFFuBYDep6oVLjBfFEnLcTQPKG0JUlqc66nyleBmkoeHfBF h9GztOacO/FKr35cLTQyEZwv0zbGafTDRnjJo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=INsuntaXfrMFs/lZatoLWmlxRSavmXUczoK2TVglobY=; b=llG7VxRlTWKm8tZWGoesaucxT4RkVOy9YzEnoP64WOJaCneAzvlfjPMfA1ezWPbcR+ RnVDOS7Aa6yQDlueX08yWmz+GAIt5f1mVV+BKA0eo/qZt+oHHt/UX/iqNY/pkaQdVz48 V521+hWZVU//T8fBDVBd1d9bjqspn4EI5B2/WvKniicGLk+QZvLt2dfTUXAHRiitpIib ysugJFfQpzy7m57qRTb7a8GLxDEl7xj+nr5smjd/ima0osOPJQ1kwHCt4RUym3FFOni3 uFXzV5OgaosWEHBmg1Icp38z67Ns/wyMOz4mXIIyV0yARIq3gbmo74AfJNAbLJtAeqzP LOvA== X-Gm-Message-State: AJcUukevcjYUBUtcvamAbOEUIw9PW+MxRyPbjI/8+VxbJHDXXpzFkxWq XGYdJzHg5W9erV2HtcJUDlARB9p5h8rrDiNUmAYsvA== X-Google-Smtp-Source: ALg8bN4TcGwpGoI5T7NASo4ym68M5QmJe5bQFZZ+whlwbCspbnHFBlpTJ/9YnPxnoJyriFVS23hu4/KDApVQp0zfYC8= X-Received: by 2002:a24:a20e:: with SMTP id j14mr6582694itf.14.1547106625983; Wed, 09 Jan 2019 23:50:25 -0800 (PST) MIME-Version: 1.0 References: <20190109115824.GA1353@lenoch> <20190109133337.GA13579@lenoch> <20190109160736.GA7416@lenoch> <20190109172623.GB1711@lenoch> <20190110074558.GA26167@lenoch> In-Reply-To: <20190110074558.GA26167@lenoch> From: Vincent Guittot Date: Thu, 10 Jan 2019 08:50:14 +0100 Message-ID: Subject: Re: Regression in v5.0-rc1 with autosuspend hrtimers To: Ladislav Michl X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190109_235027_360731_5434FC41 X-CRM114-Status: GOOD ( 18.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , "open list:THERMAL" , Tony Lindgren , "Rafael J. Wysocki" , linux-kernel , "Rafael J. Wysocki" , Linux OMAP Mailing List , LAK Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 10 Jan 2019 at 08:46, Ladislav Michl wrote: > > On Wed, Jan 09, 2019 at 11:06:34PM +0100, Rafael J. Wysocki wrote: > > On Wed, Jan 9, 2019 at 7:05 PM Vincent Guittot > > wrote: > > > > > > On Wed, 9 Jan 2019 at 18:26, Ladislav Michl wrote: > > > > > > > > On Wed, Jan 09, 2019 at 05:32:31PM +0100, Vincent Guittot wrote: > > > > > On Wed, 9 Jan 2019 at 17:07, Ladislav Michl wrote: > > > > > > > > > > > > On Wed, Jan 09, 2019 at 03:12:25PM +0100, Vincent Guittot wrote: > > > > > > > Please keep all thread list when replying :-) > > > > > > > > > > > > Ahh, sorry for that... > > > > > > [snip] > > > > > > > On Wed, 9 Jan 2019 at 14:33, Ladislav Michl wrote: > > > > > > > > I agree, but it doea all the magic correctly, so you won't need > > > > > > > > to touch that code is ktime_t changes (I know, unlikely..) > > > > > > > > > > > > > > But the current implementation doesn't care of any changes in ktime_t > > > > > > > as it uses raw ns > > > > > > > > > > > > Fair enough, so let's go back to: > > > > > > > > > > This one looks good for me > > > > > > > > Lets split is for 'comments fix' patch, which was just send and 'the rest'. > > > > Now, 'the rest' can either be v2 of your "PM/runtime: Fix autosuspend_delay on > > > > 32bits arch" or will wait for 5.1. You decide :) > > > > > > I don't really mind. > > > > > > Rafael, > > > Do you prefer to only take the fix for u64 casting problem or do you > > > prefer to also take the optimization below in one single patch ? > > > > The casting problem is a bug and the optimization is next release > > material in my view. Please send the optimization separately. > > Ok, will send that separately in a few moments... > Btw, u64 casting problem seems to be still present in rpm_suspend while > computing slack for autosuspend delay greater than 25% of 2^31 (2^33) ns. Good point. I will add it to the fix as well > Not sure if that triggers any real bug. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel