From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85544C43387 for ; Mon, 7 Jan 2019 14:04:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CEAE206BB for ; Mon, 7 Jan 2019 14:04:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="IUF9xpEJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728062AbfAGOEJ (ORCPT ); Mon, 7 Jan 2019 09:04:09 -0500 Received: from mail-it1-f195.google.com ([209.85.166.195]:38435 "EHLO mail-it1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726589AbfAGOEI (ORCPT ); Mon, 7 Jan 2019 09:04:08 -0500 Received: by mail-it1-f195.google.com with SMTP id h65so1096088ith.3 for ; Mon, 07 Jan 2019 06:04:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=G1G3UqNIUgpa+idTCbCb/BcNx+wY+IKRFXkMCPa6akg=; b=IUF9xpEJlrC/Dmd6eBobXW/p4QTOST3tzwou5pLy5dcrykoNxKSRcidRIZ1F0bfuIC Q0ct3V1exhrRSAsYlM39IfvRx/RqrhLjGZM+EHu9lvVMj+Fu0PuJ1uQcKWkebEonAk1d P8udVGCs5PAyTW+eu5+oMD6KXpCYGCh5ecDME= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G1G3UqNIUgpa+idTCbCb/BcNx+wY+IKRFXkMCPa6akg=; b=k0HCVBar61Igp0bpBYxlzSNK92wfBQT9v45K65c/nTSCJ9Ng/4wkjK/+2qmt+5RZ0v 2V4JtSnwSQxnYROIcwmkj/7FM8Q7jDiZBP89gnKWoX9bDr61qYFA0UtQyFUhgFdzaZYZ /GaKIbMsUjcRNYxKG1dU6ccYLtCROge2FcRGySLxOGql+0XGtipadwo5WXQgqXAGquBG mLWVU+AsFzxGMVrBfYuVpMgur21thCNvBrYClVziRJpkPU7SfANhqm6OtloH9joxIOli t20p5GQglkSYdTZPZL+BRDH9FFKncXQmwB9pp+SbjGrdT9kG6XS+VPBD4ljzyIbdyWPl XCdA== X-Gm-Message-State: AA+aEWYoEMGhVaoWEnebjaTje2sye8K/IuIdIb41IInNENz20sAm+gHj 2UCcQSKAzSd0RC7Bd07YfzxO93qn4YA/w7SzoFz7dw== X-Google-Smtp-Source: AFSGD/USQJ0YSerNBc6Ucfy3We0y+ijp1wygn3Kb6IZD3VT/nBFU0rk1ZJHRQOlY0eY6K1J8cXG+9f9YXoMVOYc9B74= X-Received: by 2002:a02:98d2:: with SMTP id c18mr38448187jak.11.1546869846859; Mon, 07 Jan 2019 06:04:06 -0800 (PST) MIME-Version: 1.0 References: <1545388436-7489-1-git-send-email-vincent.guittot@linaro.org> <1545388436-7489-3-git-send-email-vincent.guittot@linaro.org> In-Reply-To: From: Vincent Guittot Date: Mon, 7 Jan 2019 15:03:55 +0100 Message-ID: Subject: Re: [Intel-gfx] [PATCH v5 2/3] drm/i915: Move on the new pm runtime interface To: Tvrtko Ursulin Cc: "open list:THERMAL" , linux-kernel , "Rafael J. Wysocki" , Thara Gopinath , Jani Nikula , Joonas Lahtinen , rodrigo.vivi@intel.com, David Airlie , "Intel graphics driver community testing & development" , dri-devel , Ulf Hansson Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tvrtko, On Mon, 31 Dec 2018 at 13:32, Tvrtko Ursulin wrote: > > > On 21/12/2018 13:26, Vincent Guittot wrote: > > On Fri, 21 Dec 2018 at 12:33, Tvrtko Ursulin [snip] > >> > >> If it is always monotonic, then worst case we report one wrong sample, > >> which I guess is still not ideal since someone could be querying the PMU > >> with quite low frequency. > >> > >> There are tests which probably can hit this, but to run them > >> automatically your patches would need to be rebased on drm-tip and maybe > >> sent to our trybot. I can do that after the holiday break if you are > >> okay with having the series waiting until then. > > > > yes looks good to me > > Looks good to me as well. And our CI agrees with it. So: > > Reviewed-by: Tvrtko Ursulin Thanks for the review and the test > > I assume you will take the patch through some power related tree and we > will eventually pull it back to drm-tip. Rafael, How do you want to proceed with this patch and the 2 others of the serie ? Regards, Vincent > > Regards, > > Tvrtko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent Guittot Subject: Re: [Intel-gfx] [PATCH v5 2/3] drm/i915: Move on the new pm runtime interface Date: Mon, 7 Jan 2019 15:03:55 +0100 Message-ID: References: <1545388436-7489-1-git-send-email-vincent.guittot@linaro.org> <1545388436-7489-3-git-send-email-vincent.guittot@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tvrtko Ursulin Cc: Ulf Hansson , dri-devel , "open list:THERMAL" , David Airlie , Intel graphics driver community testing & development , "Rafael J. Wysocki" , linux-kernel , Thara Gopinath , rodrigo.vivi@intel.com List-Id: linux-pm@vger.kernel.org SGkgVHZydGtvLAoKT24gTW9uLCAzMSBEZWMgMjAxOCBhdCAxMzozMiwgVHZydGtvIFVyc3VsaW4K PHR2cnRrby51cnN1bGluQGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4KPgo+IE9uIDIxLzEyLzIw MTggMTM6MjYsIFZpbmNlbnQgR3VpdHRvdCB3cm90ZToKPiA+IE9uIEZyaSwgMjEgRGVjIDIwMTgg YXQgMTI6MzMsIFR2cnRrbyBVcnN1bGluCgpbc25pcF0KCj4gPj4KPiA+PiBJZiBpdCBpcyBhbHdh eXMgbW9ub3RvbmljLCB0aGVuIHdvcnN0IGNhc2Ugd2UgcmVwb3J0IG9uZSB3cm9uZyBzYW1wbGUs Cj4gPj4gd2hpY2ggSSBndWVzcyBpcyBzdGlsbCBub3QgaWRlYWwgc2luY2Ugc29tZW9uZSBjb3Vs ZCBiZSBxdWVyeWluZyB0aGUgUE1VCj4gPj4gd2l0aCBxdWl0ZSBsb3cgZnJlcXVlbmN5Lgo+ID4+ Cj4gPj4gVGhlcmUgYXJlIHRlc3RzIHdoaWNoIHByb2JhYmx5IGNhbiBoaXQgdGhpcywgYnV0IHRv IHJ1biB0aGVtCj4gPj4gYXV0b21hdGljYWxseSB5b3VyIHBhdGNoZXMgd291bGQgbmVlZCB0byBi ZSByZWJhc2VkIG9uIGRybS10aXAgYW5kIG1heWJlCj4gPj4gc2VudCB0byBvdXIgdHJ5Ym90LiBJ IGNhbiBkbyB0aGF0IGFmdGVyIHRoZSBob2xpZGF5IGJyZWFrIGlmIHlvdSBhcmUKPiA+PiBva2F5 IHdpdGggaGF2aW5nIHRoZSBzZXJpZXMgd2FpdGluZyB1bnRpbCB0aGVuLgo+ID4KPiA+IHllcyBs b29rcyBnb29kIHRvIG1lCj4KPiBMb29rcyBnb29kIHRvIG1lIGFzIHdlbGwuIEFuZCBvdXIgQ0kg YWdyZWVzIHdpdGggaXQuIFNvOgo+Cj4gUmV2aWV3ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0 a28udXJzdWxpbkBpbnRlbC5jb20+CgpUaGFua3MgZm9yIHRoZSByZXZpZXcgYW5kIHRoZSB0ZXN0 Cgo+Cj4gSSBhc3N1bWUgeW91IHdpbGwgdGFrZSB0aGUgcGF0Y2ggdGhyb3VnaCBzb21lIHBvd2Vy IHJlbGF0ZWQgdHJlZSBhbmQgd2UKPiB3aWxsIGV2ZW50dWFsbHkgcHVsbCBpdCBiYWNrIHRvIGRy bS10aXAuCgpSYWZhZWwsCkhvdyBkbyB5b3Ugd2FudCB0byBwcm9jZWVkIHdpdGggdGhpcyBwYXRj aCBhbmQgdGhlIDIgb3RoZXJzIG9mIHRoZSBzZXJpZSA/CgpSZWdhcmRzLApWaW5jZW50Cgo+Cj4g UmVnYXJkcywKPgo+IFR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK