All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincent Guittot <vincent.guittot@linaro.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Mel Gorman <mgorman@suse.de>, Doug Smythies <dsmythies@telus.net>,
	"open list:THERMAL" <linux-pm@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Sargun Dhillon <sargun@sargun.me>, Tejun Heo <tj@kernel.org>,
	Xie XiuQi <xiexiuqi@huawei.com>,
	xiezhipeng1@huawei.com,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: Re: [PATCH v4] sched/freq: move call to cpufreq_update_util
Date: Fri, 15 Nov 2019 12:03:31 +0100	[thread overview]
Message-ID: <CAKfTPtC3g4iCxvAJo9Km9fZ0fPSw5Jt9TY2+xF7kxGmOZ66gxw@mail.gmail.com> (raw)
In-Reply-To: <20191115105110.GG4131@hirez.programming.kicks-ass.net>

On Fri, 15 Nov 2019 at 11:51, Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Fri, Nov 15, 2019 at 11:46:01AM +0100, Vincent Guittot wrote:
> > On Fri, 15 Nov 2019 at 11:37, Peter Zijlstra <peterz@infradead.org> wrote:
>
> > > Sure, but then it can still remember the value passed in last and use
> > > that state later.
> > >
> > > It doesn't _have_ to completely discard values.
> >
> > yes but it means that we run at the "wrong" frequency during this
> > period and also that the cpufreq must in this case set a kind of timer
> > to resubmit a new frequency change out of scheduler event
>
> But if, as you say, we're completely shutting down the event stream
> when everything has decayed, that's still true, right?

But It doesn't because there is nothing else to do.

This patch does 2 things:
- fix the spurious call to cpufreq just before attaching a task
- make sure cpufreq is still called when cfs is 0 but not irq/rt or dl

There are somehow related but not fully

  reply	other threads:[~2019-11-15 11:03 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-14 17:07 [PATCH v4] sched/freq: move call to cpufreq_update_util Vincent Guittot
2019-11-15  9:54 ` Peter Zijlstra
2019-11-15 10:03   ` Rafael J. Wysocki
2019-11-15 10:40     ` Peter Zijlstra
2019-11-15 11:05       ` Vincent Guittot
2019-11-15 10:18   ` Vincent Guittot
2019-11-15 10:29     ` Vincent Guittot
2019-11-15 11:59       ` Vincent Guittot
2019-11-15 12:25         ` Vincent Guittot
2019-11-15 10:37     ` Peter Zijlstra
2019-11-15 10:46       ` Vincent Guittot
2019-11-15 10:51         ` Peter Zijlstra
2019-11-15 11:03           ` Vincent Guittot [this message]
2019-11-15 11:56             ` Peter Zijlstra
2019-11-15 13:01             ` Peter Zijlstra
2019-11-15 13:30               ` Vincent Guittot
2019-11-15 13:46                 ` Peter Zijlstra
2019-11-15 15:30               ` Doug Smythies
2019-11-15 10:51         ` Rafael J. Wysocki
2019-11-15 12:17         ` Peter Zijlstra
2019-11-15 11:46 ` Rafael J. Wysocki
2019-11-15 13:25 ` Peter Zijlstra
2019-11-15 13:37   ` Vincent Guittot
2019-11-15 14:05     ` Peter Zijlstra
2019-11-15 14:12       ` Vincent Guittot
2019-11-15 15:12     ` Peter Zijlstra
2019-11-15 15:31       ` Vincent Guittot
2019-11-15 17:43         ` Peter Zijlstra
2019-11-15 18:00           ` Vincent Guittot
2019-11-15 20:12             ` Peter Zijlstra
2019-11-15 21:52 ` Peter Zijlstra
2019-11-16  8:47   ` Vincent Guittot
2019-11-16 15:07     ` Doug Smythies

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKfTPtC3g4iCxvAJo9Km9fZ0fPSw5Jt9TY2+xF7kxGmOZ66gxw@mail.gmail.com \
    --to=vincent.guittot@linaro.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=dsmythies@telus.net \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sargun@sargun.me \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=xiexiuqi@huawei.com \
    --cc=xiezhipeng1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.