From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C26CDC433EF for ; Fri, 17 Sep 2021 15:27:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3965610C7 for ; Fri, 17 Sep 2021 15:27:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237066AbhIQP2u (ORCPT ); Fri, 17 Sep 2021 11:28:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233835AbhIQP2t (ORCPT ); Fri, 17 Sep 2021 11:28:49 -0400 Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11E80C061574 for ; Fri, 17 Sep 2021 08:27:27 -0700 (PDT) Received: by mail-qk1-x734.google.com with SMTP id a10so18549465qka.12 for ; Fri, 17 Sep 2021 08:27:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=w+tQ/PU9p2iYa5juxC+5TIx7gu+WxD4o31x+e5MbNAc=; b=wZvzXvDFoJxniSSZ1sP1OHE+iQIl14sDSSGD9RuI3YPPIvxu68inmiOiFQy/hbH2rc ByJxsWbm0dS5/qUBy5yvIn4xCBq7APq+I69B12S+nG+ozBstaNrLdlWhcYS485dyQRXH XD2oO0iNEWppR796Rx3BSQyHK3s/tC7qXkNy80RPUptucgzHKOLQsplduEITsgfxGpY5 A1TgLXvcwwteseOe6s8PgD2KDm3er4KluD0U4NDIVhwu4C4gY8b2v8bUbO2p8ZYJZwEz VQwHBTBmPiYebOPnGdT7dVN55Pl7fkz/RW/xHL9Mhp8Iblg1F+pjIH8BSaDFt7AQeqAN +VxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w+tQ/PU9p2iYa5juxC+5TIx7gu+WxD4o31x+e5MbNAc=; b=SSpx2K70Ytn3GvFYslpVgNlITOORHbr5I3sY8iRlnG1xgeFZUeNWnRd9s9ch8+OlbE CYOF5308Nzklg4CyEGEE+Gn2F2OHEfKkXdzHquv6Jx5HAgCTvnPXGN3FufFwye/A1alO vP+0OBaXHkkGl2U7vXOc59dMSisykajczvdB2UFIrvTi1d+vokvYn3YOx6DU0fcUdwtJ 2RFKjXZJQ/nPhTTn3HaFpmR82+QrcC0imrsFANsrHcuTKe4VFvIHNzWSrYHB7Q3zZA6Z lk+CzPuH+zOvFdtZjkpElcQJGRJgnDoqFOPyhRbRF36IP9CIomB8l6aZHqSPeLAP/lT7 ec6Q== X-Gm-Message-State: AOAM531kM9bt3w++UYzUQv8unp+cjcaAAQhdq9QJE2oXvQ1TTQ8A/BZZ RPXB8fyb9auJmZorqu5q+xJAQ5gemtSEfkIvfRFzbA== X-Google-Smtp-Source: ABdhPJy5SUJ2zmS5uUPpvJeW3954agmyO5nBK74RNUzXvygOt2JqjOZVpqg5FpwmPJeTHdeAv+FMZUt5XVZrnFOxp30= X-Received: by 2002:a25:ac13:: with SMTP id w19mr13980398ybi.402.1631892446211; Fri, 17 Sep 2021 08:27:26 -0700 (PDT) MIME-Version: 1.0 References: <20210911011819.12184-1-ricardo.neri-calderon@linux.intel.com> <20210911011819.12184-6-ricardo.neri-calderon@linux.intel.com> In-Reply-To: <20210911011819.12184-6-ricardo.neri-calderon@linux.intel.com> From: Vincent Guittot Date: Fri, 17 Sep 2021 17:27:15 +0200 Message-ID: Subject: Re: [PATCH v5 5/6] sched/fair: Carve out logic to mark a group for asymmetric packing To: Ricardo Neri Cc: "Peter Zijlstra (Intel)" , Ingo Molnar , Juri Lelli , Srikar Dronamraju , Nicholas Piggin , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Len Brown , Srinivas Pandruvada , Tim Chen , Aubrey Li , "Ravi V. Shankar" , Ricardo Neri , Quentin Perret , "Joel Fernandes (Google)" , linuxppc-dev@lists.ozlabs.org, linux-kernel , Aubrey Li , Daniel Bristot de Oliveira , "Rafael J . Wysocki" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 11 Sept 2021 at 03:19, Ricardo Neri wrote: > > Create a separate function, sched_asym(). A subsequent changeset will > introduce logic to deal with SMT in conjunction with asmymmetric > packing. Such logic will need the statistics of the scheduling > group provided as argument. Update them before calling sched_asym(). > > Cc: Aubrey Li > Cc: Ben Segall > Cc: Daniel Bristot de Oliveira > Cc: Dietmar Eggemann > Cc: Mel Gorman > Cc: Quentin Perret > Cc: Rafael J. Wysocki > Cc: Srinivas Pandruvada > Cc: Steven Rostedt > Cc: Tim Chen > Reviewed-by: Joel Fernandes (Google) > Reviewed-by: Len Brown > Co-developed-by: Peter Zijlstra (Intel) > Signed-off-by: Peter Zijlstra (Intel) > Signed-off-by: Ricardo Neri Reviewed-by: Vincent Guittot > --- > Changes since v4: > * None > > Changes since v3: > * Remove a redundant check for the local group in sched_asym(). > (Dietmar) > * Reworded commit message for clarity. (Len) > > Changes since v2: > * Introduced this patch. > > Changes since v1: > * N/A > --- > kernel/sched/fair.c | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index c5851260b4d8..26db017c14a3 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -8597,6 +8597,13 @@ group_type group_classify(unsigned int imbalance_pct, > return group_has_spare; > } > > +static inline bool > +sched_asym(struct lb_env *env, struct sd_lb_stats *sds, struct sg_lb_stats *sgs, > + struct sched_group *group) > +{ > + return sched_asym_prefer(env->dst_cpu, group->asym_prefer_cpu); > +} > + > /** > * update_sg_lb_stats - Update sched_group's statistics for load balancing. > * @env: The load balancing environment. > @@ -8657,18 +8664,17 @@ static inline void update_sg_lb_stats(struct lb_env *env, > } > } > > + sgs->group_capacity = group->sgc->capacity; > + > + sgs->group_weight = group->group_weight; > + > /* Check if dst CPU is idle and preferred to this group */ > if (!local_group && env->sd->flags & SD_ASYM_PACKING && > - env->idle != CPU_NOT_IDLE && > - sgs->sum_h_nr_running && > - sched_asym_prefer(env->dst_cpu, group->asym_prefer_cpu)) { > + env->idle != CPU_NOT_IDLE && sgs->sum_h_nr_running && > + sched_asym(env, sds, sgs, group)) { > sgs->group_asym_packing = 1; > } > > - sgs->group_capacity = group->sgc->capacity; > - > - sgs->group_weight = group->group_weight; > - > sgs->group_type = group_classify(env->sd->imbalance_pct, group, sgs); > > /* Computing avg_load makes sense only when group is overloaded */ > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B5CDC433F5 for ; Fri, 17 Sep 2021 15:28:58 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C7DDB61164 for ; Fri, 17 Sep 2021 15:28:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C7DDB61164 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4H9yXm1ttfz3cHF for ; Sat, 18 Sep 2021 01:28:56 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=wZvzXvDF; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2607:f8b0:4864:20::72f; helo=mail-qk1-x72f.google.com; envelope-from=vincent.guittot@linaro.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=wZvzXvDF; dkim-atps=neutral Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4H9yW52Tkcz3c6N for ; Sat, 18 Sep 2021 01:27:29 +1000 (AEST) Received: by mail-qk1-x72f.google.com with SMTP id p4so18590138qki.3 for ; Fri, 17 Sep 2021 08:27:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=w+tQ/PU9p2iYa5juxC+5TIx7gu+WxD4o31x+e5MbNAc=; b=wZvzXvDFoJxniSSZ1sP1OHE+iQIl14sDSSGD9RuI3YPPIvxu68inmiOiFQy/hbH2rc ByJxsWbm0dS5/qUBy5yvIn4xCBq7APq+I69B12S+nG+ozBstaNrLdlWhcYS485dyQRXH XD2oO0iNEWppR796Rx3BSQyHK3s/tC7qXkNy80RPUptucgzHKOLQsplduEITsgfxGpY5 A1TgLXvcwwteseOe6s8PgD2KDm3er4KluD0U4NDIVhwu4C4gY8b2v8bUbO2p8ZYJZwEz VQwHBTBmPiYebOPnGdT7dVN55Pl7fkz/RW/xHL9Mhp8Iblg1F+pjIH8BSaDFt7AQeqAN +VxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w+tQ/PU9p2iYa5juxC+5TIx7gu+WxD4o31x+e5MbNAc=; b=OL2AlYjY9zzIn+BxOZUpeqZ7vVBVbu7GYhnqgIZ3FgC+JJzvYqetNqQ8aH6k1tjTNz IuLrfxLH6dfaQlzxpApJMILSP+KON2zpJrTdTRalRn+KxjN0tCXePcTeeKYLsTeqGNAI qudp096OlsiYWdtVihn+t8O05Id+2N9bibIKL5lcWLsOsoGCV4YV/whDvV81yvGVEICW acQcRjy7n1AwEKuPCaflST0LhmxRGRK11yim9vwMh1RU87Br1TkjhxLmDdak9MFIlyyt SFth2yQ7qBQqpDs+81LfDq0HwTUGaWcaCSiEKMQx2tAFInTpzm1sFuN+JkxTSgvUSBKp BiGw== X-Gm-Message-State: AOAM532vShgIMStHnkFINBycTOCD4VoOLR6iWlrje0084dT1jHHL28FX DkJEnkS+EvEsIybEZdTAAZtOYDsJ0FAr/KnOLJjwIw== X-Google-Smtp-Source: ABdhPJy5SUJ2zmS5uUPpvJeW3954agmyO5nBK74RNUzXvygOt2JqjOZVpqg5FpwmPJeTHdeAv+FMZUt5XVZrnFOxp30= X-Received: by 2002:a25:ac13:: with SMTP id w19mr13980398ybi.402.1631892446211; Fri, 17 Sep 2021 08:27:26 -0700 (PDT) MIME-Version: 1.0 References: <20210911011819.12184-1-ricardo.neri-calderon@linux.intel.com> <20210911011819.12184-6-ricardo.neri-calderon@linux.intel.com> In-Reply-To: <20210911011819.12184-6-ricardo.neri-calderon@linux.intel.com> From: Vincent Guittot Date: Fri, 17 Sep 2021 17:27:15 +0200 Message-ID: Subject: Re: [PATCH v5 5/6] sched/fair: Carve out logic to mark a group for asymmetric packing To: Ricardo Neri Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juri Lelli , Aubrey Li , Srikar Dronamraju , "Ravi V. Shankar" , "Peter Zijlstra \(Intel\)" , Ricardo Neri , Ben Segall , Srinivas Pandruvada , "Joel Fernandes \(Google\)" , Ingo Molnar , "Rafael J . Wysocki" , Steven Rostedt , Mel Gorman , Len Brown , Nicholas Piggin , Aubrey Li , Dietmar Eggemann , Tim Chen , Quentin Perret , Daniel Bristot de Oliveira , linux-kernel , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, 11 Sept 2021 at 03:19, Ricardo Neri wrote: > > Create a separate function, sched_asym(). A subsequent changeset will > introduce logic to deal with SMT in conjunction with asmymmetric > packing. Such logic will need the statistics of the scheduling > group provided as argument. Update them before calling sched_asym(). > > Cc: Aubrey Li > Cc: Ben Segall > Cc: Daniel Bristot de Oliveira > Cc: Dietmar Eggemann > Cc: Mel Gorman > Cc: Quentin Perret > Cc: Rafael J. Wysocki > Cc: Srinivas Pandruvada > Cc: Steven Rostedt > Cc: Tim Chen > Reviewed-by: Joel Fernandes (Google) > Reviewed-by: Len Brown > Co-developed-by: Peter Zijlstra (Intel) > Signed-off-by: Peter Zijlstra (Intel) > Signed-off-by: Ricardo Neri Reviewed-by: Vincent Guittot > --- > Changes since v4: > * None > > Changes since v3: > * Remove a redundant check for the local group in sched_asym(). > (Dietmar) > * Reworded commit message for clarity. (Len) > > Changes since v2: > * Introduced this patch. > > Changes since v1: > * N/A > --- > kernel/sched/fair.c | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index c5851260b4d8..26db017c14a3 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -8597,6 +8597,13 @@ group_type group_classify(unsigned int imbalance_pct, > return group_has_spare; > } > > +static inline bool > +sched_asym(struct lb_env *env, struct sd_lb_stats *sds, struct sg_lb_stats *sgs, > + struct sched_group *group) > +{ > + return sched_asym_prefer(env->dst_cpu, group->asym_prefer_cpu); > +} > + > /** > * update_sg_lb_stats - Update sched_group's statistics for load balancing. > * @env: The load balancing environment. > @@ -8657,18 +8664,17 @@ static inline void update_sg_lb_stats(struct lb_env *env, > } > } > > + sgs->group_capacity = group->sgc->capacity; > + > + sgs->group_weight = group->group_weight; > + > /* Check if dst CPU is idle and preferred to this group */ > if (!local_group && env->sd->flags & SD_ASYM_PACKING && > - env->idle != CPU_NOT_IDLE && > - sgs->sum_h_nr_running && > - sched_asym_prefer(env->dst_cpu, group->asym_prefer_cpu)) { > + env->idle != CPU_NOT_IDLE && sgs->sum_h_nr_running && > + sched_asym(env, sds, sgs, group)) { > sgs->group_asym_packing = 1; > } > > - sgs->group_capacity = group->sgc->capacity; > - > - sgs->group_weight = group->group_weight; > - > sgs->group_type = group_classify(env->sd->imbalance_pct, group, sgs); > > /* Computing avg_load makes sense only when group is overloaded */ > -- > 2.17.1 >