From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE0E0C43141 for ; Fri, 15 Nov 2019 14:12:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B76C020730 for ; Fri, 15 Nov 2019 14:12:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EW8AUeKs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727560AbfKOOMQ (ORCPT ); Fri, 15 Nov 2019 09:12:16 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:35549 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727434AbfKOOMQ (ORCPT ); Fri, 15 Nov 2019 09:12:16 -0500 Received: by mail-lj1-f193.google.com with SMTP id r7so10862946ljg.2 for ; Fri, 15 Nov 2019 06:12:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=slql22Lvz46WLUa6lndozAHDqOw1IKVDi6n/pS/xzmc=; b=EW8AUeKskgrRYNROo8Qv9VIP+RzHnB5xM/iAzMi0TB45huCydBA8sKyiW3/xypqRe3 MEFNXYMqPlFSNcDTGdyDcObMzjMJXbJB+9q9h+tQJb8I5yIfPb8btv23xPZPqjxtnJbR KnNe3ZXBbtkiKJJCcvUfLd4Sfm3QtlKQB+aVrur7uO48Iw5DqCHlf5lXixhLJFEG3KU/ VYoGQfkfClEqRZolI0iryVZf0cdDj6sHqaZSZ2XH5ogiGujNqbJTUZc5ZOKFVi+RK24R 9SSZI4KHRdHz4Kf5VWOZh7hvTK/qpW317qhtZXXRZqmvOoJb8FGRuR/dBjT7iJPX1s3C Cr9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=slql22Lvz46WLUa6lndozAHDqOw1IKVDi6n/pS/xzmc=; b=Idavl0oSJu2+1YgKvNkSZoVdNQOGPxMU3KtEFCHaqSlI8D+k8emNLbZpPAohNg4rZd 3PmEVRxkVrk36eghwmdzqj7gFMlRyWEr43Q5O8CqU54V96Jxa6JcjzLJKumhMgb4rATs CsyrbDBFHCM3GPcnGSLbfZvtSw9fmEwoSfzvrn/2Q1BBdBi0JskXzN8CaR7KaxAsgtzO 5Z7pRD3CTjf0OnMhOXTPGzNG3898Ary/qoNpgwaYivfHnPHRowhVnWN1cx6rVHsnNgDM rwuEBoJQo1TVPLigZrYeN+L/t/uM7u8lPNcO9MFWaKK5d84HLagIDBtKbj3x7plQB/4b YEvw== X-Gm-Message-State: APjAAAVRV8ppB22Zp9/6DmvR39PoZSf2rdRLb/R826DquaAXB2CFY5KB sTX2vkR+v2CYPt87+uKho/RW/94Vob5yoe3/zgpzaw== X-Google-Smtp-Source: APXvYqyhDaYL80Ahst62ZZPsU/jmvGG4mTPUUh0TSUDWU4odSDAqEYSLIBo3opQCvc9EMgd5iDZQUbFmIkUAEE4+TeY= X-Received: by 2002:a2e:b0e3:: with SMTP id h3mr10978072ljl.193.1573827133905; Fri, 15 Nov 2019 06:12:13 -0800 (PST) MIME-Version: 1.0 References: <1573751251-3505-1-git-send-email-vincent.guittot@linaro.org> <20191115132520.GJ4131@hirez.programming.kicks-ass.net> <20191115140555.GL4131@hirez.programming.kicks-ass.net> In-Reply-To: <20191115140555.GL4131@hirez.programming.kicks-ass.net> From: Vincent Guittot Date: Fri, 15 Nov 2019 15:12:02 +0100 Message-ID: Subject: Re: [PATCH v4] sched/freq: move call to cpufreq_update_util To: Peter Zijlstra Cc: linux-kernel , Ingo Molnar , Dietmar Eggemann , Juri Lelli , Steven Rostedt , Mel Gorman , Doug Smythies , "open list:THERMAL" , Linus Torvalds , Thomas Gleixner , Sargun Dhillon , Tejun Heo , Xie XiuQi , xiezhipeng1@huawei.com, Srinivas Pandruvada Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Nov 2019 at 15:06, Peter Zijlstra wrote: > > On Fri, Nov 15, 2019 at 02:37:27PM +0100, Vincent Guittot wrote: > > On Fri, 15 Nov 2019 at 14:25, Peter Zijlstra wrote: > > > > > > On Thu, Nov 14, 2019 at 06:07:31PM +0100, Vincent Guittot wrote: > > > > > + decayed = update_rt_rq_load_avg(rq_clock_pelt(rq), rq, curr_class == &rt_sched_class); > > > > + decayed |= update_dl_rq_load_avg(rq_clock_pelt(rq), rq, curr_class == &dl_sched_class); > > > > + decayed |= update_irq_load_avg(rq, 0); > > > > > > Should not all 3 have their windows aligned and thus alway return the > > > exact same value? > > > > rt and dl yes but not irq > > Any reason for IRQ not to be aligned? irq time is not accounted into task time so irq_avg use rq->clock whereas other use rq->clock_task But irq is also not sum up with others > > > But having aligned window doesn't mean that they will all decay. > > One can have been updated just before (during a dequeue as an example) > > or at least less than 1ms before > > Bah... true.