From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752553AbdFLObP (ORCPT ); Mon, 12 Jun 2017 10:31:15 -0400 Received: from mail-lf0-f54.google.com ([209.85.215.54]:35589 "EHLO mail-lf0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752403AbdFLObN (ORCPT ); Mon, 12 Jun 2017 10:31:13 -0400 MIME-Version: 1.0 In-Reply-To: <20170608075513.12475-4-dietmar.eggemann@arm.com> References: <20170608075513.12475-1-dietmar.eggemann@arm.com> <20170608075513.12475-4-dietmar.eggemann@arm.com> From: Vincent Guittot Date: Mon, 12 Jun 2017 16:30:50 +0200 Message-ID: Subject: Re: [PATCH 3/6] arm: wire frequency-invariant accounting support up to the task scheduler To: Dietmar Eggemann Cc: linux-kernel , "linux-pm@vger.kernel.org" , Russell King - ARM Linux , LAK , Greg Kroah-Hartman , Russell King , Catalin Marinas , Will Deacon , Juri Lelli , Vincent Guittot , Peter Zijlstra , Morten Rasmussen Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8 June 2017 at 09:55, Dietmar Eggemann wrote: > Commit dfbca41f3479 ("sched: Optimize freq invariant accounting") > changed the wiring which now has to be done by associating > arch_scale_freq_capacity with the actual implementation provided > by the architecture. > > Define arch_scale_freq_capacity to use the arch_topology "driver" > function topology_get_freq_scale() for the task scheduler's > frequency-invariant accounting instead of the default > arch_scale_freq_capacity() in kernel/sched/sched.h. > > Cc: Russell King > Cc: Juri Lelli > Signed-off-by: Dietmar Eggemann Acked-by: Vincent Guittot > --- > arch/arm/include/asm/topology.h | 5 +++++ > arch/arm/kernel/topology.c | 1 - > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/include/asm/topology.h b/arch/arm/include/asm/topology.h > index 370f7a732900..a56a9e24f4c0 100644 > --- a/arch/arm/include/asm/topology.h > +++ b/arch/arm/include/asm/topology.h > @@ -24,6 +24,11 @@ void init_cpu_topology(void); > void store_cpu_topology(unsigned int cpuid); > const struct cpumask *cpu_coregroup_mask(int cpu); > > +#include > + > +/* Replace task scheduler's default frequency-invariant accounting */ > +#define arch_scale_freq_capacity topology_get_freq_scale > + > #else > > static inline void init_cpu_topology(void) { } > diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c > index bf949a763dbe..2c47a76c67b0 100644 > --- a/arch/arm/kernel/topology.c > +++ b/arch/arm/kernel/topology.c > @@ -11,7 +11,6 @@ > * for more details. > */ > > -#include > #include > #include > #include > -- > 2.11.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: vincent.guittot@linaro.org (Vincent Guittot) Date: Mon, 12 Jun 2017 16:30:50 +0200 Subject: [PATCH 3/6] arm: wire frequency-invariant accounting support up to the task scheduler In-Reply-To: <20170608075513.12475-4-dietmar.eggemann@arm.com> References: <20170608075513.12475-1-dietmar.eggemann@arm.com> <20170608075513.12475-4-dietmar.eggemann@arm.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 8 June 2017 at 09:55, Dietmar Eggemann wrote: > Commit dfbca41f3479 ("sched: Optimize freq invariant accounting") > changed the wiring which now has to be done by associating > arch_scale_freq_capacity with the actual implementation provided > by the architecture. > > Define arch_scale_freq_capacity to use the arch_topology "driver" > function topology_get_freq_scale() for the task scheduler's > frequency-invariant accounting instead of the default > arch_scale_freq_capacity() in kernel/sched/sched.h. > > Cc: Russell King > Cc: Juri Lelli > Signed-off-by: Dietmar Eggemann Acked-by: Vincent Guittot > --- > arch/arm/include/asm/topology.h | 5 +++++ > arch/arm/kernel/topology.c | 1 - > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/include/asm/topology.h b/arch/arm/include/asm/topology.h > index 370f7a732900..a56a9e24f4c0 100644 > --- a/arch/arm/include/asm/topology.h > +++ b/arch/arm/include/asm/topology.h > @@ -24,6 +24,11 @@ void init_cpu_topology(void); > void store_cpu_topology(unsigned int cpuid); > const struct cpumask *cpu_coregroup_mask(int cpu); > > +#include > + > +/* Replace task scheduler's default frequency-invariant accounting */ > +#define arch_scale_freq_capacity topology_get_freq_scale > + > #else > > static inline void init_cpu_topology(void) { } > diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c > index bf949a763dbe..2c47a76c67b0 100644 > --- a/arch/arm/kernel/topology.c > +++ b/arch/arm/kernel/topology.c > @@ -11,7 +11,6 @@ > * for more details. > */ > > -#include > #include > #include > #include > -- > 2.11.0 >