From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754996AbbCYSJI (ORCPT <rfc822;w@1wt.eu>);
	Wed, 25 Mar 2015 14:09:08 -0400
Received: from mail-oi0-f53.google.com ([209.85.218.53]:35579 "EHLO
	mail-oi0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754976AbbCYSJE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 25 Mar 2015 14:09:04 -0400
MIME-Version: 1.0
In-Reply-To: <20150325173309.GS21418@twins.programming.kicks-ass.net>
References: <1425052454-25797-1-git-send-email-vincent.guittot@linaro.org>
 <1425052454-25797-5-git-send-email-vincent.guittot@linaro.org>
 <20150323131905.GF23123@twins.programming.kicks-ass.net> <CAKfTPtDgqV0wg23BtjrM6oDKtG9sQ856Xs5kjpr4SSdTfVH-uw@mail.gmail.com>
 <20150325173309.GS21418@twins.programming.kicks-ass.net>
From: Vincent Guittot <vincent.guittot@linaro.org>
Date: Wed, 25 Mar 2015 19:08:42 +0100
Message-ID: <CAKfTPtCSDxcRCp5i=SMxKLxc2m+kZp0XXaxHgE67w6_21bs+nQ@mail.gmail.com>
Subject: Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Preeti U Murthy <preeti@linux.vnet.ibm.com>,
        Morten Rasmussen <Morten.Rasmussen@arm.com>,
        Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
        Rik van Riel <riel@redhat.com>, Mike Galbraith <efault@gmx.de>,
        Nicolas Pitre <nicolas.pitre@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Linaro Kernel Mailman List <linaro-kernel@lists.linaro.org>,
        Paul Turner <pjt@google.com>, Ben Segall <bsegall@google.com>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 25 March 2015 at 18:33, Peter Zijlstra <peterz@infradead.org> wrote:
> On Tue, Mar 24, 2015 at 11:00:57AM +0100, Vincent Guittot wrote:
>> On 23 March 2015 at 14:19, Peter Zijlstra <peterz@infradead.org> wrote:
>> > On Fri, Feb 27, 2015 at 04:54:07PM +0100, Vincent Guittot wrote:
>> >
>> >> +     unsigned long scale_freq = arch_scale_freq_capacity(NULL, cpu);
>> >
>> >> +                     sa->running_avg_sum += delta_w * scale_freq
>> >> +                             >> SCHED_CAPACITY_SHIFT;
>> >
>> > so the only thing that could be improved is somehow making this
>> > multiplication go away when the arch doesn't implement the function.
>> >
>> > But I'm not sure how to do that without #ifdef.
>> >
>> > Maybe a little something like so then... that should make the compiler
>> > get rid of those multiplications unless the arch needs them.
>>
>> yes, it removes useless multiplication when not used by an arch.
>> It also adds a constraint on the arch side which have to define
>> arch_scale_freq_capacity like below:
>>
>> #define arch_scale_freq_capacity xxx_arch_scale_freq_capacity
>> with xxx_arch_scale_freq_capacity an architecture specific function
>
> Yeah, but it not being weak should make that a compile time warn/fail,
> which should be pretty easy to deal with.
>
>> If it sounds acceptable i can update the patch with your proposal ?
>
> I'll stick it to the end, I just wanted to float to patch to see if
> people had better solutions.

ok. all other methods that i have tried, was removing the optimization
when default arch_scale_freq_capacity was used