From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB657C433E0 for ; Mon, 13 Jul 2020 12:03:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CAB5D2072D for ; Mon, 13 Jul 2020 12:03:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="H3ojp220" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729578AbgGMMDV (ORCPT ); Mon, 13 Jul 2020 08:03:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729318AbgGMMDU (ORCPT ); Mon, 13 Jul 2020 08:03:20 -0400 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6245FC061794 for ; Mon, 13 Jul 2020 05:03:20 -0700 (PDT) Received: by mail-lf1-x142.google.com with SMTP id y18so8844376lfh.11 for ; Mon, 13 Jul 2020 05:03:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=y5KMHDUl0dP2/yxULAu5/b1d01e8D1X8yaqLPXL7OeY=; b=H3ojp220B2LkylmsATbkDKYAr9c9hzVaK8lhZCLxcDV3QcBMkL80V2xjQUHeAQu4ky PWfn+Md+nsxFTihVKzDV8rTq5f4ormyVJW+rU7RAeuJyAv4Hnn43qqztrTig1KEl7h7I pnpNN1yXLQsl+bXWAageYi1x2LeAIYT5Lo7aoYzJCC998Y/kA4Rgo1rLKWhI2XC/fAX8 tbLdXDwe90hvOvzyPZnqkCra7xZR3M5Os1BimwS6Zh1XxeESLNXjAD3Zb8ftjXmr7l6c XOob7orM0tvlEoox2rDKGz20MBGTwumQ20xbUuqy5oMduu/LjxfdJUMNQouwAETRxG6V nI5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y5KMHDUl0dP2/yxULAu5/b1d01e8D1X8yaqLPXL7OeY=; b=sWynaTBS6+M0rKKdEFMkrV1YVIRIxAwQKIcPNT7v4bkn5Vc9FBLWwBoDAckQSJtCTt gly5kmFNpoGYxtbaHM11xnic/K00DupyJi4EZY1w/NbiQDHAshlRpXk2zi2BhcQlhZKW MjJx1eT3Q7rVKz9DbnXzz/6PExjfjJaG2bekRD7XQ6dMgeIf9yM3SXmXMbGqZNdz+VC2 x0EfZALM8b9uBdLySZfuEOmM+SesBWqK4gxN3/NFOP2EWAcmN/XrXltnjOj6j1Z6lVLG HRoDzHlhtD608N6tpQHCGbP0skJA0D2iqnmmEGo3I5r1FqmBkvrOTrOO5bhYKHavGq1p q//Q== X-Gm-Message-State: AOAM533+iTOqrFNwC/tbU5DFmSWUD7ytSU5aaSGpdClJRKRWUO88iTOz onNmDmh8O7wEVN7Al1lBYSqDa23VlVkbrHc6g22sTg== X-Google-Smtp-Source: ABdhPJxeeTVOBjzNfFPpHLHGDWpCLW18lUobuuQt7/W9ElRbsNZuZOxfCtntGelZjeemcLqJCveTFhKFSh5BaKmul5M= X-Received: by 2002:a19:7d84:: with SMTP id y126mr53124241lfc.149.1594641798626; Mon, 13 Jul 2020 05:03:18 -0700 (PDT) MIME-Version: 1.0 References: <20200712165917.9168-1-valentin.schneider@arm.com> In-Reply-To: <20200712165917.9168-1-valentin.schneider@arm.com> From: Vincent Guittot Date: Mon, 13 Jul 2020 14:03:06 +0200 Message-ID: Subject: Re: [PATCH v2 0/3] sched, arch_topology: Thermal pressure configuration cleanup To: Valentin Schneider Cc: linux-kernel , LAK , "open list:THERMAL" , Russell King , Thara Gopinath , Sudeep Holla , Amit Daniel Kachhap , Daniel Lezcano , Viresh Kumar , Ingo Molnar , Peter Zijlstra , Juri Lelli , Dietmar Eggemann Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 12 Jul 2020 at 18:59, Valentin Schneider wrote: > > Hi folks, > > This stems from this thread [1] on the list. TL;DR: the thermal pressure config > has no helpful documentation, and figuring out if the right dependencies are in > place is not easy for a regular user. > > The current landscape also paints an odd picture: arch_set_thermal_pressure() is > hardcoded in sched/core.c, and is *not* architecture-definable, while > arch_get_thermal_pressure() is. Patch 1 is tackling this, the rest is Kconfig > stuff. > > Cheers, > Valentin > > [1]: https://lkml.kernel.org/r/20200603173150.GB1551@shell.armlinux.org.uk > > Revisions > ========= > > v1 -> v2 > -------- > > o Remove cpufreq_cooling.c weak function; use #define stub in sched/topology.h > (Vincent) Looks good to me. Reviewed-by: Vincent Guittot > o Hinge arm SCHED_THERMAL_PRESSURE selection on ARM_CPU_TOPOLOGY > > Valentin Schneider (3): > arch_topology, sched/core: Cleanup thermal pressure definition > sched: Cleanup SCHED_THERMAL_PRESSURE kconfig entry > arm, arm64: Select CONFIG_SCHED_THERMAL_PRESSURE > > arch/arm/Kconfig | 1 + > arch/arm/include/asm/topology.h | 3 ++- > arch/arm64/Kconfig | 1 + > arch/arm64/include/asm/topology.h | 3 ++- > drivers/base/arch_topology.c | 11 +++++++++++ > include/linux/arch_topology.h | 4 ++-- > include/linux/sched/topology.h | 7 +++++++ > init/Kconfig | 15 ++++++++++++++- > kernel/sched/core.c | 11 ----------- > 9 files changed, 40 insertions(+), 16 deletions(-) > > -- > 2.27.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0544BC433E1 for ; Mon, 13 Jul 2020 12:04:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8C09206F0 for ; Mon, 13 Jul 2020 12:04:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Uhu0IpVG"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="H3ojp220" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8C09206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zrUmzCAU/14/N8PyyDHwW/X7HfDs1KVaRv7H/jIM544=; b=Uhu0IpVGh7a4D9lYYV5tgJYSt oytmPGCS2sfxW4PdsAiUoEcCTLTgKbxQVZjlQJiL/0ufaZBknERPT0BBcV4yy+iV9ePUOaa8VQHvX FLhxlyqWY4EVdQZStKrFhd786JSUQpCdjAHnJUuxdIt99kzYR+ToNqZteEUVZUqTsG5qWetj5Szb6 1XXA0b8lhHWFE2R2CiTEICCWy/YA7INE8B2jC/OIGnnm8+fHleYiiV9LO6ytvA/m3X9Y8dNeFP3ZX zZlhvJOtkP8Lla3t91/P70C3TJt70JfTs5r5TmNWWDXDvAKlhZmsn9PePAJrGZpqJtDfm13NVP+8x KN5Wgw3pw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1juxB6-0005hg-S7; Mon, 13 Jul 2020 12:03:24 +0000 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1juxB4-0005gu-GY for linux-arm-kernel@lists.infradead.org; Mon, 13 Jul 2020 12:03:23 +0000 Received: by mail-lf1-x144.google.com with SMTP id k17so8839570lfg.3 for ; Mon, 13 Jul 2020 05:03:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=y5KMHDUl0dP2/yxULAu5/b1d01e8D1X8yaqLPXL7OeY=; b=H3ojp220B2LkylmsATbkDKYAr9c9hzVaK8lhZCLxcDV3QcBMkL80V2xjQUHeAQu4ky PWfn+Md+nsxFTihVKzDV8rTq5f4ormyVJW+rU7RAeuJyAv4Hnn43qqztrTig1KEl7h7I pnpNN1yXLQsl+bXWAageYi1x2LeAIYT5Lo7aoYzJCC998Y/kA4Rgo1rLKWhI2XC/fAX8 tbLdXDwe90hvOvzyPZnqkCra7xZR3M5Os1BimwS6Zh1XxeESLNXjAD3Zb8ftjXmr7l6c XOob7orM0tvlEoox2rDKGz20MBGTwumQ20xbUuqy5oMduu/LjxfdJUMNQouwAETRxG6V nI5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y5KMHDUl0dP2/yxULAu5/b1d01e8D1X8yaqLPXL7OeY=; b=L3/MnQNAS+VACcyYtQUX4Q0Z4onv1pwprPAqLqwemK/lgdF5SAW5aO+k2jq8imSLHn fUjPpgmRQR/XU9V4ERveH/whdmwrM4BVwi06sqgqmZyta3c8NzxA7ihtMf47Sqx6nhVB 65wcFarVk309hfBnrYxFErj6T0v2fB3pk0fQdMPlwJ6jNHqsm4fMr9HXGvskHcTi+/Rt i/cdQHYSIxRfjeON+zdPv88dfQGYXLfmonluxRi0tr5O/ZiGpyy62rSoZkPxOqjjXRoR 82XGn4IunsW0QbnrIeqCEIgh4MTj3vRapKEgxIGg2OyBHqivEBMANoy2do3sOAGVqvi5 FBnA== X-Gm-Message-State: AOAM533HJ3E+q2Gc3y68lwBUf7QMQs/Nk1Bbp5bk6vjrw4muHBAJC8+4 fayHpTNpj4JBs5ooDIkYxool0qrSJs9mf5eiCE71NA== X-Google-Smtp-Source: ABdhPJxeeTVOBjzNfFPpHLHGDWpCLW18lUobuuQt7/W9ElRbsNZuZOxfCtntGelZjeemcLqJCveTFhKFSh5BaKmul5M= X-Received: by 2002:a19:7d84:: with SMTP id y126mr53124241lfc.149.1594641798626; Mon, 13 Jul 2020 05:03:18 -0700 (PDT) MIME-Version: 1.0 References: <20200712165917.9168-1-valentin.schneider@arm.com> In-Reply-To: <20200712165917.9168-1-valentin.schneider@arm.com> From: Vincent Guittot Date: Mon, 13 Jul 2020 14:03:06 +0200 Message-ID: Subject: Re: [PATCH v2 0/3] sched, arch_topology: Thermal pressure configuration cleanup To: Valentin Schneider X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200713_080322_561285_9ED0A4C7 X-CRM114-Status: GOOD ( 13.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juri Lelli , "open list:THERMAL" , Peter Zijlstra , Viresh Kumar , Amit Daniel Kachhap , Daniel Lezcano , Russell King , Thara Gopinath , linux-kernel , Sudeep Holla , Dietmar Eggemann , Ingo Molnar , LAK Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 12 Jul 2020 at 18:59, Valentin Schneider wrote: > > Hi folks, > > This stems from this thread [1] on the list. TL;DR: the thermal pressure config > has no helpful documentation, and figuring out if the right dependencies are in > place is not easy for a regular user. > > The current landscape also paints an odd picture: arch_set_thermal_pressure() is > hardcoded in sched/core.c, and is *not* architecture-definable, while > arch_get_thermal_pressure() is. Patch 1 is tackling this, the rest is Kconfig > stuff. > > Cheers, > Valentin > > [1]: https://lkml.kernel.org/r/20200603173150.GB1551@shell.armlinux.org.uk > > Revisions > ========= > > v1 -> v2 > -------- > > o Remove cpufreq_cooling.c weak function; use #define stub in sched/topology.h > (Vincent) Looks good to me. Reviewed-by: Vincent Guittot > o Hinge arm SCHED_THERMAL_PRESSURE selection on ARM_CPU_TOPOLOGY > > Valentin Schneider (3): > arch_topology, sched/core: Cleanup thermal pressure definition > sched: Cleanup SCHED_THERMAL_PRESSURE kconfig entry > arm, arm64: Select CONFIG_SCHED_THERMAL_PRESSURE > > arch/arm/Kconfig | 1 + > arch/arm/include/asm/topology.h | 3 ++- > arch/arm64/Kconfig | 1 + > arch/arm64/include/asm/topology.h | 3 ++- > drivers/base/arch_topology.c | 11 +++++++++++ > include/linux/arch_topology.h | 4 ++-- > include/linux/sched/topology.h | 7 +++++++ > init/Kconfig | 15 ++++++++++++++- > kernel/sched/core.c | 11 ----------- > 9 files changed, 40 insertions(+), 16 deletions(-) > > -- > 2.27.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel