All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincent Guittot <vincent.guittot@linaro.org>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Morten Rasmussen <Morten.Rasmussen@arm.com>,
	Patrick Bellasi <patrick.bellasi@arm.com>,
	Paul Turner <pjt@google.com>, Ben Segall <bsegall@google.com>,
	Thara Gopinath <thara.gopinath@linaro.org>,
	pkondeti@codeaurora.org, Quentin Perret <quentin.perret@arm.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: Re: [PATCH v8 2/3] sched/fair: update scale invariance of PELT
Date: Wed, 23 Jan 2019 10:48:48 +0100	[thread overview]
Message-ID: <CAKfTPtCjb2PRxgs9nABw2V_MJq2wi=0DTpm+wEvvSX7qnAp+VA@mail.gmail.com> (raw)
In-Reply-To: <a3671d96-5003-6a50-ad2d-64833ca216a1@arm.com>

On Wed, 23 Jan 2019 at 09:26, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
>
> On 1/16/19 10:43 AM, Vincent Guittot wrote:
>
> [...]
>
> > +static inline u64 rq_clock_pelt(struct rq *rq)
> > +{
>
> Doesn't this function need
>
>    lockdep_assert_held(&rq->lock);
>    assert_clock_updated(rq);

originally, it was replacing cfs_rq_clock_task which doesn't have this
debugging code.
But it also replaces rq_clock_task for deadline and rt so it's
probably worthing adding them for such case

>
> like rq_clock() and rq_clock_task()? Later to support commit
> cb42c9a3ebbb "sched/core: Add debugging code to catch missing
> update_rq_clock() calls".
>
> > +     return rq->clock_pelt - rq->lost_idle_time;
> > +}
>
> [...]

  reply	other threads:[~2019-01-23  9:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-16  9:43 [PATCH v8 0/3] sched/fair: update scale invariance of PELT Vincent Guittot
2019-01-16  9:43 ` [PATCH v8 1/3] sched/fair: move rq_of helper function Vincent Guittot
2019-01-16  9:43 ` [PATCH v8 2/3] sched/fair: update scale invariance of PELT Vincent Guittot
2019-01-23  8:25   ` Dietmar Eggemann
2019-01-23  9:48     ` Vincent Guittot [this message]
2019-01-23 11:19       ` Dietmar Eggemann
2019-01-16  9:43 ` [PATCH v8 3/3] sched/pelt: skip updating util_est when utilization is higher than cpu's capacity Vincent Guittot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKfTPtCjb2PRxgs9nABw2V_MJq2wi=0DTpm+wEvvSX7qnAp+VA@mail.gmail.com' \
    --to=vincent.guittot@linaro.org \
    --cc=Morten.Rasmussen@arm.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=patrick.bellasi@arm.com \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    --cc=pkondeti@codeaurora.org \
    --cc=quentin.perret@arm.com \
    --cc=rjw@rjwysocki.net \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=thara.gopinath@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.