From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22CD7C43387 for ; Wed, 9 Jan 2019 16:56:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E7170206BA for ; Wed, 9 Jan 2019 16:55:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="Q+3x8aGD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726674AbfAIQz7 (ORCPT ); Wed, 9 Jan 2019 11:55:59 -0500 Received: from mail-io1-f65.google.com ([209.85.166.65]:37417 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726072AbfAIQz6 (ORCPT ); Wed, 9 Jan 2019 11:55:58 -0500 Received: by mail-io1-f65.google.com with SMTP id g8so6569953iok.4 for ; Wed, 09 Jan 2019 08:55:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=kki7GX0S+t7hj/hdc6mJj5VtGMKtQZTAwoWP5KR8oJA=; b=Q+3x8aGDd/+bdRQp6N+2ZpUI327wJoexTa/6+Tyqu20NnYA2zzh8tCkcaO1tkFHKnA jjLaNk/rS/r2luVOoDyyGqM/ujcSa3DbAgotT3KDq99s784yRD8jrMB5+48pj9RmkFwS 313Ft4ncFR0AyqIIXs4fx2bP7U2xt8BaK5IcA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=kki7GX0S+t7hj/hdc6mJj5VtGMKtQZTAwoWP5KR8oJA=; b=Uf8qoEM7yl5OZM/eT/IquBbfNZC61yYIh1ZA15CnltKrw8FcNP/0OIMCHNzw7pjAQv EIZgw2El963UCl7gxI3o/qHrCIKXcDOXVZ3RdTdlDTkSoLBoaood1zFnWAEfANiVOfvA UR7oNi0ym4ieEZzFHkU9qZoMPPQPyRvvMubEeytnPXQCscR6g6r1jIGHDjNagdo/QV1u T8ErGXYy6aQE0a9hXbZQbVNGFFmJoOYLq/wJuHKlAt94nUXk4JnhZSk34bxcEQG5N0Wa o/0vMW2YleD711xYVqTgVl2XQuFIUBo7BkmgYXrzeXDAL+Fc2XCO2n8oHUtQl5oGAL4o yFKg== X-Gm-Message-State: AJcUukdhe8QMtidQws2qr6oB7c+FlrvpZ6F/gAWsUcTtdBLaKj2d2JGF ufv0MsJI1hcUOsOER4btOkuGZLrtsNAh+axRyH0TAlb5yWJe6g== X-Google-Smtp-Source: ALg8bN61k2I49EIfEaI7zbl2JZ1N1JnLQc4jMeV2GRJPyIicfNIkneVXL61psqRGnawj9on/bi2MeTTm70cokk+5RzM= X-Received: by 2002:a6b:c8c9:: with SMTP id y192mr4101980iof.183.1547052957562; Wed, 09 Jan 2019 08:55:57 -0800 (PST) MIME-Version: 1.0 References: <20190107233833.GI5544@atomide.com> <20190108155354.GL5544@atomide.com> <20190108213743.GN5544@atomide.com> <20190109014218.GA8363@linaro.org> <20190109015124.GO5544@atomide.com> <20190109162846.GP5544@atomide.com> <20190109165004.GQ5544@atomide.com> In-Reply-To: <20190109165004.GQ5544@atomide.com> From: Vincent Guittot Date: Wed, 9 Jan 2019 17:55:46 +0100 Message-ID: Subject: Re: Regression in v5.0-rc1 with autosuspend hrtimers To: Tony Lindgren Cc: "Rafael J. Wysocki" , "Rafael J. Wysocki" , Ulf Hansson , "open list:THERMAL" , linux-kernel , LAK , Linux OMAP Mailing List , Ladislav Michl Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 Jan 2019 at 17:50, Tony Lindgren wrote: > > * Vincent Guittot [190109 16:48]: > > On Wed, 9 Jan 2019 at 17:28, Tony Lindgren wrote: > > > > > > * Rafael J. Wysocki [190109 09:44]: > > > > On Wed, Jan 9, 2019 at 2:51 AM Tony Lindgren wro= te: > > > > > > > > > > * Vincent Guittot [190109 01:42]: > > > > > > Le Tuesday 08 Jan 2019 =C3=A0 13:37:43 (-0800), Tony Lindgren a= =C3=A9crit : > > > > > > > Lowering the autosuspend_delay_ms to 2100 ms makes things wor= k again. > > > > > > > Anything higher than 2200 ms seems to somehow time out immedi= ately > > > > > > > now :) > > > > > > > > > > > > This is quite close to the max ns of an int on arm 32bits > > > > > > > > > > > > Could you try the patch below ? > > > > > > > > > > Yup great thanks, that's it: > > > > > > > > > > Tested-by: Tony Lindgren > > > > > > > > Cool. Thanks for getting to the bottom of this! > > > > > > No problem. > > > > > > One more thing I noticed: The 25% slack can get noticeable > > > for larger values. For things like a 3 second uart console > > > timeout slack of 750 ms is quite large variation. > > > > > > Should we have a limit of max 100 ms for the slack? > > > > Keep in mind that when jiffies were used, expires was rounded to a > > full second when delay was greater than a second. So you could already > > have difference of up 990ms on arm before this patch > > And i don't take into account the rework of timer infra which add > > another level of variation, something like up to 640 ms more when the > > timer is greater than 2880 ms for arm IIRC > > I think it was rounded up earlier. > > Don't we get rounded down now also? We still round up. In hrtimer we have : timer->_softexpires =3D time; timer->node.expires =3D ktime_add_safe(time, delta); so the hrtimer will expire between "time" and "time+delta" > > Regards, > > Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 943E2C43387 for ; Wed, 9 Jan 2019 16:56:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F9CD206BA for ; Wed, 9 Jan 2019 16:56:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="I5r4lF/S"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="Q+3x8aGD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F9CD206BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6w+2sEZp0HU86Dv8uZlmzvlwOT5La7nIbTnwIOt4yVA=; b=I5r4lF/S5iFqoe FvDcncr1gVzDcX3Zf9LwMtjam0E5vV+wvoJCX+/weQcXFpO1D/Ax4qo8hLNiVERCCUhw/4xtNYvdG G/+zpRyMYeJxMyuzGxhcpXH1Vb182IRyJFRXt000lnzfkElL1ccewJhAqAqZIWp/09Q7bdrjTB/pB k4gsdzgO3edWpU3ggzfAuYqbJWgWSoazT5PSDHhYbVAs0jIRz2xCm5a1xp2l7msKEC1XAJpNPH++s GLF+PMcN/sgM6pWw6VheB57lSSFHyyBbXUcs5HSBWFUu3n93HUgorFlY/XlonzZBMoyQ9WruglmCp iIqaPHv0RoFShBXgZC2A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghH97-0005wr-SK; Wed, 09 Jan 2019 16:56:01 +0000 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghH94-0005wO-Ln for linux-arm-kernel@lists.infradead.org; Wed, 09 Jan 2019 16:56:00 +0000 Received: by mail-io1-xd43.google.com with SMTP id l14so6553986ioj.5 for ; Wed, 09 Jan 2019 08:55:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=kki7GX0S+t7hj/hdc6mJj5VtGMKtQZTAwoWP5KR8oJA=; b=Q+3x8aGDd/+bdRQp6N+2ZpUI327wJoexTa/6+Tyqu20NnYA2zzh8tCkcaO1tkFHKnA jjLaNk/rS/r2luVOoDyyGqM/ujcSa3DbAgotT3KDq99s784yRD8jrMB5+48pj9RmkFwS 313Ft4ncFR0AyqIIXs4fx2bP7U2xt8BaK5IcA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=kki7GX0S+t7hj/hdc6mJj5VtGMKtQZTAwoWP5KR8oJA=; b=pK2nYOJ7amS2ndAYwBcWY6o+BLsfdu1/lpJym4u+s+eN81y+UDtIid8+Rs7354qYp0 K+EFMeanSigrkqrQrydd3cMkbRrtdKYyIkUiQCNK2IMbHqoqE571rj9HYDb2EVIgDbrV N2fheTDr+WkCRmHGP0ebWO0LgW6wqydOS7YGfrT5tZy/10Lfry7h7/eYvSt97CL5nD46 JTOldc7DkgNEZ3U1cwWvSi086EsVzk9FcuFmJuHKYDrfIUYW5AZ/6WQQdPhO5DJIkmPy +TjpEXFitjp70sVVk8H46GQ0WKivV/a69ZdMTZoACe9iOuBWLcZWQR2kA9y9rMbHp2em DPdQ== X-Gm-Message-State: AJcUukdlGoK9edMkcmm3Dhh4PMLzGvL9KEwzvrM1PDSnycEN9BHKprH+ 8NgVlZWaHU4+6p5STecyEsSOOFMTnlYMd8xFm2q4KQ== X-Google-Smtp-Source: ALg8bN61k2I49EIfEaI7zbl2JZ1N1JnLQc4jMeV2GRJPyIicfNIkneVXL61psqRGnawj9on/bi2MeTTm70cokk+5RzM= X-Received: by 2002:a6b:c8c9:: with SMTP id y192mr4101980iof.183.1547052957562; Wed, 09 Jan 2019 08:55:57 -0800 (PST) MIME-Version: 1.0 References: <20190107233833.GI5544@atomide.com> <20190108155354.GL5544@atomide.com> <20190108213743.GN5544@atomide.com> <20190109014218.GA8363@linaro.org> <20190109015124.GO5544@atomide.com> <20190109162846.GP5544@atomide.com> <20190109165004.GQ5544@atomide.com> In-Reply-To: <20190109165004.GQ5544@atomide.com> From: Vincent Guittot Date: Wed, 9 Jan 2019 17:55:46 +0100 Message-ID: Subject: Re: Regression in v5.0-rc1 with autosuspend hrtimers To: Tony Lindgren X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190109_085558_710430_157DFCF6 X-CRM114-Status: GOOD ( 16.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Ladislav Michl , "open list:THERMAL" , "Rafael J. Wysocki" , linux-kernel , "Rafael J. Wysocki" , Linux OMAP Mailing List , LAK Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCA5IEphbiAyMDE5IGF0IDE3OjUwLCBUb255IExpbmRncmVuIDx0b255QGF0b21pZGUu Y29tPiB3cm90ZToKPgo+ICogVmluY2VudCBHdWl0dG90IDx2aW5jZW50Lmd1aXR0b3RAbGluYXJv Lm9yZz4gWzE5MDEwOSAxNjo0OF06Cj4gPiBPbiBXZWQsIDkgSmFuIDIwMTkgYXQgMTc6MjgsIFRv bnkgTGluZGdyZW4gPHRvbnlAYXRvbWlkZS5jb20+IHdyb3RlOgo+ID4gPgo+ID4gPiAqIFJhZmFl bCBKLiBXeXNvY2tpIDxyYWZhZWxAa2VybmVsLm9yZz4gWzE5MDEwOSAwOTo0NF06Cj4gPiA+ID4g T24gV2VkLCBKYW4gOSwgMjAxOSBhdCAyOjUxIEFNIFRvbnkgTGluZGdyZW4gPHRvbnlAYXRvbWlk ZS5jb20+IHdyb3RlOgo+ID4gPiA+ID4KPiA+ID4gPiA+ICogVmluY2VudCBHdWl0dG90IDx2aW5j ZW50Lmd1aXR0b3RAbGluYXJvLm9yZz4gWzE5MDEwOSAwMTo0Ml06Cj4gPiA+ID4gPiA+IExlIFR1 ZXNkYXkgMDggSmFuIDIwMTkgw6AgMTM6Mzc6NDMgKC0wODAwKSwgVG9ueSBMaW5kZ3JlbiBhIMOp Y3JpdCA6Cj4gPiA+ID4gPiA+ID4gTG93ZXJpbmcgdGhlIGF1dG9zdXNwZW5kX2RlbGF5X21zIHRv IDIxMDAgbXMgbWFrZXMgdGhpbmdzIHdvcmsgYWdhaW4uCj4gPiA+ID4gPiA+ID4gQW55dGhpbmcg aGlnaGVyIHRoYW4gMjIwMCBtcyBzZWVtcyB0byBzb21laG93IHRpbWUgb3V0IGltbWVkaWF0ZWx5 Cj4gPiA+ID4gPiA+ID4gbm93IDopCj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IFRoaXMgaXMgcXVp dGUgY2xvc2UgdG8gdGhlIG1heCBucyBvZiBhbiBpbnQgb24gYXJtIDMyYml0cwo+ID4gPiA+ID4g Pgo+ID4gPiA+ID4gPiBDb3VsZCB5b3UgdHJ5IHRoZSBwYXRjaCBiZWxvdyA/Cj4gPiA+ID4gPgo+ ID4gPiA+ID4gWXVwIGdyZWF0IHRoYW5rcywgdGhhdCdzIGl0Ogo+ID4gPiA+ID4KPiA+ID4gPiA+ IFRlc3RlZC1ieTogVG9ueSBMaW5kZ3JlbiA8dG9ueUBhdG9taWRlLmNvbT4KPiA+ID4gPgo+ID4g PiA+IENvb2wuICBUaGFua3MgZm9yIGdldHRpbmcgdG8gdGhlIGJvdHRvbSBvZiB0aGlzIQo+ID4g Pgo+ID4gPiBObyBwcm9ibGVtLgo+ID4gPgo+ID4gPiBPbmUgbW9yZSB0aGluZyBJIG5vdGljZWQ6 IFRoZSAyNSUgc2xhY2sgY2FuIGdldCBub3RpY2VhYmxlCj4gPiA+IGZvciBsYXJnZXIgdmFsdWVz LiBGb3IgdGhpbmdzIGxpa2UgYSAzIHNlY29uZCB1YXJ0IGNvbnNvbGUKPiA+ID4gdGltZW91dCBz bGFjayBvZiA3NTAgbXMgaXMgcXVpdGUgbGFyZ2UgdmFyaWF0aW9uLgo+ID4gPgo+ID4gPiBTaG91 bGQgd2UgaGF2ZSBhIGxpbWl0IG9mIG1heCAxMDAgbXMgZm9yIHRoZSBzbGFjaz8KPiA+Cj4gPiBL ZWVwIGluIG1pbmQgdGhhdCB3aGVuIGppZmZpZXMgd2VyZSB1c2VkLCBleHBpcmVzIHdhcyByb3Vu ZGVkIHRvIGEKPiA+IGZ1bGwgc2Vjb25kIHdoZW4gZGVsYXkgd2FzIGdyZWF0ZXIgdGhhbiBhIHNl Y29uZC4gU28geW91IGNvdWxkIGFscmVhZHkKPiA+IGhhdmUgZGlmZmVyZW5jZSBvZiB1cCA5OTBt cyBvbiBhcm0gYmVmb3JlIHRoaXMgcGF0Y2gKPiA+IEFuZCBpIGRvbid0IHRha2UgaW50byBhY2Nv dW50IHRoZSByZXdvcmsgb2YgdGltZXIgaW5mcmEgd2hpY2ggYWRkCj4gPiBhbm90aGVyIGxldmVs IG9mIHZhcmlhdGlvbiwgc29tZXRoaW5nIGxpa2UgdXAgdG8gNjQwIG1zIG1vcmUgd2hlbiB0aGUK PiA+IHRpbWVyIGlzIGdyZWF0ZXIgdGhhbiAyODgwIG1zIGZvciBhcm0gSUlSQwo+Cj4gSSB0aGlu ayBpdCB3YXMgcm91bmRlZCB1cCBlYXJsaWVyLgo+Cj4gRG9uJ3Qgd2UgZ2V0IHJvdW5kZWQgZG93 biBub3cgYWxzbz8KCldlIHN0aWxsIHJvdW5kIHVwLiBJbiBocnRpbWVyIHdlIGhhdmUgOgp0aW1l ci0+X3NvZnRleHBpcmVzID0gdGltZTsKdGltZXItPm5vZGUuZXhwaXJlcyA9IGt0aW1lX2FkZF9z YWZlKHRpbWUsIGRlbHRhKTsKc28gdGhlIGhydGltZXIgd2lsbCBleHBpcmUgYmV0d2VlbiAidGlt ZSIgYW5kICJ0aW1lK2RlbHRhIgoKPgo+IFJlZ2FyZHMsCj4KPiBUb255CgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==