From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753769AbcHJTQi (ORCPT <rfc822;w@1wt.eu>);
	Wed, 10 Aug 2016 15:16:38 -0400
Received: from mail-wm0-f45.google.com ([74.125.82.45]:36422 "EHLO
	mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753696AbcHJTQe (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 10 Aug 2016 15:16:34 -0400
MIME-Version: 1.0
In-Reply-To: <1470824847-5316-1-git-send-email-dietmar.eggemann@arm.com>
References: <1470824847-5316-1-git-send-email-dietmar.eggemann@arm.com>
From: Vincent Guittot <vincent.guittot@linaro.org>
Date: Wed, 10 Aug 2016 14:28:08 +0200
Message-ID: <CAKfTPtDBSH-XDPMTn9NESVNYFxc6+g69iL5cs5sODOEwbqyfxg@mail.gmail.com>
Subject: Re: [PATCH] sched/fair: Fix load_above_capacity fixed point
 arithmetic width
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Morten Rasmussen <morten.rasmussen@arm.com>,
        Yuyang Du <yuyang.du@intel.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10 August 2016 at 12:27, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
> Since commit 2159197d6677 ("sched/core: Enable increased load resolution
> on 64-bit kernels") we now have two different fixed point units for
> load.
> load_above_capacity has to have 10 bit fixed point unit like PELT
> whereas NICE_0_LOAD has 20 bit fixed point unit on 64-bit kernels.
> Fix this by scaling down NICE_0_LOAD when multiplying
> load_above_capacity with it.
>
> Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
> Acked-by: Morten Rasmussen <morten.rasmussen@arm.com>
> ---
>  kernel/sched/fair.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 4088eedea763..fe4093807852 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -7147,7 +7147,7 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s
>                 load_above_capacity = busiest->sum_nr_running * SCHED_CAPACITY_SCALE;
>                 if (load_above_capacity > busiest->group_capacity) {
>                         load_above_capacity -= busiest->group_capacity;
> -                       load_above_capacity *= NICE_0_LOAD;
> +                       load_above_capacity *= scale_load_down(NICE_0_LOAD);

FWIW, Acked-by: Vincent Guittot <vincent.guittot@linaro.org>

>                         load_above_capacity /= busiest->group_capacity;
>                 } else
>                         load_above_capacity = ~0UL;
> --
> 1.9.1
>