From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84DF4C388F9 for ; Thu, 22 Oct 2020 15:55:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 124AF20770 for ; Thu, 22 Oct 2020 15:55:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="a2nKAl/s" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S368817AbgJVPzj (ORCPT ); Thu, 22 Oct 2020 11:55:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2508545AbgJVPzi (ORCPT ); Thu, 22 Oct 2020 11:55:38 -0400 Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A7ABC0613CF for ; Thu, 22 Oct 2020 08:55:38 -0700 (PDT) Received: by mail-lf1-x141.google.com with SMTP id a9so2884417lfc.7 for ; Thu, 22 Oct 2020 08:55:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=B94icV4D08fxyuirqbKeFO0+DC+wlmdI2voSS4HfZkU=; b=a2nKAl/sqxzLJINGxnAcG79JnKWGYCmMmuWi6RLsPwlt8nfkLwLdwSCvUnGbYmvpDc MTtsMtfwNkk61IAUxdkGoxqSSE4mfXosqmIbjbqIXbhlJ64j8dtDUqPdL9MX5a9Ax0HD Rv2e55ThnRf8lCBFvLT6PAhunCxPg1WKog1urbAK+HFv0/226fGSqAnLvRfPTBuXbjAq 6KpnS7uicUbF8HKROESoEfa8ju/MtMe9z/nflL8aJU3e58ZP34DX2DMtboHRKvD82NDP PonzLbcWohXeAEbjL0MWPvuESfQxC7FQGhnM2wNnX1xndf1k+ASUEZQfYlDyMKoSRch2 rZQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=B94icV4D08fxyuirqbKeFO0+DC+wlmdI2voSS4HfZkU=; b=MvZew2J/e0M2hWODbDQ/HieHUQKgQaADBlQnN+lvHpUWSjw5iFgs3H9TENvywWu4aB RIQph7GA5Aoat8QWar/EVnK6YT8Ol8hcFh0RXlk1YCYVAKvUrX+DYcPtdG1UeZpjTfpG M++64h8+BjkHiuHkKdjs+ClZPfZTzu6VqJEE30aKhM9PwwdQjQB7nUb9Siz3aHIKkN91 KmEbfmOlytBzw7wgJp/YVeTpwne7abs05B70apwkFH9njt/4VsaH4QLqEzJ5lIVWW+yN oW238oZLf48R8eL5sm7U5k10/NaAsvlOdg3fVy6A4Why45vrnvU+WLm3r7lEVM3ROVEl 04JQ== X-Gm-Message-State: AOAM530hsSppeZObqyHeGNGQfVep5xUDISxd74+YvLl77YQOK2LEy5yH remZPTZUMREKSYJU1VN1CAJ4Ff7r4YcF4JEUUYoSag== X-Google-Smtp-Source: ABdhPJxjTfQ97C9WLxpurCzxc+miwHEpL6de8vQZrEHqh3ZUhywXAETlIEZ+DuxXsY3QpVxYIRruL9ABkcGz1M0Z5RU= X-Received: by 2002:a05:6512:2090:: with SMTP id t16mr979176lfr.83.1603382136420; Thu, 22 Oct 2020 08:55:36 -0700 (PDT) MIME-Version: 1.0 References: <1603211879-1064-1-git-send-email-Julia.Lawall@inria.fr> <34115486.YmRjPRKJaA@kreacher> <20201022120213.GG2611@hirez.programming.kicks-ass.net> <1790766.jaFeG3T87Z@kreacher> <20201022122949.GW2628@hirez.programming.kicks-ass.net> In-Reply-To: From: Vincent Guittot Date: Thu, 22 Oct 2020 17:55:24 +0200 Message-ID: Subject: Re: default cpufreq gov, was: [PATCH] sched/fair: check for idle core To: A L Cc: Peter Zijlstra , "Rafael J. Wysocki" , Viresh Kumar , Julia Lawall , Mel Gorman , Ingo Molnar , kernel-janitors@vger.kernel.org, Juri Lelli , Dietmar Eggemann , Steven Rostedt , Ben Segall , Daniel Bristot de Oliveira , linux-kernel , Valentin Schneider , Gilles Muller , Srinivas Pandruvada , Linux PM , Len Brown Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Oct 2020 at 17:45, A L wrote: > > > > ---- From: Peter Zijlstra -- Sent: 2020-10-22 - 14:29 ---- > > > On Thu, Oct 22, 2020 at 02:19:29PM +0200, Rafael J. Wysocki wrote: > >> > However I do want to retire ondemand, conservative and also very much > >> > intel_pstate/active mode. > >> > >> I agree in general, but IMO it would not be prudent to do that without making > >> schedutil provide the same level of performance in all of the relevant use > >> cases. > > > > Agreed; I though to have understood we were there already. > > Hi, > > > Currently schedutil does not populate all stats like ondemand does, which can be a problem for some monitoring software. > > On my AMD 3000G CPU with kernel-5.9.1: > > > grep. /sys/devices/system/cpu/cpufreq/policy0/stats/* > > With ondemand: > time_in_state:3900000 145179 > time_in_state:1600000 9588482 > total_trans:177565 > trans_table: From : To > trans_table: : 3900000 1600000 > trans_table: 3900000: 0 88783 > trans_table: 1600000: 88782 0 > > With schedutil only two file exists: > reset: > total_trans:216609 > > > I'd really like to have these stats populated with schedutil, if that's possible. Your problem might have been fixed with commit 96f60cddf7a1 ("cpufreq: stats: Enable stats for fast-switch as well") > > Thanks. > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent Guittot Date: Thu, 22 Oct 2020 15:55:24 +0000 Subject: Re: default cpufreq gov, was: [PATCH] sched/fair: check for idle core Message-Id: List-Id: References: <1603211879-1064-1-git-send-email-Julia.Lawall@inria.fr> <34115486.YmRjPRKJaA@kreacher> <20201022120213.GG2611@hirez.programming.kicks-ass.net> <1790766.jaFeG3T87Z@kreacher> <20201022122949.GW2628@hirez.programming.kicks-ass.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: A L Cc: Peter Zijlstra , "Rafael J. Wysocki" , Viresh Kumar , Julia Lawall , Mel Gorman , Ingo Molnar , kernel-janitors@vger.kernel.org, Juri Lelli , Dietmar Eggemann , Steven Rostedt , Ben Segall , Daniel Bristot de Oliveira , linux-kernel , Valentin Schneider , Gilles Muller , Srinivas Pandruvada , Linux PM , Len Brown On Thu, 22 Oct 2020 at 17:45, A L wrote: > > > > ---- From: Peter Zijlstra -- Sent: 2020-10-22 - 14:29 ---- > > > On Thu, Oct 22, 2020 at 02:19:29PM +0200, Rafael J. Wysocki wrote: > >> > However I do want to retire ondemand, conservative and also very much > >> > intel_pstate/active mode. > >> > >> I agree in general, but IMO it would not be prudent to do that without making > >> schedutil provide the same level of performance in all of the relevant use > >> cases. > > > > Agreed; I though to have understood we were there already. > > Hi, > > > Currently schedutil does not populate all stats like ondemand does, which can be a problem for some monitoring software. > > On my AMD 3000G CPU with kernel-5.9.1: > > > grep. /sys/devices/system/cpu/cpufreq/policy0/stats/* > > With ondemand: > time_in_state:3900000 145179 > time_in_state:1600000 9588482 > total_trans:177565 > trans_table: From : To > trans_table: : 3900000 1600000 > trans_table: 3900000: 0 88783 > trans_table: 1600000: 88782 0 > > With schedutil only two file exists: > reset: > total_trans:216609 > > > I'd really like to have these stats populated with schedutil, if that's possible. Your problem might have been fixed with commit 96f60cddf7a1 ("cpufreq: stats: Enable stats for fast-switch as well") > > Thanks. >