From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F02A2C433F5 for ; Fri, 17 Sep 2021 15:27:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C6473610C7 for ; Fri, 17 Sep 2021 15:27:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237034AbhIQP2i (ORCPT ); Fri, 17 Sep 2021 11:28:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233835AbhIQP2d (ORCPT ); Fri, 17 Sep 2021 11:28:33 -0400 Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C256FC061574 for ; Fri, 17 Sep 2021 08:27:11 -0700 (PDT) Received: by mail-qk1-x72e.google.com with SMTP id 72so6833648qkk.7 for ; Fri, 17 Sep 2021 08:27:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=b3XLvp+C7BZKXW25qtQnmeavwVREq13mF2t8TnFg7h8=; b=ma9ysC6dZG9BsfBsHogzoGydNfFrVUn1as1xUYntDMccIRrlY99NeyBPhwHd/PxK8J W69EHqcxgp3u7OemM6zJuAPYq5W+lwHJLdmVR0GemDUBsm01UzXg9R1/2Bl8IOjL2IWl vzfe89aY5HuipfX4n9ZSRCUol7TEreaMJP2kBHfRhgMDfzZSDnXEIo958Wvt/zeknR6/ 9+4vWnBOKIjYmXJLd/CV282S1I8LTMVYoBl1fKyT+YiKUB2sivgvB7Wu9/5nx2KbCS0/ 1HXoDsygGoSUYBALVwdn48h6o7ecIf4Gts3LN+RChZySPk3xzrEJfG+nJT2kEH7JDWKm hGkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b3XLvp+C7BZKXW25qtQnmeavwVREq13mF2t8TnFg7h8=; b=24Ur/Vk62ivhhw3saoNsBHi6ZBJ3OSRM6CtWVV0drkwEIpxmbhbOYt5LLcHHMXuk6+ YynY0I7O3aY7KUJFY+zcVJsXvp6+uXsK5FH5ejb5FLHpz7BBZKmr/qCEjmaecxhcdYvV T/zusA9pyAov/1JcQdDSKqyKGIUriIZOpClrjtHZUcuQsj3ehLZelVc+NZTt/0lvEM56 9X35k46h95rlNjFwFhpVrFBeDQ+W+J4w+aJEtEwURVNJe9BE+XH+ZcsYGL5Nt52VulO7 ePDW7/mRQwbyql70vbKPvSKXaCs4Q25iAlEhj9FIoOSN9j7uI5q0p6GRatBhd6qVpB5G 1Tzw== X-Gm-Message-State: AOAM533UFgBwvGQnyZOvHqj1alYf9dns0bCiUlPKS+t4FJUkHdA8gmsf 83u+DjUMIRAIlIX/8rZBUZM4VZXREOYhIaBufQzD8w== X-Google-Smtp-Source: ABdhPJynu1fj/apO6ALW2WO1rvp19yZafCLVj5aI2S/7fbxCB+Cgviatp/AVipcP4rN8wUwU5dAIgkebf0THkNd6sZs= X-Received: by 2002:a5b:142:: with SMTP id c2mr14709743ybp.425.1631892430927; Fri, 17 Sep 2021 08:27:10 -0700 (PDT) MIME-Version: 1.0 References: <20210911011819.12184-1-ricardo.neri-calderon@linux.intel.com> <20210911011819.12184-5-ricardo.neri-calderon@linux.intel.com> In-Reply-To: <20210911011819.12184-5-ricardo.neri-calderon@linux.intel.com> From: Vincent Guittot Date: Fri, 17 Sep 2021 17:27:00 +0200 Message-ID: Subject: Re: [PATCH v5 4/6] sched/fair: Provide update_sg_lb_stats() with sched domain statistics To: Ricardo Neri Cc: "Peter Zijlstra (Intel)" , Ingo Molnar , Juri Lelli , Srikar Dronamraju , Nicholas Piggin , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Len Brown , Srinivas Pandruvada , Tim Chen , Aubrey Li , "Ravi V. Shankar" , Ricardo Neri , Quentin Perret , "Joel Fernandes (Google)" , linuxppc-dev@lists.ozlabs.org, linux-kernel , Aubrey Li , Daniel Bristot de Oliveira , "Rafael J . Wysocki" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 11 Sept 2021 at 03:19, Ricardo Neri wrote: > > Before deciding to pull tasks when using asymmetric packing of tasks, > on some architectures (e.g., x86) it is necessary to know not only the > state of dst_cpu but also of its SMT siblings. The decision to classify > a candidate busiest group as group_asym_packing is done in > update_sg_lb_stats(). Give this function access to the scheduling domain > statistics, which contains the statistics of the local group. > > Cc: Aubrey Li > Cc: Ben Segall > Cc: Daniel Bristot de Oliveira > Cc: Dietmar Eggemann > Cc: Mel Gorman > Cc: Quentin Perret > Cc: Rafael J. Wysocki > Cc: Srinivas Pandruvada > Cc: Steven Rostedt > Cc: Tim Chen > Reviewed-by: Joel Fernandes (Google) > Reviewed-by: Len Brown > Originally-by: Peter Zijlstra (Intel) > Signed-off-by: Peter Zijlstra (Intel) > Signed-off-by: Ricardo Neri Reviewed-by: Vincent Guittot > --- > Changes since v4: > * None > > Changes since v3: > * None > > Changes since v2: > * Introduced this patch. > > Changes since v1: > * N/A > --- > kernel/sched/fair.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 7a054f528bcc..c5851260b4d8 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -8605,6 +8605,7 @@ group_type group_classify(unsigned int imbalance_pct, > * @sg_status: Holds flag indicating the status of the sched_group > */ > static inline void update_sg_lb_stats(struct lb_env *env, > + struct sd_lb_stats *sds, > struct sched_group *group, > struct sg_lb_stats *sgs, > int *sg_status) > @@ -8613,7 +8614,7 @@ static inline void update_sg_lb_stats(struct lb_env *env, > > memset(sgs, 0, sizeof(*sgs)); > > - local_group = cpumask_test_cpu(env->dst_cpu, sched_group_span(group)); > + local_group = group == sds->local; > > for_each_cpu_and(i, sched_group_span(group), env->cpus) { > struct rq *rq = cpu_rq(i); > @@ -9176,7 +9177,7 @@ static inline void update_sd_lb_stats(struct lb_env *env, struct sd_lb_stats *sd > update_group_capacity(env->sd, env->dst_cpu); > } > > - update_sg_lb_stats(env, sg, sgs, &sg_status); > + update_sg_lb_stats(env, sds, sg, sgs, &sg_status); > > if (local_group) > goto next_group; > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B134CC433EF for ; Fri, 17 Sep 2021 15:28:12 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31C3B61164 for ; Fri, 17 Sep 2021 15:28:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 31C3B61164 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4H9yWt5ZT8z3cC2 for ; Sat, 18 Sep 2021 01:28:10 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ma9ysC6d; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2607:f8b0:4864:20::730; helo=mail-qk1-x730.google.com; envelope-from=vincent.guittot@linaro.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ma9ysC6d; dkim-atps=neutral Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4H9yVn5h91z3c5w for ; Sat, 18 Sep 2021 01:27:13 +1000 (AEST) Received: by mail-qk1-x730.google.com with SMTP id m21so18502686qkm.13 for ; Fri, 17 Sep 2021 08:27:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=b3XLvp+C7BZKXW25qtQnmeavwVREq13mF2t8TnFg7h8=; b=ma9ysC6dZG9BsfBsHogzoGydNfFrVUn1as1xUYntDMccIRrlY99NeyBPhwHd/PxK8J W69EHqcxgp3u7OemM6zJuAPYq5W+lwHJLdmVR0GemDUBsm01UzXg9R1/2Bl8IOjL2IWl vzfe89aY5HuipfX4n9ZSRCUol7TEreaMJP2kBHfRhgMDfzZSDnXEIo958Wvt/zeknR6/ 9+4vWnBOKIjYmXJLd/CV282S1I8LTMVYoBl1fKyT+YiKUB2sivgvB7Wu9/5nx2KbCS0/ 1HXoDsygGoSUYBALVwdn48h6o7ecIf4Gts3LN+RChZySPk3xzrEJfG+nJT2kEH7JDWKm hGkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b3XLvp+C7BZKXW25qtQnmeavwVREq13mF2t8TnFg7h8=; b=mofC1fhQVXDBWK58cHwx1OfmRv9hhVdVkqkaJVS1g4y1nBXklV5Saonbjs4nN1Z6yv AryWe6+71ut+lCxq1xLQPXXZX50o7WvbAkWjjLqR6xXtFAEcRNW1wt/RSwfPqFtolIF5 fwa74+8MLK9OpMsKqAMiSIo6UXjwPSUeSw2s3lONbSEA3Bn4tsfuMBlXSfARL5rRs16Y UmEb2v3/d+VABeLaDge3bg/q8sVUFEFHoVW95oJZHcn5FU0O5buflD63rVLTu1SJyfd/ 1eyUA6LI0e6yIvzNsNMcwE6/wyIGvqywbRK1Au2VrM347qY6gaVqHTcZKrNkZvJH9tKH DrmQ== X-Gm-Message-State: AOAM531+lG40LnOaqt19Ofdkcb/pRCQoEexpbx/hlHY9gcjVzF9Yy1Qa Z07wSBNSN2HfhCcjJAb7KGrhe6oaRyByWSB4Ff+0Ig== X-Google-Smtp-Source: ABdhPJynu1fj/apO6ALW2WO1rvp19yZafCLVj5aI2S/7fbxCB+Cgviatp/AVipcP4rN8wUwU5dAIgkebf0THkNd6sZs= X-Received: by 2002:a5b:142:: with SMTP id c2mr14709743ybp.425.1631892430927; Fri, 17 Sep 2021 08:27:10 -0700 (PDT) MIME-Version: 1.0 References: <20210911011819.12184-1-ricardo.neri-calderon@linux.intel.com> <20210911011819.12184-5-ricardo.neri-calderon@linux.intel.com> In-Reply-To: <20210911011819.12184-5-ricardo.neri-calderon@linux.intel.com> From: Vincent Guittot Date: Fri, 17 Sep 2021 17:27:00 +0200 Message-ID: Subject: Re: [PATCH v5 4/6] sched/fair: Provide update_sg_lb_stats() with sched domain statistics To: Ricardo Neri Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juri Lelli , Aubrey Li , Srikar Dronamraju , "Ravi V. Shankar" , "Peter Zijlstra \(Intel\)" , Ricardo Neri , Ben Segall , Srinivas Pandruvada , "Joel Fernandes \(Google\)" , Ingo Molnar , "Rafael J . Wysocki" , Steven Rostedt , Mel Gorman , Len Brown , Nicholas Piggin , Aubrey Li , Dietmar Eggemann , Tim Chen , Quentin Perret , Daniel Bristot de Oliveira , linux-kernel , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, 11 Sept 2021 at 03:19, Ricardo Neri wrote: > > Before deciding to pull tasks when using asymmetric packing of tasks, > on some architectures (e.g., x86) it is necessary to know not only the > state of dst_cpu but also of its SMT siblings. The decision to classify > a candidate busiest group as group_asym_packing is done in > update_sg_lb_stats(). Give this function access to the scheduling domain > statistics, which contains the statistics of the local group. > > Cc: Aubrey Li > Cc: Ben Segall > Cc: Daniel Bristot de Oliveira > Cc: Dietmar Eggemann > Cc: Mel Gorman > Cc: Quentin Perret > Cc: Rafael J. Wysocki > Cc: Srinivas Pandruvada > Cc: Steven Rostedt > Cc: Tim Chen > Reviewed-by: Joel Fernandes (Google) > Reviewed-by: Len Brown > Originally-by: Peter Zijlstra (Intel) > Signed-off-by: Peter Zijlstra (Intel) > Signed-off-by: Ricardo Neri Reviewed-by: Vincent Guittot > --- > Changes since v4: > * None > > Changes since v3: > * None > > Changes since v2: > * Introduced this patch. > > Changes since v1: > * N/A > --- > kernel/sched/fair.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 7a054f528bcc..c5851260b4d8 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -8605,6 +8605,7 @@ group_type group_classify(unsigned int imbalance_pct, > * @sg_status: Holds flag indicating the status of the sched_group > */ > static inline void update_sg_lb_stats(struct lb_env *env, > + struct sd_lb_stats *sds, > struct sched_group *group, > struct sg_lb_stats *sgs, > int *sg_status) > @@ -8613,7 +8614,7 @@ static inline void update_sg_lb_stats(struct lb_env *env, > > memset(sgs, 0, sizeof(*sgs)); > > - local_group = cpumask_test_cpu(env->dst_cpu, sched_group_span(group)); > + local_group = group == sds->local; > > for_each_cpu_and(i, sched_group_span(group), env->cpus) { > struct rq *rq = cpu_rq(i); > @@ -9176,7 +9177,7 @@ static inline void update_sd_lb_stats(struct lb_env *env, struct sd_lb_stats *sd > update_group_capacity(env->sd, env->dst_cpu); > } > > - update_sg_lb_stats(env, sg, sgs, &sg_status); > + update_sg_lb_stats(env, sds, sg, sgs, &sg_status); > > if (local_group) > goto next_group; > -- > 2.17.1 >