From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754404AbaIKLVP (ORCPT ); Thu, 11 Sep 2014 07:21:15 -0400 Received: from mail-ob0-f172.google.com ([209.85.214.172]:37981 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751233AbaIKLVO (ORCPT ); Thu, 11 Sep 2014 07:21:14 -0400 MIME-Version: 1.0 In-Reply-To: <20140911100721.GT3190@worktop.ger.corp.intel.com> References: <1409051215-16788-1-git-send-email-vincent.guittot@linaro.org> <1409051215-16788-9-git-send-email-vincent.guittot@linaro.org> <20140911100721.GT3190@worktop.ger.corp.intel.com> From: Vincent Guittot Date: Thu, 11 Sep 2014 13:20:54 +0200 Message-ID: Subject: Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity To: Peter Zijlstra Cc: Ingo Molnar , linux-kernel , Preeti U Murthy , Russell King - ARM Linux , LAK , Rik van Riel , Morten Rasmussen , Mike Galbraith , Nicolas Pitre , "linaro-kernel@lists.linaro.org" , Daniel Lezcano , Dietmar Eggemann Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11 September 2014 12:07, Peter Zijlstra wrote: > On Tue, Aug 26, 2014 at 01:06:51PM +0200, Vincent Guittot wrote: > >> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c >> index 18db43e..60ae1ce 100644 >> --- a/kernel/sched/fair.c >> +++ b/kernel/sched/fair.c >> @@ -6049,6 +6049,14 @@ static bool update_sd_pick_busiest(struct lb_env *env, >> return true; >> } >> >> + /* >> + * The group capacity is reduced probably because of activity from other >> + * sched class or interrupts which use part of the available capacity >> + */ >> + if ((sg->sgc->capacity_orig * 100) > (sgs->group_capacity * >> + env->sd->imbalance_pct)) >> + return true; >> + >> return false; >> } > > This is unlikely to have worked as intended. You will never reach this, > except on PowerPC >= 7. All other machines will have bailed at the > !ASYM_PACKING check above this. Ah yes, i miss that change while rebasing on rik patches. My use case fall in this wider test now that we always select a busiest group From mboxrd@z Thu Jan 1 00:00:00 1970 From: vincent.guittot@linaro.org (Vincent Guittot) Date: Thu, 11 Sep 2014 13:20:54 +0200 Subject: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity In-Reply-To: <20140911100721.GT3190@worktop.ger.corp.intel.com> References: <1409051215-16788-1-git-send-email-vincent.guittot@linaro.org> <1409051215-16788-9-git-send-email-vincent.guittot@linaro.org> <20140911100721.GT3190@worktop.ger.corp.intel.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11 September 2014 12:07, Peter Zijlstra wrote: > On Tue, Aug 26, 2014 at 01:06:51PM +0200, Vincent Guittot wrote: > >> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c >> index 18db43e..60ae1ce 100644 >> --- a/kernel/sched/fair.c >> +++ b/kernel/sched/fair.c >> @@ -6049,6 +6049,14 @@ static bool update_sd_pick_busiest(struct lb_env *env, >> return true; >> } >> >> + /* >> + * The group capacity is reduced probably because of activity from other >> + * sched class or interrupts which use part of the available capacity >> + */ >> + if ((sg->sgc->capacity_orig * 100) > (sgs->group_capacity * >> + env->sd->imbalance_pct)) >> + return true; >> + >> return false; >> } > > This is unlikely to have worked as intended. You will never reach this, > except on PowerPC >= 7. All other machines will have bailed at the > !ASYM_PACKING check above this. Ah yes, i miss that change while rebasing on rik patches. My use case fall in this wider test now that we always select a busiest group