All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Alejandro Colomar <alx.manpages@gmail.com>
Cc: linux-man <linux-man@vger.kernel.org>,
	"G. Branden Robinson" <g.branden.robinson@gmail.com>
Subject: Re: [PATCH] Various pages: tfix
Date: Sun, 27 Dec 2020 12:54:40 +0100	[thread overview]
Message-ID: <CAKgNAkhSoriQZdagMHMz5QJF59LbmQLddvNCWOGJhDHc5jXxdg@mail.gmail.com> (raw)
In-Reply-To: <20201223190202.12758-1-alx.manpages@gmail.com>

Hi Alex,

On Wed, 23 Dec 2020 at 20:03, Alejandro Colomar <alx.manpages@gmail.com> wrote:
>
> Remove "." at the end of sentence fragments/short single sentences
> in comments.  See: c2e81ff9641a7743b1f47cbf4fcf899c391df77f.
>
> $ sed -i '/[^.]\. \*\//s%\. \*/% */%' man?/*
>
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>

There is probably still a bit of inconsistency in the pages, But, your
change removes some periods what really should be present.

For example:

> --- a/man2/clone.2
> +++ b/man2/clone.2
> @@ -1843,7 +1843,7 @@ childFunc(void *arg)
>
>      /* Keep the namespace open for a while, by sleeping.
>         This allows some experimentation\-\-for example, another
> -       process might join the namespace. */
> +       process might join the namespace */
>
>      sleep(200);
>
> @@ -1887,7 +1887,7 @@ main(int argc, char *argv[])
>      sleep(1);           /* Give child time to change its hostname */
>
>      /* Display hostname in parent\(aqs UTS namespace. This will be
> -       different from hostname in child\(aqs UTS namespace. */
> +       different from hostname in child\(aqs UTS namespace */

Here are a couple of cases where the comment contains two sentences,
but the change removes the period from the second sentence. That's
definitely not right.

My general philosophy is complete sentences in comments should be
terminated by periods. In sentence fragments, especially for tag
comments (i.e., comment on same line as the code), I'm inclined to
omit the period. And there are doubtless inconsistencies in existing
pages (and grey areas). Commit c2e81ff964 was intended to clean up
some of the most obvious cases.

I've made a few more commits now to bring more consistency. (I think
Branden's suggestion that complete sentences should generally always
be punctuated is true.) And I've added some notes to man-pages(7). See
commits f18f9c409...46b20ca1b

Thanks,

Michael

-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

  parent reply	other threads:[~2020-12-27 11:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-23 19:02 [PATCH] Various pages: tfix Alejandro Colomar
2020-12-23 19:17 ` [PATCH v2] " Alejandro Colomar
2020-12-24 23:38   ` G. Branden Robinson
2020-12-27 11:54 ` Michael Kerrisk (man-pages) [this message]
2020-12-28  9:20   ` [PATCH] " Alejandro Colomar (man-pages)
2020-12-28  9:31     ` Alejandro Colomar (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKgNAkhSoriQZdagMHMz5QJF59LbmQLddvNCWOGJhDHc5jXxdg@mail.gmail.com \
    --to=mtk.manpages@gmail.com \
    --cc=alx.manpages@gmail.com \
    --cc=g.branden.robinson@gmail.com \
    --cc=linux-man@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.