From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85CEBC4361B for ; Fri, 4 Dec 2020 21:28:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 584E622CF7 for ; Fri, 4 Dec 2020 21:28:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730652AbgLDV17 (ORCPT ); Fri, 4 Dec 2020 16:27:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730279AbgLDV17 (ORCPT ); Fri, 4 Dec 2020 16:27:59 -0500 Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24C01C061A51; Fri, 4 Dec 2020 13:27:19 -0800 (PST) Received: by mail-io1-xd42.google.com with SMTP id i9so7257654ioo.2; Fri, 04 Dec 2020 13:27:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VqW5xuV/1lTxGcHmiBHYwvfv9PS2BZOwQspVUNm6Gmk=; b=GjGyHwMC38/OQ/ofgcFBN2zOLpxvl8SZ/3FV1TRE1dZu/X5yHNG1V2qUruyFFcK6F1 qcMPYVeyov/gm9K0GZPgx0ouS8gZFYopuu9Frs+wSfINvNtlmnQv5Vc8FyLPD01RKgHg EpOFk4FJneu7Ko/sYtfFpkcb1/8T6VHKMGl46rUpAh0CQqNLAANqb6dFlLLUv+JGChC7 YuQAhJz/qZK9W78y2Rb7daxZY3w3l/LxZw5Rlffq0qKfguJKoY3JT4Q8uEAmwkDiK0Yk RozQcbWSqFp/ME1xxYgvan2CZA4kYQRi2Q58dhMDprZfvV0G5RZIFkbt7OxSdQUg4SrD Takw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VqW5xuV/1lTxGcHmiBHYwvfv9PS2BZOwQspVUNm6Gmk=; b=gdxjMWObZpXOFvT1anI3bi8HhrUvrQyaAZyVtGt1nMJBWf2leBlCjzX6Z0qv4AfINL RNb3M0HTulMPmkdMKTcGryMID3xGa8r98+PCcABZYj6sNLJI5dIRDXr5LghwWJDAY4it hfbYT43epjlj7n4VuWhQoG5TQaq1VmXtdvATTpEvO6F7PQJQuxMXjeBgnwG73Fq3NVzo Xs6Jr9wGeYWIAsOBtIQcXvTR3M7i/1svgsKf8FvIkOWxCGIGGltx+KJgELEpdmSwOS5P XMRKy0cNv1kjoDnCCdLrCD3OPPNjKpzVQz4wZ4HBMHStR7wh8EsjiLPyITmly2imKGFK 2Yxw== X-Gm-Message-State: AOAM531+/Qodv5Nb418+cQCofOci+venMNJHYOW6pL8F/b2dXD2Rk7QZ LWkZ41EfFbx7WKwIBsTVSve2MT1U+PtfK/pcQSU= X-Google-Smtp-Source: ABdhPJxIMC1a82H6iLiyCFqEN0vjxjwh8XlAwFQGCRVIUw7bOduA99DaSEZLqbBT0opev2aRmHTxlyRn4kB3zOeMqcM= X-Received: by 2002:a5e:9812:: with SMTP id s18mr1553635ioj.138.1607117238450; Fri, 04 Dec 2020 13:27:18 -0800 (PST) MIME-Version: 1.0 References: <20201204200920.133780-1-mario.limonciello@dell.com> In-Reply-To: <20201204200920.133780-1-mario.limonciello@dell.com> From: Alexander Duyck Date: Fri, 4 Dec 2020 13:27:07 -0800 Message-ID: Subject: Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM To: Mario Limonciello Cc: Jeff Kirsher , Tony Nguyen , intel-wired-lan , LKML , Linux PM , Netdev , Jakub Kicinski , Sasha Netfin , Aaron Brown , Stefan Assmann , David Miller , David Arcari , Yijun Shen , Perry.Yuan@dell.com, anthony.wong@canonical.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 4, 2020 at 12:09 PM Mario Limonciello wrote: > > commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems") > disabled s0ix flows for systems that have various incarnations of the > i219-LM ethernet controller. This was done because of some regressions > caused by an earlier > commit 632fbd5eb5b0e ("e1000e: fix S0ix flows for cable connected case") > with i219-LM controller. > > Performing suspend to idle with these ethernet controllers requires a properly > configured system. To make enabling such systems easier, this patch > series allows determining if enabled and turning on using ethtool. > > The flows have also been confirmed to be configured correctly on Dell's Latitude > and Precision CML systems containing the i219-LM controller, when the kernel also > contains the fix for s0i3.2 entry previously submitted here and now part of this > series. > https://marc.info/?l=linux-netdev&m=160677194809564&w=2 > > Patches 4 through 7 will turn the behavior on by default for some of Dell's > CML and TGL systems. The patches look good to me. Just need to address the minor issue that seems to have been present prior to the introduction of this patch set. Reviewed-by: Alexander Duyck From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Duyck Date: Fri, 4 Dec 2020 13:27:07 -0800 Subject: [Intel-wired-lan] [PATCH v3 0/7] Improve s0ix flows for systems i219LM In-Reply-To: <20201204200920.133780-1-mario.limonciello@dell.com> References: <20201204200920.133780-1-mario.limonciello@dell.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Fri, Dec 4, 2020 at 12:09 PM Mario Limonciello wrote: > > commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems") > disabled s0ix flows for systems that have various incarnations of the > i219-LM ethernet controller. This was done because of some regressions > caused by an earlier > commit 632fbd5eb5b0e ("e1000e: fix S0ix flows for cable connected case") > with i219-LM controller. > > Performing suspend to idle with these ethernet controllers requires a properly > configured system. To make enabling such systems easier, this patch > series allows determining if enabled and turning on using ethtool. > > The flows have also been confirmed to be configured correctly on Dell's Latitude > and Precision CML systems containing the i219-LM controller, when the kernel also > contains the fix for s0i3.2 entry previously submitted here and now part of this > series. > https://marc.info/?l=linux-netdev&m=160677194809564&w=2 > > Patches 4 through 7 will turn the behavior on by default for some of Dell's > CML and TGL systems. The patches look good to me. Just need to address the minor issue that seems to have been present prior to the introduction of this patch set. Reviewed-by: Alexander Duyck