From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 573E6C11F64 for ; Mon, 28 Jun 2021 19:58:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 340B061CAF for ; Mon, 28 Jun 2021 19:58:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232573AbhF1UBN (ORCPT ); Mon, 28 Jun 2021 16:01:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237180AbhF1UBM (ORCPT ); Mon, 28 Jun 2021 16:01:12 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20C22C061574; Mon, 28 Jun 2021 12:58:46 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id s15so27673012edt.13; Mon, 28 Jun 2021 12:58:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ci4Q5smafeUfWmX+diClg5kPOpeaGc5Nu6p9Y9QFirM=; b=YrKIKLBlHOg94pij0c3zzE6MZHNQ/aZCgAOIiYYyKP5cnPvphb2izFrkfYTULSXPA8 Jq8cK9fTicyUqHKtgXyp2/WXCgRF/LX4q+CFZS2rg0+uCAQx+9m61cGlr8ZkmGLSbu1h Od0SudAA9PYpxzQQoBTc1L/I7hcpVNtl4QbjXs0P02FlXtrdPTqKTDu1SYq0sUCwmNAh mcb8aX9KdgaLpP+pVG+YNdJwT0Q+3qGDaLXmozapfVXdKKFZCaQ1k0/alWSxuHkYn0xk yfAagEHhs1IFzScxlltybBbClOJL4l5Ecfrb59OSceF6saVt8lyDrf6NiedogVuKnbyD F4bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ci4Q5smafeUfWmX+diClg5kPOpeaGc5Nu6p9Y9QFirM=; b=KVYVA+XRNXGgiWqfNjUiV8+XD5sEbeEuuMpnfnW8zW3x/uQayzhCW8sO1r+tdBVxYl IHwQb+FiMgRcbatpVzrVnHNRKalSURHsphfEgVcwugSmOeVULJ1aF2YxBwe4+QBEDpSY IMRMtBIY225tosPuSwPbKqdzN+AXPwvuSfczlQ97HPBH9jHhJEoeKnp6f5EXlrQSkcHt h90nxviIx1cUEHtIIVA4HgOr47mi7ZnO7IZczOK72czkMQ59N8/PomgGtE6e81qwRsCG 9Byb26q6qNSjWkECk5a64l42ruCv63TGbksLY7V6VeqhphAj0fzfr/GINqZQVFs4F4rV pBkw== X-Gm-Message-State: AOAM530G2QuS10LDcLzYH8pQMYHbhnygRmNJH2EWUECvSpBB/uujcDTZ axSNHCTzOX6qS9NvktBkS/EYxWGZ0BHTtKB5y74= X-Google-Smtp-Source: ABdhPJwbzD0ghwtgnYjwoP9dPWVhj3sBdwvwjYUOt5HkruBSOENDNS1AwJM3SUyGc2hwb/XjJsvfgqNnystITvc+PfY= X-Received: by 2002:a05:6402:40c4:: with SMTP id z4mr35516888edb.364.1624910324585; Mon, 28 Jun 2021 12:58:44 -0700 (PDT) MIME-Version: 1.0 References: <8ad0d38259a678fb42245368f974f1a5cf47d68d.1623674025.git.lorenzo@kernel.org> In-Reply-To: <8ad0d38259a678fb42245368f974f1a5cf47d68d.1623674025.git.lorenzo@kernel.org> From: Alexander Duyck Date: Mon, 28 Jun 2021 12:58:33 -0700 Message-ID: Subject: Re: [PATCH v9 bpf-next 01/14] net: skbuff: add data_len field to skb_shared_info To: Lorenzo Bianconi Cc: bpf , Netdev , lorenzo.bianconi@redhat.com, David Miller , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , shayagr@amazon.com, "Jubran, Samih" , John Fastabend , David Ahern , Jesper Dangaard Brouer , Eelco Chaudron , Jason Wang , Saeed Mahameed , Maciej Fijalkowski , "Karlsson, Magnus" , Tirthendu Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Jun 14, 2021 at 5:50 AM Lorenzo Bianconi wrote: > > data_len field will be used for paged frame len for xdp_buff/xdp_frame. > This is a preliminary patch to properly support xdp-multibuff > > Signed-off-by: Lorenzo Bianconi > --- > include/linux/skbuff.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h > index dbf820a50a39..332ec56c200d 100644 > --- a/include/linux/skbuff.h > +++ b/include/linux/skbuff.h > @@ -522,7 +522,10 @@ struct skb_shared_info { > struct sk_buff *frag_list; > struct skb_shared_hwtstamps hwtstamps; > unsigned int gso_type; > - u32 tskey; > + union { > + u32 tskey; > + u32 data_len; > + }; > Rather than use the tskey field why not repurpose the gso_size field? I would think in the XDP paths that the gso fields would be unused since LRO and HW_GRO would be incompatible with XDP anyway.