From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Duyck Subject: Re: [net-next PATCH v3 4/6] udp: Partially unroll handling of first segment and last segment Date: Mon, 7 May 2018 12:59:28 -0700 Message-ID: References: <20180507180310.3486.35994.stgit@localhost.localdomain> <20180507180840.3486.67728.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Network Development , Willem de Bruijn , David Miller To: Willem de Bruijn Return-path: Received: from mail-ot0-f176.google.com ([74.125.82.176]:34390 "EHLO mail-ot0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752081AbeEGT7a (ORCPT ); Mon, 7 May 2018 15:59:30 -0400 Received: by mail-ot0-f176.google.com with SMTP id i5-v6so21748003otf.1 for ; Mon, 07 May 2018 12:59:30 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Mon, May 7, 2018 at 12:54 PM, Willem de Bruijn wrote: > On Mon, May 7, 2018 at 2:57 PM, Willem de Bruijn > wrote: >> On Mon, May 7, 2018 at 2:08 PM, Alexander Duyck >> wrote: >>> From: Alexander Duyck >>> >>> This patch allows us to take care of unrolling the first segment and the >>> last segment of the loop for processing the segmented skb. Part of the >>> motivation for this is that it makes it easier to process the fact that the >>> first fame and all of the frames in between should be mostly identical >>> in terms of header data, and the last frame has differences in the length >>> and partial checksum. >>> >>> In addition I am dropping the header length calculation since we don't >>> really need it for anything but the last frame and it can be easily >>> obtained by just pulling the data_len and offset of tail from the transport >>> header. >>> >>> Signed-off-by: Alexander Duyck >> >> I'm not a fan of the more complicated control flow, as I pointed out >> before. It only seems to save one assignment to uh from segs. >> >> Both follow-up patches are now more complex, because they need >> to add the same code in two locations. > > With that said, if you feel strongly, I don't object. > > The removal of hdrlen and simplification of arguments is definitely > an improvement. Thanks for being understanding about this. My preference is to keep the loop unrolled as it is since that way it is not too different from the way we handle this for TCP so it will maintenance of the two easier. Otherwise I have to add a bunch of conditional checks inside the loop. The other advantage to unrolling it as I did is that I don't have to deal with a ton of extra indentation for an if statement inside of a while loop. - Alex