From: Alexander Duyck <alexander.duyck@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v1] igc: Add set_rx_mode support
Date: Wed, 18 Sep 2019 13:29:58 -0700 [thread overview]
Message-ID: <CAKgT0Ue2rti-T1F9N02ejv2qgQuu7pM6aFCh7QJSys-B2MiNBw@mail.gmail.com> (raw)
In-Reply-To: <d0ecf9ed-f12f-f204-5223-6f845150a56d@redhat.com>
On Wed, Sep 18, 2019 at 12:29 PM David Arcari <darcari@redhat.com> wrote:
>
> Hi,
>
> On 09/10/2019 03:05 AM, Sasha Neftin wrote:
> > Add multicast addresses list to the MTA table.
> > Implement promiscious mode and add basic rx mode support.
> > Add option for ipv6 address settings.
> >
> > Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
>
> This seems to break ipv4 communication over vlans:
Why is this code messing with the VLANs? The patch description says it
is enabling multicast and the MTA but it is messing with the VFTA
table as well. That is probably what broke the VLANs.
I don't see the bits to support ndo_vlan_rx_[add|kill]_vid and without
that it will break VLANs since the driver is filtering them unless
promiscuous filtering is enabled. The VLAN changes should be moved
into a separate patch.
next prev parent reply other threads:[~2019-09-18 20:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 7:05 [Intel-wired-lan] [PATCH v1] igc: Add set_rx_mode support Sasha Neftin
2019-09-14 0:46 ` Vinicius Costa Gomes
2019-09-15 10:54 ` Neftin, Sasha
2019-09-14 1:07 ` Brown, Aaron F
2019-09-18 19:29 ` David Arcari
2019-09-18 20:29 ` Alexander Duyck [this message]
2019-09-19 5:48 ` Neftin, Sasha
2019-09-19 11:49 ` David Arcari
2019-09-19 12:56 ` Neftin, Sasha
2019-09-24 10:25 ` Neftin, Sasha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKgT0Ue2rti-T1F9N02ejv2qgQuu7pM6aFCh7QJSys-B2MiNBw@mail.gmail.com \
--to=alexander.duyck@gmail.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.