All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Duyck <alexander.duyck@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linux MM <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH -next] mm: page_alloc: fix kernel-doc warning
Date: Wed, 8 Apr 2020 07:54:00 -0700	[thread overview]
Message-ID: <CAKgT0UeGiCvcmEwJ1AL7AP8_ZxAbO9CnVwLzmbKQ9FAMSkJ_ag@mail.gmail.com> (raw)
In-Reply-To: <02998bd4-0b82-2f15-2570-f86130304d1e@infradead.org>

On Tue, Apr 7, 2020 at 9:30 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Add description of function parameter 'mt' to fix kernel-doc warning:
>
> ../mm/page_alloc.c:3246: warning: Function parameter or member 'mt' not described in '__putback_isolated_page'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Thanks for catching this. The fix looks good to me.

Acked-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>

> ---
>  mm/page_alloc.c |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-next-20200407.orig/mm/page_alloc.c
> +++ linux-next-20200407/mm/page_alloc.c
> @@ -3238,6 +3238,7 @@ int __isolate_free_page(struct page *pag
>   * __putback_isolated_page - Return a now-isolated page back where we got it
>   * @page: Page that was isolated
>   * @order: Order of the isolated page
> + * @mt: The page's pageblock's migratetype
>   *
>   * This function is meant to return a page pulled from the free lists via
>   * __isolate_free_page back to the free lists they were pulled from.
>
>

  reply	other threads:[~2020-04-08 14:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-08  4:29 [PATCH -next] mm: page_alloc: fix kernel-doc warning Randy Dunlap
2020-04-08 14:54 ` Alexander Duyck [this message]
2020-04-08 14:54   ` Alexander Duyck
2020-04-09  6:53 ` Pankaj Gupta
2020-04-09  6:53   ` Pankaj Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKgT0UeGiCvcmEwJ1AL7AP8_ZxAbO9CnVwLzmbKQ9FAMSkJ_ag@mail.gmail.com \
    --to=alexander.duyck@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.