From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Duyck Subject: Re: [net-next PATCH v2 0/8] UDP GSO Segmentation clean-ups Date: Mon, 7 May 2018 11:02:18 -0700 Message-ID: References: <20180504182537.5194.72775.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Network Development , Willem de Bruijn , David Miller To: Willem de Bruijn Return-path: Received: from mail-ot0-f181.google.com ([74.125.82.181]:42258 "EHLO mail-ot0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752529AbeEGSCU (ORCPT ); Mon, 7 May 2018 14:02:20 -0400 Received: by mail-ot0-f181.google.com with SMTP id l13-v6so33011005otk.9 for ; Mon, 07 May 2018 11:02:20 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Sat, May 5, 2018 at 3:06 AM, Willem de Bruijn wrote: > On Fri, May 4, 2018 at 8:28 PM, Alexander Duyck > wrote: >> This patch set addresses a number of issues I found while sorting out >> enabling UDP GSO Segmentation support for ixgbe/ixgbevf. Specifically there >> were a number of issues related to the checksum and such that seemed to >> cause either minor irregularities or kernel panics in the case of the >> offload request being allowed to traverse between name spaces. > > Were you able to traverse GSO packets between network namespace before > adding to NETIF_F_GSO_SOFTWARE? It does appear that veth includes > NETIF_F_GSO_ENCAP_ALL, which also allows GSO. Without that change the tunnel wouldn't pass the requests between namespaces. However with it I was able to easily test the software checksum code as otherwise the socket was returning EIO when the hardware checksum was disabled. > In either case, it should not be possible for GSO packets to arrive on a veth > device, as that can result in queuing the GSO packet to a recipient socket. > In this regard veth is like loopback and must exclude GSO support. > > I'll take a look. I suspect it was probably sending veth UDP segmentation offload requests. For now I can probably drop he patch that was adding it and it can be added later to individual drivers if needed. Thanks. - Alex