From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Duyck Date: Thu, 13 Feb 2020 08:59:16 -0800 Subject: [Intel-wired-lan] [PATCH v1 1/1] igc: Complete to commit Add support for TSO In-Reply-To: References: <20200205123115.44103-1-sasha.neftin@intel.com> <309B89C4C689E141A5FF6A0C5FB2118B971F357D@ORSMSX103.amr.corp.intel.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Thu, Feb 13, 2020 at 12:02 AM Neftin, Sasha wrote: > > On 2/13/2020 00:47, Alexander Duyck wrote: > > On Wed, Feb 12, 2020 at 2:39 PM Brown, Aaron F wrote: > >> > >>> From: Intel-wired-lan On Behalf Of > >>> Sasha Neftin > >>> Sent: Wednesday, February 5, 2020 4:31 AM > >>> To: intel-wired-lan at lists.osuosl.org > >>> Subject: [Intel-wired-lan] [PATCH v1 1/1] igc: Complete to commit Add > >>> support for TSO > >>> > >>> commit f38b782dccab ("igc: Add support for TSO") > >>> Add option to setting transmit command (TUCMD) of the context > >>> descriptor based on skb_shinfo gso_type and SKB_GSO_UDP_L4 flag. > >>> > >>> Signed-off-by: Sasha Neftin > >>> --- > >>> drivers/net/ethernet/intel/igc/igc_defines.h | 1 + > >>> drivers/net/ethernet/intel/igc/igc_main.c | 3 ++- > >>> 2 files changed, 3 insertions(+), 1 deletion(-) > >>> > >> Aside from possibly including the responses to Jesse's questions on this... > >> Tested-by: Aaron Brown > > > > I'm not sure the patch makes any sense. Does the driver support UDP > > GSO? I don't see the feature flag (NETIF_F_GSO_UDP_L4) anywhere that > > enables it. > > > Yes, it is supported. The MAC is similar to igb from segmentation > perspectives. I missed add it. Please, let me finish some testing and I > will add NETIF_F_GSO_UDP_L4 flag to _features_check and _probe methods. Thats fine. I just wouldn't submit this patch as it is. It should be adding the NETIF_F_GSO_UDP_L4 flag so you can actually test the code and verify the hardware is handling it correctly.