From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexander Duyck <alexander.duyck@gmail.com>
Subject: Re: [net-next PATCH v2 2/8] udp: Verify that pulling UDP header in
 GSO segmentation doesn't fail
Date: Sat, 5 May 2018 10:10:10 -0700
Message-ID: <CAKgT0Uerb_kFACnEMmJM1KPSzzbCdmHMjnP5A36SS8sgy0-q5w@mail.gmail.com>
References: <20180504182537.5194.72775.stgit@localhost.localdomain>
 <20180504182857.5194.45504.stgit@localhost.localdomain> <CAF=yD-KcG5ic9PRPSqdVRZon-W=9_rgSQ0JuSC3ApMqS4vDJgw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Network Development <netdev@vger.kernel.org>,
        Willem de Bruijn <willemb@google.com>,
        David Miller <davem@davemloft.net>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-ot0-f177.google.com ([74.125.82.177]:46704 "EHLO
        mail-ot0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751183AbeEERKL (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 5 May 2018 13:10:11 -0400
Received: by mail-ot0-f177.google.com with SMTP id t1-v6so27804010ott.13
        for <netdev@vger.kernel.org>; Sat, 05 May 2018 10:10:11 -0700 (PDT)
In-Reply-To: <CAF=yD-KcG5ic9PRPSqdVRZon-W=9_rgSQ0JuSC3ApMqS4vDJgw@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Sat, May 5, 2018 at 1:12 AM, Willem de Bruijn
<willemdebruijn.kernel@gmail.com> wrote:
> On Fri, May 4, 2018 at 8:29 PM, Alexander Duyck
> <alexander.duyck@gmail.com> wrote:
>> From: Alexander Duyck <alexander.h.duyck@intel.com>
>>
>> We should verify that we can pull the UDP header before we attempt to do
>> so. Otherwise if this fails we have no way of knowing and GSO will not work
>> correctly.
>
> This already happened in the callers udp[46]_ufo_fragment

Ah. Okay I didn't see that. I may add a comment somewhere indicating
that is the case as it is a bit buried with all the calls.

Thanks.

- Alex